skia2/infra/bots
Leandro Lovisolo 17fbcd145b ios.py: Bugfix to prevent iOS tasks from failing with "Error: ImageMountFailed".
This CL fixes a bug in the logic that checks whether there's an image mounted on the attached iOS device.

Currently this is determined by checking whether strings "ImagePresent: true" or "ImageSignature:" are present in the output of command "ideviceimagemounter --list". However, these strings do not match the command's actual output:

  # No image mounted.
  $ ideviceimagemounter --list
  Status: Complete

  # Image mounted (fake signature for illustrative purposes).
  $ ideviceimagemounter --list
  ImageSignature[1]:
   0: Rm9yIGlsbHVzdHJhdGl2ZSBwdXJwb3NlcyBvbmx5LiBUaGlzIGlzIG5vdCBhIHJlYWwgc2lnbmF0dXJlLg==
  Status: Complete

As is, the recipe fails to detect that an image is already mounted on the attached iOS device. The recipe then tries to mount one, which makes the "ideviceimagemounter" command fail with "Error: ImageAlreadyMounted". The following example shows how to reproduce this error:

  # Initially no image is mounted.
  $ ideviceimagemounter --list
  Status: Complete

  # Mount an image.
  $ ideviceimagemounter DeveloperDiskImage.dmg DeveloperDiskImage.dmg.signature
  Uploading DeveloperDiskImage.dmg
  done.
  Mounting...
  Done.
  Status: Complete

  # Verify that the image is mounted.
  $ ideviceimagemounter --list
  ImageSignature[1]:
   0: Rm9yIGlsbHVzdHJhdGl2ZSBwdXJwb3NlcyBvbmx5LiBUaGlzIGlzIG5vdCBhIHJlYWwgc2lnbmF0dXJlLg==
  Status: Complete

  # Try to mount an image when one is already mounted.
  $ ideviceimagemounter DeveloperDiskImage.dmg DeveloperDiskImage.dmg.signature
  Uploading DeveloperDiskImage.dmg
  done.
  Mounting...
  Error: ImageMountFailed

Checking for presence of string "ImageSignature" in the ideviceimagemounter command's output seems to solve the problem.

In the process I also discovered that self._run() requires keyword argument stdout=self.m.raw_io.output() in order to return the command's output. As is, the returned stdout is always blank.

Note to reviewer:
- Patchsets 1 to 11 iterate on a potential fix.
- Patchset 12 reproduces the bug. See the failing tryjob.
- Patchset 13 tries the fix. See the successful tryjob.
- Patchsets 14+ clean up the CL.

Change-Id: I3ca1cdbf4bfa450c3e87d6d87b5f615f28c4aaba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281058
Reviewed-by: Weston Tracey <westont@google.com>
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
2020-04-02 19:18:06 +00:00
..
android_compile [Tree Status] Update all references in Skia repo to tree-status 2020-03-02 18:43:49 +00:00
assets Update SKP version 2020-03-29 08:41:05 +00:00
buildstats Build code size treemaps for skottie_tool 2019-02-12 13:54:00 +00:00
g3_compile [Tree Status] Update all references in Skia repo to tree-status 2020-03-02 18:43:49 +00:00
gen_tasks_logic Broke Debian9 things in skolo. 2020-04-02 14:51:36 +00:00
recipe_modules ios.py: Bugfix to prevent iOS tasks from failing with "Error: ImageMountFailed". 2020-04-02 19:18:06 +00:00
recipes [infra] Move logic about skps/images/etc into gen_tasks 2020-03-23 13:42:43 +00:00
tools/luci-go
assets.isolate
build_task_drivers.sh [infra] Fix build_task_drivers.sh, update infra dep 2020-01-08 14:53:41 +00:00
bundle_recipes.sh
calmbench.isolate
canvaskit.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
cfg.json Enable ASAN on Windows 2019-12-30 17:06:26 +00:00
check_deps.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
compile_android_framework.isolate [infra] swarm_recipe.isolate shouldn't need infrabots.isolate 2019-07-19 18:40:02 +00:00
compile_g3_framework.isolate Fix G3 compile bot 2019-07-22 21:09:38 +00:00
compile.isolate Roll Dawn and add dependencies 2020-03-30 18:52:06 +00:00
empty.isolate
gen_compile_isolate.py fix build minimal_ios_mtl_skia_app 2019-12-16 19:44:36 +00:00
gen_tasks.go Reland "[infra] Make most builds idempotent" 2019-07-19 12:11:27 +00:00
git_utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
infra_tests.isolate [infra] swarm_recipe.isolate shouldn't need infrabots.isolate 2019-07-19 18:40:02 +00:00
infra_tests.py [infra] Run recipe and python unittests unbuffered 2020-03-18 15:33:38 +00:00
infrabots.isolate
ios_bin.isolate Remove OS condition from isolate files 2019-02-28 17:40:00 +00:00
isolate_android_sdk_linux.isolate
isolate_gcloud_linux.isolate
isolate_go.isolate
jobs.json Broke Debian9 things in skolo. 2020-04-02 14:51:36 +00:00
lottie_web.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
Makefile
OWNERS [infra] Remove stephana@ from OWNERS 2019-06-21 12:07:54 +00:00
pathkit.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
perf_skia_bundled.isolate Remove OS condition from isolate files 2019-02-28 17:40:00 +00:00
README.md Add more detail on configuring jobs. 2019-03-21 10:54:17 +00:00
recipes.isolate [infra] Trim down isolate for recipe bundle 2019-06-27 18:27:44 +00:00
recipes.py Roll recipe dependencies (trivial). 2019-05-22 17:57:25 +00:00
resources.isolate
run_recipe.isolate [infra] Use Swarming task ID for logdog URL 2019-06-27 18:51:56 +00:00
run_recipe.py [infra] Use CIPD packages from infra repo 2019-11-20 14:02:48 +00:00
skottie_wasm.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
skpbench_skia_bundled.isolate
skqp.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
swarm_recipe.isolate [infra] swarm_recipe.isolate shouldn't need infrabots.isolate 2019-07-19 18:40:02 +00:00
task_drivers.isolate [infra] Add UpdateGoDeps bot 2019-06-18 18:25:13 +00:00
tasks.json Update Go Deps 2020-04-02 17:05:36 +00:00
test_skia_bundled.isolate Remove OS condition from isolate files 2019-02-28 17:40:00 +00:00
test_utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
update_meta_config.py Change name from skia.primary->luci.skia.skia.primary 2020-02-06 13:14:21 +00:00
upload_skps.py [Android compile bots] Add comment to CL when both nopatch and withpatch builds fail 2019-10-28 14:55:01 +00:00
utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
zip_utils_test.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
zip_utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00

Skia Infrastructure

This directory contains infrastructure elements.

Tasks and Jobs

Files in this directory define a DAG of tasks which run at every Skia commit. A task is a small, self-contained unit which runs via Swarming on a machine in the pool. Tasks may be chained together, eg. one task to compile test binaries and another to actually run them.

Jobs are collections of related tasks which help define sub-sections of the DAG, for example, to be used as try jobs. Each job is defined as an entry point into the DAG.

The tasks.json file in this directory is the master list of tasks and jobs for the repo. Note that tasks.json is NEVER edited by hand but generated via gen_task.go and the input files enumerated below. The Task Scheduler reads the tasks.json file at each commit to determine which jobs to run. For convenience, gen_tasks.go is provided to generate tasks.json and also to test it for correct syntax and detecting cycles and orphaned tasks. Always edit gen_tasks.go or one of the following input JSON files, rather than tasks.json itself:

  • cfg.json - Basic configuration information for gen_tasks.go.
  • jobs.json - The master list of all jobs to run. Edit this to add or remove bots.

Whenever gen_tasks.go, any of the above JSON files, or assets are changed, you need to run gen_tasks.go to regenerate tasks.json:

$ go run infra/bots/gen_tasks.go

Or:

$ cd infra/bots; make train

There is also a test mode which performs sanity-checks and verifies that tasks.json is unchanged:

$ go run infra/bots/gen_tasks.go --test

Or:

$ cd infra/bots; make test

Recipes

Recipes are the framework used by Skia's infrastructure to perform work inside of Swarming tasks. The main elements are:

  • recipes.py - Used for running and testing recipes.
  • recipes - These are the entry points for each type of task, eg. compiling or running tests.
  • recipe_modules - Shared modules which are used by recipes.
  • .recipe_deps - Recipes and modules may depend on modules from other repos. The recipes.py script automatically syncs those dependencies in this directory.

Isolate Files

These files determine which parts of the repository are transferred to the bot when a Swarming task is triggered. The Isolate tool hashes each file and will upload any new/changed files. Bots maintain a cache so that they can efficiently download only the files they don't have.

Assets

Artifacts used by the infrastructure are versioned here, along with scripts for recreating/uploading/downloading them. See the README in that directory for more information. Any time an asset used by the bots changes, you need to re-run gen_tasks.go.

Tools

Assorted other infrastructure-related tools, eg. isolate and CIPD binaries.

CT

Helpers for running Skia tasks in Cluster Telemetry.