08ece0c9a0
PS1 regenerates the Bazel files. Use it as the base change when
comparing patchsets.
IWYU seems to do a good job of working with MyFile.cpp and
MyFile.h, but if there is just a MyHeader.h, it doesn't always
seem to throw errors if the includes aren't correct. This was
observed with include/sksl/DSL.h This might be due to the fact
that headers are not compiled on their own, so they are never
sent directly to the IWYU binary.
This change sets enforce_iwyu_on_package() on the all sksl
packages and then fixes the includes until all those checks
are happy. There were a few files that needed fixes outside
of the sksl folder. Examples include:
- src/gpu/effects/GrConvexPolyEffect.cpp
- tests/SkSLDSLTest.cpp
To really enforce this, we need to add a CI/CQ job that runs
bazel build //example:hello_world_gl --config=clang \
--sandbox_base=/dev/shm --features skia_enforce_iwyu
If that failed, a dev could make the changes described in
the logs and/or run the command locally to see those
prescribed fixes.
I had to add several entries to toolchain/IWYU_mapping.imp
in order to fix some private includes and other atypical
choices. I tried adding a rule there to allow inclusion of
SkTypes.h to make sure defines like SK_SUPPORT_GPU, but
could not get it to work for all cases, so I deferred to
using the IWYU pragma: keep (e.g. SkSLPipelineStageCodeGenerator.h)
Change-Id: I4c3e536d8e69ff7ff2d26fe61a525a6c2e80db06
Bug: skia:13052
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522256
Reviewed-by: John Stiles <johnstiles@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
42 lines
1.5 KiB
C++
42 lines
1.5 KiB
C++
/*
|
|
* Copyright 2021 Google LLC
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "include/sksl/SkSLErrorReporter.h"
|
|
#include "src/gpu/GrShaderCaps.h"
|
|
#include "src/sksl/SkSLBuiltinTypes.h"
|
|
#include "src/sksl/SkSLContext.h"
|
|
#include "src/sksl/SkSLMangler.h"
|
|
#include "src/sksl/ir/SkSLType.h"
|
|
#include "tests/Test.h"
|
|
|
|
#include <cstdint>
|
|
#include <limits>
|
|
#include <memory>
|
|
|
|
DEF_TEST(SkSLTypeLimits, r) {
|
|
GrShaderCaps caps;
|
|
SkSL::TestingOnly_AbortErrorReporter errors;
|
|
SkSL::Mangler mangler;
|
|
SkSL::Context context(errors, caps, mangler);
|
|
|
|
using int_limits = std::numeric_limits<int32_t>;
|
|
REPORTER_ASSERT(r, context.fTypes.fInt->minimumValue() == int_limits::min());
|
|
REPORTER_ASSERT(r, context.fTypes.fInt->maximumValue() == int_limits::max());
|
|
|
|
using short_limits = std::numeric_limits<int16_t>;
|
|
REPORTER_ASSERT(r, context.fTypes.fShort->minimumValue() == short_limits::min());
|
|
REPORTER_ASSERT(r, context.fTypes.fShort->maximumValue() == short_limits::max());
|
|
|
|
using uint_limits = std::numeric_limits<uint32_t>;
|
|
REPORTER_ASSERT(r, context.fTypes.fUInt->minimumValue() == uint_limits::min());
|
|
REPORTER_ASSERT(r, context.fTypes.fUInt->maximumValue() == uint_limits::max());
|
|
|
|
using ushort_limits = std::numeric_limits<uint16_t>;
|
|
REPORTER_ASSERT(r, context.fTypes.fUShort->minimumValue() == ushort_limits::min());
|
|
REPORTER_ASSERT(r, context.fTypes.fUShort->maximumValue() == ushort_limits::max());
|
|
}
|