AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
18ac3ef222
skia2/infra/bots
History
Ravi Mistry 18ac3ef222 Revert "[infra] Use Python3 for our Presubmits" 
This reverts commit 094bcdb9e5.

Reason for revert: Breaking Housekeeper-PerCommit-InfraTests_Linux. The bot will have to be updated as part of this change.

Original change's description:
> [infra] Use Python3 for our Presubmits
>
> https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:presubmit_support.py;l=319;drc=443d9135cc33f3156d5fe25ebec33f9adffbab65
>
> This also makes any errors from `make train -C infra/bots`
> look well formatted because check_output returns a bytestring
> in Python3 and when that is printed, the newlines et al are not
> rendered correctly. Thus we want the output of check_output
> to be encoded to UTF-8.
>
> Without setting the USE_PYTHON3 = True in PRESUBMIT.py,
> it appears that `git cl upload` would try to run our
> infra_tests.py in Python2 mode, which does not have
> the encoding argument for check_output.
>
> Apparently cipd_bin_packages/vpython3 does not have the
> "six" package installed (but cipd_bin_packages/vpython does)
> so I replaced the six.StringIO with io.StringIO, which
> is where that is located in Python3.
>
> Change-Id: Ic8f61bf943531583ba3d110a85260d69bdbf5eb2
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537677
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>

Change-Id: I0becb25d155ce0b0281c25d83662f1b01aee8033
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/537777
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ravi Mistry <rmistry@google.com>
2022-05-05 20:54:07 +00:00
..
analysis A set of scripts that analyzes jobs.json to look for possible holes in our 2021-06-02 16:11:43 +00:00
assets Update linux_vulkan_sdk asset. 2022-05-03 21:07:55 +00:00
buildstats [infra] Cleanup better after BuildStats 2021-08-05 13:22:22 +00:00
gen_tasks_logic Make the old-skp job's output match the size of the DDL jobs' output 2022-05-05 18:35:38 +00:00
recipe_modules Remove recipes code for RecreateSKPs bot, as well as chromium DEPS entry 2022-05-04 18:16:26 +00:00
recipes Remove recipes code for RecreateSKPs bot, as well as chromium DEPS entry 2022-05-04 18:16:26 +00:00
task_drivers [bazel] Put licenses() after legacy_exports 2022-05-02 15:04:33 +00:00
tools/luci-go Fix some master -> main references in docs 2021-09-27 14:52:24 +00:00
build_task_drivers.sh [bazel] Use RBE when building task drivers 2022-03-29 18:01:33 +00:00
BUILD.bazel [bazel] Put licenses() after legacy_exports 2022-05-02 15:04:33 +00:00
bundle_recipes.sh [python3] Reland recipes -> python3 changes 2021-12-01 13:04:03 +00:00
cfg.json [graphite] Upload graphite results from bots. 2022-03-29 13:06:57 +00:00
check_deps.py [recipes] Port to Python 3 2021-11-10 20:17:28 +00:00
gen_tasks.go Reland "[infra] Make most builds idempotent" 2019-07-19 12:11:27 +00:00
git_utils.py [python3] Reland recipes -> python3 changes 2021-12-01 13:04:03 +00:00
infra_tests.py Revert "[infra] Use Python3 for our Presubmits" 2022-05-05 20:54:07 +00:00
jobs.json Remove CommandBuffer bots and supporting code from infra scripts 2022-05-04 16:11:31 +00:00
Makefile
README.md Update references to master branch 2021-05-21 15:18:16 +00:00
README.recipes.md Remove recipes code for RecreateSKPs bot, as well as chromium DEPS entry 2022-05-04 18:16:26 +00:00
recipes.py [recipes] Port to Python 3 2021-11-10 20:17:28 +00:00
run_recipe.py Fix Python3 compatibility 2021-03-25 14:15:35 +00:00
tasks.json Use the correct SKP asset number in OldestSupportedSkpVersion bot 2022-05-04 16:44:41 +00:00
test_utils.py [recipes] Port to Python 3 2021-11-10 20:17:28 +00:00
utils.py [python3] Reland recipes -> python3 changes 2021-12-01 13:04:03 +00:00
zip_utils_test.py Fix Python3 compatibility 2021-03-25 14:15:35 +00:00
zip_utils.py Fix Python3 compatibility 2021-03-25 14:15:35 +00:00

README.md

Skia Infrastructure

This directory contains infrastructure elements.

Tasks and Jobs

Files in this directory define a DAG of tasks which run at every Skia commit. A task is a small, self-contained unit which runs via Swarming on a machine in the pool. Tasks may be chained together, eg. one task to compile test binaries and another to actually run them.

Jobs are collections of related tasks which help define sub-sections of the DAG, for example, to be used as try jobs. Each job is defined as an entry point into the DAG.

The tasks.json file in this directory is the list of tasks and jobs for the repo. Note that tasks.json is NEVER edited by hand but generated via gen_task.go and the input files enumerated below. The Task Scheduler reads the tasks.json file at each commit to determine which jobs to run. For convenience, gen_tasks.go is provided to generate tasks.json and also to test it for correct syntax and detecting cycles and orphaned tasks. Always edit gen_tasks.go or one of the following input JSON files, rather than tasks.json itself:

  • cfg.json - Basic configuration information for gen_tasks.go.
  • jobs.json - The list of all jobs to run. Edit this to add or remove bots.

Whenever gen_tasks.go, any of the above JSON files, or assets are changed, you need to run gen_tasks.go to regenerate tasks.json:

$ go run infra/bots/gen_tasks.go

Or:

$ cd infra/bots; make train

There is also a test mode which performs consistency checks and verifies that tasks.json is unchanged:

$ go run infra/bots/gen_tasks.go --test

Or:

$ cd infra/bots; make test

Recipes

Recipes are the framework used by Skia's infrastructure to perform work inside of Swarming tasks. The main elements are:

  • recipes.py - Used for running and testing recipes.
  • recipes - These are the entry points for each type of task, eg. compiling or running tests.
  • recipe_modules - Shared modules which are used by recipes.
  • .recipe_deps - Recipes and modules may depend on modules from other repos. The recipes.py script automatically syncs those dependencies in this directory.

Isolate Files

These files determine which parts of the repository are transferred to the bot when a Swarming task is triggered. The Isolate tool hashes each file and will upload any new/changed files. Bots maintain a cache so that they can efficiently download only the files they don't have.

Assets

Artifacts used by the infrastructure are versioned here, along with scripts for recreating/uploading/downloading them. See the README in that directory for more information. Any time an asset used by the bots changes, you need to re-run gen_tasks.go.

Tools

Assorted other infrastructure-related tools, eg. isolate and CIPD binaries.

CT

Helpers for running Skia tasks in Cluster Telemetry.