196e9fbbf0
I'm not sure I see a compelling reason for BBH factory objects to exist, as opposed to say, factory functions. I don't see any major harm in letting people hold onto BBH objects themselves. This allows the caller to create and hang onto the BBH themselves, allowing use cases like the slight extension I've made to the unit test PictureNegativeSpace as a demo. Not super useful yet, as SkBBoxHierarchy is not a public type... And add test that mini pictures fill the bbh, which had never been an interesting question until now we let the user hold onto the BBH. Bug: skia:9796 Change-Id: I14737f25b31a457a8716669183af0c3bbf01859b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/265445 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
128 lines
4.0 KiB
C++
128 lines
4.0 KiB
C++
/*
|
|
* Copyright 2014 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "include/core/SkBitmap.h"
|
|
#include "include/core/SkCanvas.h"
|
|
#include "include/core/SkPaint.h"
|
|
#include "include/core/SkPicture.h"
|
|
#include "include/core/SkPictureRecorder.h"
|
|
#include "src/core/SkBBoxHierarchy.h"
|
|
#include "src/core/SkRectPriv.h"
|
|
|
|
#include "tests/Test.h"
|
|
|
|
class PictureBBHTestBase {
|
|
public:
|
|
PictureBBHTestBase(int playbackWidth, int playbackHeight,
|
|
int recordWidth, int recordHeight) {
|
|
|
|
fResultBitmap.allocN32Pixels(playbackWidth, playbackHeight);
|
|
fPictureWidth = recordWidth;
|
|
fPictureHeight = recordHeight;
|
|
}
|
|
|
|
virtual ~PictureBBHTestBase() { }
|
|
|
|
virtual void doTest(SkCanvas& playbackCanvas, SkCanvas& recordingCanvas) = 0;
|
|
|
|
void run(skiatest::Reporter* reporter) {
|
|
// No BBH
|
|
this->run(nullptr, reporter);
|
|
|
|
// With an R-Tree
|
|
SkRTreeFactory RTreeFactory;
|
|
this->run(&RTreeFactory, reporter);
|
|
}
|
|
|
|
private:
|
|
void run(SkBBHFactory* factory, skiatest::Reporter* reporter) {
|
|
SkCanvas playbackCanvas(fResultBitmap);
|
|
playbackCanvas.clear(SK_ColorGREEN);
|
|
SkPictureRecorder recorder;
|
|
SkCanvas* recordCanvas = recorder.beginRecording(SkIntToScalar(fPictureWidth),
|
|
SkIntToScalar(fPictureHeight),
|
|
factory);
|
|
this->doTest(playbackCanvas, *recordCanvas);
|
|
sk_sp<SkPicture> picture(recorder.finishRecordingAsPicture());
|
|
playbackCanvas.drawPicture(picture);
|
|
REPORTER_ASSERT(reporter, SK_ColorGREEN == fResultBitmap.getColor(0, 0));
|
|
}
|
|
|
|
SkBitmap fResultBitmap;
|
|
int fPictureWidth, fPictureHeight;
|
|
};
|
|
|
|
// Test to verify the playback of an empty picture
|
|
//
|
|
class DrawEmptyPictureBBHTest : public PictureBBHTestBase {
|
|
public:
|
|
DrawEmptyPictureBBHTest()
|
|
: PictureBBHTestBase(2, 2, 1, 1) {}
|
|
~DrawEmptyPictureBBHTest() override {}
|
|
|
|
void doTest(SkCanvas&, SkCanvas&) override {}
|
|
};
|
|
|
|
// Test to verify the playback of a picture into a canvas that has
|
|
// an empty clip.
|
|
//
|
|
class EmptyClipPictureBBHTest : public PictureBBHTestBase {
|
|
public:
|
|
EmptyClipPictureBBHTest()
|
|
: PictureBBHTestBase(2, 2, 3, 3) {}
|
|
|
|
void doTest(SkCanvas& playbackCanvas, SkCanvas& recordingCanvas) override {
|
|
// intersect with out of bounds rect -> empty clip.
|
|
playbackCanvas.clipRect(SkRect::MakeXYWH(10, 10, 1, 1));
|
|
SkPaint paint;
|
|
recordingCanvas.drawRect(SkRect::MakeWH(3, 3), paint);
|
|
}
|
|
|
|
~EmptyClipPictureBBHTest() override {}
|
|
};
|
|
|
|
DEF_TEST(PictureBBH, reporter) {
|
|
|
|
DrawEmptyPictureBBHTest emptyPictureTest;
|
|
emptyPictureTest.run(reporter);
|
|
|
|
EmptyClipPictureBBHTest emptyClipPictureTest;
|
|
emptyClipPictureTest.run(reporter);
|
|
}
|
|
|
|
DEF_TEST(PictureNegativeSpace, r) {
|
|
SkRTreeFactory factory;
|
|
SkPictureRecorder recorder;
|
|
|
|
SkRect cull = {-200,-200,+200,+200};
|
|
|
|
{
|
|
sk_sp<SkBBoxHierarchy> bbh = factory();
|
|
auto canvas = recorder.beginRecording(cull, bbh);
|
|
canvas->save();
|
|
canvas->clipRect(cull);
|
|
canvas->drawRect({-20,-20,-10,-10}, SkPaint{});
|
|
canvas->drawRect({-20,-20,-10,-10}, SkPaint{});
|
|
canvas->restore();
|
|
auto pic = recorder.finishRecordingAsPicture();
|
|
REPORTER_ASSERT(r, pic->approximateOpCount() == 5);
|
|
REPORTER_ASSERT(r, pic->cullRect() == (SkRect{-20,-20,-10,-10}));
|
|
|
|
REPORTER_ASSERT(r, bbh->getRootBound() == (SkRect{-20,-20,-10,-10}));
|
|
}
|
|
|
|
{
|
|
auto canvas = recorder.beginRecording(cull, &factory);
|
|
canvas->clipRect(cull);
|
|
canvas->drawRect({-20,-20,-10,-10}, SkPaint{});
|
|
canvas->drawRect({-20,-20,-10,-10}, SkPaint{});
|
|
auto pic = recorder.finishRecordingAsPicture();
|
|
REPORTER_ASSERT(r, pic->approximateOpCount() == 3);
|
|
REPORTER_ASSERT(r, pic->cullRect() == (SkRect{-20,-20,-10,-10}));
|
|
}
|
|
}
|