skia2/modules/skottie
Florin Malita 6a2a637746 [skottie] Fix Keyframe::Value equality operator
Per spec, reading anything other than the most recently written
union member is undefined behavior.

Keyframe containers always access the same member, consistently.  But
the type-agnostic equality operator does touch both members.

Refactor to avoid undefined behavior.

Also add a couple of unit tests to capture keyframe deduping behavior
(which in turn relies on the equality operator).

Change-Id: I7ba9c335ef28af7ddc71bd6f03d56b891fbdea1e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451016
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
2021-09-21 19:23:26 +00:00
..
fuzz [fuzz] Standardize, document, and backport fuzzing defines. 2020-09-14 13:36:10 +00:00
gm [skottie] Add text colorization GM 2020-12-10 17:10:48 +00:00
include Reland "[skottie] AllCaps support" 2021-09-03 14:43:59 +00:00
src [skottie] Fix Keyframe::Value equality operator 2021-09-21 19:23:26 +00:00
tests [skottie] Fix Keyframe::Value equality operator 2021-09-21 19:23:26 +00:00
utils Expanded PropertyObserver interface to include Node Type 2021-06-11 17:00:47 +00:00
BUILD.gn Reland "[skottie] AllCaps support" 2021-09-03 14:43:59 +00:00
skottie.gni [skottie] Initial fractal noise effect 2021-03-01 19:50:10 +00:00