skia2/gm/ycbcrimage.cpp
Peng Huang a42ed48e84 Fix a double free problem in YCbCrImageGM::createYCbCrImage()
If SkImage::MakeFromTexture() fails, the reelase_ycbcrhelper will
also be called, so ycbcrHelper.release() should be always called.

Change-Id: I104e02155da653bcb465723cbead595f16459fca
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/379848
Commit-Queue: Peng Huang <penghuang@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-03-05 15:36:25 +00:00

118 lines
3.3 KiB
C++

/*
* Copyright 2020 Google LLC
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "gm/gm.h"
// This test only works with the Vulkan backend.
#ifdef SK_VULKAN
#include "include/core/SkCanvas.h"
#include "include/core/SkImage.h"
#include "include/core/SkPaint.h"
#include "include/core/SkSize.h"
#include "include/core/SkString.h"
#include "include/gpu/GrDirectContext.h"
#include "tools/gpu/vk/VkYcbcrSamplerHelper.h"
static void release_ycbcrhelper(void* releaseContext) {
VkYcbcrSamplerHelper* ycbcrHelper = reinterpret_cast<VkYcbcrSamplerHelper*>(releaseContext);
delete ycbcrHelper;
}
namespace skiagm {
// This GM exercises the native YCbCr image format on Vulkan
class YCbCrImageGM : public GpuGM {
public:
YCbCrImageGM() {
this->setBGColor(0xFFCCCCCC);
}
protected:
SkString onShortName() override {
return SkString("ycbcrimage");
}
SkISize onISize() override {
return SkISize::Make(2*kPad+kImageSize, 2*kPad+kImageSize);
}
DrawResult createYCbCrImage(GrDirectContext* dContext, SkString* errorMsg) {
std::unique_ptr<VkYcbcrSamplerHelper> ycbcrHelper(new VkYcbcrSamplerHelper(dContext));
if (!ycbcrHelper->isYCbCrSupported()) {
*errorMsg = "YCbCr sampling not supported.";
return skiagm::DrawResult::kSkip;
}
if (!ycbcrHelper->createBackendTexture(kImageSize, kImageSize)) {
*errorMsg = "Failed to create I420 backend texture.";
return skiagm::DrawResult::kFail;
}
SkASSERT(!fYCbCrImage);
fYCbCrImage = SkImage::MakeFromTexture(dContext, ycbcrHelper->backendTexture(),
kTopLeft_GrSurfaceOrigin, kRGB_888x_SkColorType,
kPremul_SkAlphaType, nullptr,
release_ycbcrhelper, ycbcrHelper.get());
ycbcrHelper.release();
if (!fYCbCrImage) {
*errorMsg = "Failed to create I420 image.";
return DrawResult::kFail;
}
return DrawResult::kOk;
}
DrawResult onGpuSetup(GrDirectContext* context, SkString* errorMsg) override {
if (!context || context->abandoned()) {
return DrawResult::kSkip;
}
if (context->backend() != GrBackendApi::kVulkan) {
*errorMsg = "This GM requires a Vulkan context.";
return DrawResult::kSkip;
}
DrawResult result = this->createYCbCrImage(context, errorMsg);
if (result != DrawResult::kOk) {
return result;
}
return DrawResult::kOk;
}
void onGpuTeardown() override {
fYCbCrImage = nullptr;
}
DrawResult onDraw(GrRecordingContext*, GrSurfaceDrawContext*,
SkCanvas* canvas, SkString*) override {
SkASSERT(fYCbCrImage);
canvas->drawImage(fYCbCrImage, kPad, kPad, SkSamplingOptions(SkFilterMode::kLinear));
return DrawResult::kOk;
}
private:
static const int kImageSize = 112;
static const int kPad = 8;
sk_sp<SkImage> fYCbCrImage;
using INHERITED = GpuGM;
};
//////////////////////////////////////////////////////////////////////////////
DEF_GM(return new YCbCrImageGM;)
} // namespace skiagm
#endif // SK_VULKAN