390f0cc1f8
This reverts commit138a06d1b1
. Reason for revert: add explicit constructors to ImageSetEntry to account for the new arguments, matching SkiaRenderer's current initializer list. Also hardens SkPictureDrawback's deserialization code for drawEdgeAAImageSet and drawEdgeAAQuad from a fuzz that was found during the CL's brief lifespan. Original change's description: > Revert "Reland "Update SkCanvas' experimental SkiaRenderer API"" > > This reverts commitbd9d88a6e4
. > > Reason for revert: Breaks SkiaRenderer on Android. Rendering is all corrupted, bisected to this change. > > Original change's description: > > Reland "Update SkCanvas' experimental SkiaRenderer API" > > > > This reverts commit90791c202d
. > > > > Reason for revert: Jumped the gun, just need to update blacklist > > > > Original change's description: > > > Revert "Update SkCanvas' experimental SkiaRenderer API" > > > > > > This reverts commit4bf964602a
. > > > > > > Reason for revert: vulkan dm crashes > > > > > > Original change's description: > > > > Update SkCanvas' experimental SkiaRenderer API > > > > > > > > This lifts the temporary functions in SkGpuDevice into SkCanvas and > > > > deprecates the older experimental_DrawImageSetV1 and > > > > experimental_DrawEdgeAARect. The new functions can handle paints and > > > > transform batching. Internally, SkCanvas routes the old functions to the > > > > new entry points and all device-level code is updated to handle the new > > > > API features. > > > > > > > > While touching all of the canvas/device/recording areas, the > > > > experimental functions are grouped in an "EdgeAA" cluster instead of being > > > > separated into the image category and the rectangle category. > > > > > > > > Bug: skia:8739 > > > > Change-Id: I67c2a724873040ad5dc3307ab5b2823ba1eac54b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/190221 > > > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > > > > > TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com > > > > > > Change-Id: I87a5a258c5a1bd15e16389cdf91743772d6fa98a > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: skia:8739 > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201226 > > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > > > TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com > > > > Change-Id: I75e9b6cbf079a7739b69a7e208730a930621abf9 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia:8739 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201229 > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > Auto-Submit: Michael Ludwig <michaelludwig@google.com> > > TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com > > Change-Id: Ib87ef9b8b8598c16a8a6915920adf0b5dffc644b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:8739 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201391 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Bug: skia:8739, oss-fuzz:13794 Change-Id: Ibd7df4a398928c3170d16300bf3ade496125372c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201650 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
89 lines
4.0 KiB
C++
89 lines
4.0 KiB
C++
/*
|
|
* Copyright 2016 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef SkNoDrawCanvas_DEFINED
|
|
#define SkNoDrawCanvas_DEFINED
|
|
|
|
#include "SkCanvas.h"
|
|
#include "SkCanvasVirtualEnforcer.h"
|
|
#include "SkVertices.h"
|
|
|
|
struct SkIRect;
|
|
|
|
// SkNoDrawCanvas is a helper for SkCanvas subclasses which do not need to
|
|
// actually rasterize (e.g., analysis of the draw calls).
|
|
//
|
|
// It provides the following simplifications:
|
|
//
|
|
// * not backed by any device/pixels
|
|
// * conservative clipping (clipping calls only use rectangles)
|
|
//
|
|
class SK_API SkNoDrawCanvas : public SkCanvasVirtualEnforcer<SkCanvas> {
|
|
public:
|
|
SkNoDrawCanvas(int width, int height);
|
|
|
|
// TODO: investigate the users of this ctor.
|
|
SkNoDrawCanvas(const SkIRect&);
|
|
|
|
explicit SkNoDrawCanvas(sk_sp<SkBaseDevice> device);
|
|
|
|
// Optimization to reset state to be the same as after construction.
|
|
void resetCanvas(int width, int height) {
|
|
resetForNextPicture(SkIRect::MakeWH(width, height));
|
|
}
|
|
|
|
protected:
|
|
SaveLayerStrategy getSaveLayerStrategy(const SaveLayerRec& rec) override;
|
|
bool onDoSaveBehind(const SkRect*) override;
|
|
|
|
// No-op overrides for aborting rasterization earlier than SkNullBlitter.
|
|
void onDrawAnnotation(const SkRect&, const char[], SkData*) override {}
|
|
void onDrawDRRect(const SkRRect&, const SkRRect&, const SkPaint&) override {}
|
|
void onDrawDrawable(SkDrawable*, const SkMatrix*) override {}
|
|
void onDrawTextBlob(const SkTextBlob*, SkScalar, SkScalar, const SkPaint&) override {}
|
|
void onDrawPatch(const SkPoint[12], const SkColor[4], const SkPoint[4], SkBlendMode,
|
|
const SkPaint&) override {}
|
|
|
|
void onDrawPaint(const SkPaint&) override {}
|
|
void onDrawPoints(PointMode, size_t, const SkPoint[], const SkPaint&) override {}
|
|
void onDrawRect(const SkRect&, const SkPaint&) override {}
|
|
void onDrawRegion(const SkRegion&, const SkPaint&) override {}
|
|
void onDrawOval(const SkRect&, const SkPaint&) override {}
|
|
void onDrawArc(const SkRect&, SkScalar, SkScalar, bool, const SkPaint&) override {}
|
|
void onDrawRRect(const SkRRect&, const SkPaint&) override {}
|
|
void onDrawPath(const SkPath&, const SkPaint&) override {}
|
|
void onDrawBitmap(const SkBitmap&, SkScalar, SkScalar, const SkPaint*) override {}
|
|
void onDrawBitmapRect(const SkBitmap&, const SkRect*, const SkRect&, const SkPaint*,
|
|
SrcRectConstraint) override {}
|
|
void onDrawImage(const SkImage*, SkScalar, SkScalar, const SkPaint*) override {}
|
|
void onDrawImageRect(const SkImage*, const SkRect*, const SkRect&, const SkPaint*,
|
|
SrcRectConstraint) override {}
|
|
void onDrawImageNine(const SkImage*, const SkIRect&, const SkRect&, const SkPaint*) override {}
|
|
void onDrawBitmapNine(const SkBitmap&, const SkIRect&, const SkRect&,
|
|
const SkPaint*) override {}
|
|
void onDrawImageLattice(const SkImage*, const Lattice&, const SkRect&,
|
|
const SkPaint*) override {}
|
|
void onDrawBitmapLattice(const SkBitmap&, const Lattice&, const SkRect&,
|
|
const SkPaint*) override {}
|
|
void onDrawVerticesObject(const SkVertices*, const SkVertices::Bone[], int, SkBlendMode,
|
|
const SkPaint&) override {}
|
|
void onDrawAtlas(const SkImage*, const SkRSXform[], const SkRect[], const SkColor[],
|
|
int, SkBlendMode, const SkRect*, const SkPaint*) override {}
|
|
void onDrawShadowRec(const SkPath&, const SkDrawShadowRec&) override {}
|
|
void onDrawPicture(const SkPicture*, const SkMatrix*, const SkPaint*) override {}
|
|
|
|
void onDrawEdgeAAQuad(const SkRect&, const SkPoint[4], QuadAAFlags, SkColor,
|
|
SkBlendMode) override {}
|
|
void onDrawEdgeAAImageSet(const ImageSetEntry[], int, const SkPoint[],
|
|
const SkMatrix[], const SkPaint*, SrcRectConstraint) override {}
|
|
|
|
private:
|
|
typedef SkCanvasVirtualEnforcer<SkCanvas> INHERITED;
|
|
};
|
|
|
|
#endif // SkNoDrawCanvas_DEFINED
|