AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
1c35e571c3
skia2/infra/bots/recipes
History
Ben Wagner 1c35e571c3 Revert "Revert "Fix a couple float-cast-overflow in SkScan*."" 
This reverts commit b6abb9b4e0.

Reason for revert: It doesn't make sense that this CL would affect the tests implicated in the perf regression in skia:7143, and the revert had no effect on the perf of those tests. Seems like the perf alert was either noise or due to a different CL.

Original change's description:
> Revert "Fix a couple float-cast-overflow in SkScan*."
> 
> This reverts commit 3cd0bef0fd.
> 
> Reason for revert: https://bugs.chromium.org/p/skia/issues/detail?id=7143
> 
> Original change's description:
> > Fix a couple float-cast-overflow in SkScan*.
> > 
> > Bug: skia:5060
> > Change-Id: I60a48993c77631aaad9354bb86b13204dc618bf4
> > Reviewed-on: https://skia-review.googlesource.com/47422
> > Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> > Reviewed-by: Mike Reed <reed@google.com>
> 
> TBR=benjaminwagner@google.com,reed@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: skia:7143
> Change-Id: I0f19720a7d8344789a375bbb6b9e28bf4f4e55ae
> Reviewed-on: https://skia-review.googlesource.com/57240
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>

TBR=benjaminwagner@google.com,reed@google.com

Change-Id: I29ac47d6665e2e52ee2a6500488dc407c8d2af1c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7143
Reviewed-on: https://skia-review.googlesource.com/57440
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-09 22:59:06 +00:00
..
bundle_recipes.expected Use chrome-infra Git CIPD package 2017-06-06 12:45:11 +00:00
check_generated_files.expected [infra] Bring recipe DEPS up to date 2017-09-22 20:05:38 +00:00
compile.expected Add Linux CPU Coverage Bot 2017-10-09 19:58:34 +00:00
ct_skps.expected Manually roll recipe DEPS 2017-09-27 17:24:38 +00:00
housekeeper.expected [infra] Bring recipe DEPS up to date 2017-09-22 20:05:38 +00:00
infra.expected [infra] Bring recipe DEPS up to date 2017-09-22 20:05:38 +00:00
perf.expected Cleanup jobs. 2017-10-09 19:15:05 +00:00
recreate_skps.expected Make ct_skps and recreate_skps recipes shell to gsutil 2017-09-25 13:53:53 +00:00
skpbench.expected Remove dependency on recipe_engine/shutil. 2017-07-10 13:46:35 +00:00
test.expected Revert "Revert "Fix a couple float-cast-overflow in SkScan*."" 2017-10-09 22:59:06 +00:00
update_meta_config.expected [infra] Bring recipe DEPS up to date 2017-09-22 20:05:38 +00:00
upload_coverage_results.expected Add Linux CPU Coverage Bot 2017-10-09 19:58:34 +00:00
upload_dm_results.expected [recipes] Update example builder names. 2017-09-26 20:26:56 +00:00
upload_nano_results.expected [recipes] Update example builder names. 2017-09-26 20:26:56 +00:00
bundle_recipes.py Use chrome-infra Git CIPD package 2017-06-06 12:45:11 +00:00
check_generated_files.py Add a bot to verify that generated SKSL files have not been hand-edited 2017-07-28 12:20:47 +00:00
compile.py Add Linux CPU Coverage Bot 2017-10-09 19:58:34 +00:00
ct_skps.py Specify CPU for CT Swarming tasks. 2017-09-25 19:48:49 +00:00
housekeeper.py [skia] convert recipes and module to new context module 2017-05-15 13:46:22 +00:00
infra.py Fixes for internal repo infra tests 2017-06-15 13:10:59 +00:00
perf.py Cleanup jobs. 2017-10-09 19:15:05 +00:00
README.md Use new recipes.py test command 2017-04-18 13:57:56 +00:00
recreate_skps.py Make ct_skps and recreate_skps recipes shell to gsutil 2017-09-25 13:53:53 +00:00
skpbench.py Remove dependency on recipe_engine/shutil. 2017-07-10 13:46:35 +00:00
test.py Revert "Revert "Fix a couple float-cast-overflow in SkScan*."" 2017-10-09 22:59:06 +00:00
update_meta_config.py [recipes] Switch to file module from recipe_engine 2017-06-16 17:41:28 +00:00
upload_coverage_results.py Add Linux CPU Coverage Bot 2017-10-09 19:58:34 +00:00
upload_dm_results.py Add Linux CPU Coverage Bot 2017-10-09 19:58:34 +00:00
upload_nano_results.py [recipes] Update example builder names. 2017-09-26 20:26:56 +00:00

README.md

Skia Recipes

These are the top-level scripts which run inside of Swarming tasks to perform all of Skia's automated testing.

To run a recipe locally:

$ python infra/bots/recipes.py run --workdir=/tmp/<workdir> <recipe name without .py> key1=value1 key2=value2 ...

Each recipe may have its own required properties which must be entered as key/value pairs in the command.

When you change a recipe, you generally need to re-train the simulation test:

$ python infra/bots/recipes.py test run --train

Or:

    $ cd infra/bots; make train

The test generates expectations files for the tests contained within each recipe which illustrate which steps would run, given a particular set of inputs. Pay attention to the diffs in these files when making changes to ensure that your change has the intended effect.