1d75778cbf
This is a followup to http://review.skia.org/335196. This detects opaque types (samplers and textures) at parsing or IR generation time and reports an error regardless of backend. This check occurs before Metal or SPIR-V would have a chance to detect the error, so it changes their output to a slightly more focused error message. The Metal/SPIR-V fix in the prior CL is still a nice broad catch-all for preventing spurious ABORTs, though. Change-Id: I4cce92a8767d72b5d3d7277a8afde8ce5ce86db2 Bug: skia:10956 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335217 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> |
||
---|---|---|
.. | ||
golden | ||
CastHalf4ToMat2x2.sksl | ||
CastMat2x2ToMat3x3.sksl | ||
CastMat2x3ToMat4x4.sksl | ||
CastMat4x4ToMat3x4.sksl | ||
CastMat4x4ToMat4x3.sksl | ||
NumericGlobals.sksl | ||
OpaqueTypeInInterfaceBlock.sksl | ||
OpaqueTypeInStruct.sksl | ||
SamplerGlobals.sksl |