33fb008669
Because SkSL is much more permissive than GLSL about literal types, we don't actually need to treat values any differently when the `u` suffix is added. That is, `uint x = 4000000000;` already worked fine. When we encounter the `u`, we just ignore it. This also means that a literal like `-100u` would be accepted without complaint (although you'd get a range error if you tried `uint x = -100u;`). The value-add here is that it removes a speed bump when porting GLSL code to SkSL. The Filament example shader used the `u` suffix anywhere that bitwise ops were present; finding and removing all of them was a chore. Also of note: the `u` suffix was only added to GLSL in ES3, but we "support" it everywhere. (We could go out of our way to detect it in ES2 and flag an error, but that benefits no one.) Change-Id: I4bf643612c8cf17710e9bad50a0c16f5936bbe88 Bug: skia:12634 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/471756 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> |
||
|---|---|---|
| .. | ||
| blend | ||
| errors | ||
| es2_conformance | ||
| folding | ||
| glsl | ||
| inliner | ||
| intrinsics | ||
| metal | ||
| runtime | ||
| runtime_errors | ||
| shared | ||
| spirv | ||
| workarounds | ||
| README.txt | ||
| update_fuzzer.py | ||
This directory contains source files for testing skslc compilation. The compiled output files are in the /tests/sksl/ directory.