c8037dc5ed
This partially reverts commit
1793e7bb46.
Hide SkEncodedInfo
Bug: skia:7353
Bug: skia:6839
This contains information that is not necessary for clients to know. The
Color enum tells the number of components in the input, but this is only
interesting internally (to the SkSwizzler).
Similarly, the Alpha enum differs from SkAlphaType in that it has
kBinary instead of kPremul. This is useful information only internally
for determining whether the SkColorSpaceXform needs to premultiply.
The bitsPerComponent is potentially useful for a client; Android (in
SkAndroidCodec) uses it to determine the SkColorType. Rather than
exposing bitsPerComponent, make SkAndroidCodec a friend so it can
access the SkEncodedInfo. A future change will change SkCodec to
recommend F16 for bitsPerComponent > 8, but that will be more involved;
it was the reason for the revert of this CL.
Switch conversionSupported to use an SkColorType, which is enough info.
Replace the SkEncodedInfo::Alpha field on SkCodec::FrameInfo with an
SkAlphaType.
SkCodec still needs an SkEncodedInfo, so move its header (which is
already not SK_API) to include/private.
TBR=mtklein@chromium.org,reed@google.com
Change-Id: I928b1f55317602cb37d29da63b53026c8d139cee
Reviewed-on: https://skia-review.googlesource.com/80860
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
41 lines
1.2 KiB
C++
41 lines
1.2 KiB
C++
/*
|
|
* Copyright 2017 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "SkAndroidCodec.h"
|
|
#include "SkBitmap.h"
|
|
#include "SkCodec.h"
|
|
#include "SkColorSpace.h"
|
|
#include "SkEncodedImageFormat.h"
|
|
#include "SkImageEncoder.h"
|
|
#include "SkImageInfo.h"
|
|
#include "SkStream.h"
|
|
|
|
#include "Test.h"
|
|
|
|
DEF_TEST(Codec_recommendedF16, r) {
|
|
// Encode an F16 bitmap. SkEncodeImage will encode this to a true-color PNG
|
|
// with a bit depth of 16. SkAndroidCodec should always recommend F16 for
|
|
// such a PNG.
|
|
SkBitmap bm;
|
|
bm.allocPixels(SkImageInfo::Make(10, 10, kRGBA_F16_SkColorType,
|
|
kPremul_SkAlphaType, SkColorSpace::MakeSRGBLinear()));
|
|
// What is drawn is not important.
|
|
bm.eraseColor(SK_ColorBLUE);
|
|
|
|
SkDynamicMemoryWStream wstream;
|
|
REPORTER_ASSERT(r, SkEncodeImage(&wstream, bm, SkEncodedImageFormat::kPNG, 100));
|
|
auto data = wstream.detachAsData();
|
|
auto androidCodec = SkAndroidCodec::MakeFromData(std::move(data));
|
|
if (!androidCodec) {
|
|
ERRORF(r, "Failed to create SkAndroidCodec");
|
|
return;
|
|
}
|
|
|
|
REPORTER_ASSERT(r, androidCodec->computeOutputColorType(kN32_SkColorType)
|
|
== kRGBA_F16_SkColorType);
|
|
}
|