2460bbdfbb
Reason for revert: Leaks, leaks, leaks. Original issue's description: > SkThreadPool ~~> SkTaskGroup > > SkTaskGroup is like SkThreadPool except the threads stay in > one global pool. Each SkTaskGroup itself is tiny (4 bytes) > and its wait() method applies only to tasks add()ed to that > instance, not the whole thread pool. > > This means we don't need to bring up new thread pools when > tests themselves want to use multithreading (e.g. pathops, > quilt). We just create a new SkTaskGroup and wait for that > to complete. This should be more efficient, and allow us > to expand where we use threads to really latency sensitive > places. E.g. we can probably now use these in nanobench > for CPU .skp rendering. > > Now that all threads are sharing the same pool, I think we > can remove most of the custom mechanism pathops tests use > to control threading. They'll just ride on the global pool > with all other tests now. > > This (temporarily?) removes the GPU multithreading feature > from DM, which we don't use. > > On my desktop, DM runs a little faster (57s -> 55s) in > Debug, and a lot faster in Release (36s -> 24s). The bots > show speedups of similar proportions, cutting more than a > minute off the N4/Release and Win7/Debug runtimes. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/9c7207b5dc71dc5a96a2eb107d401133333d5b6f R=caryclark@google.com, bsalomon@google.com, bungeman@google.com, reed@google.com, mtklein@chromium.org TBR=bsalomon@google.com, bungeman@google.com, caryclark@google.com, mtklein@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/533393002 |
||
|---|---|---|
| .. | ||
| DM.cpp | ||
| DMCpuGMTask.cpp | ||
| DMCpuGMTask.h | ||
| DMExpectations.h | ||
| DMExpectationsTask.cpp | ||
| DMExpectationsTask.h | ||
| DMGpuGMTask.cpp | ||
| DMGpuGMTask.h | ||
| DMGpuSupport.h | ||
| DMPDFRasterizeTask.cpp | ||
| DMPDFRasterizeTask.h | ||
| DMPDFTask.cpp | ||
| DMPDFTask.h | ||
| DMPipeTask.cpp | ||
| DMPipeTask.h | ||
| DMQuiltTask.cpp | ||
| DMQuiltTask.h | ||
| DMReporter.cpp | ||
| DMReporter.h | ||
| DMSerializeTask.cpp | ||
| DMSerializeTask.h | ||
| DMSKPTask.cpp | ||
| DMSKPTask.h | ||
| DMTask.cpp | ||
| DMTask.h | ||
| DMTaskRunner.cpp | ||
| DMTaskRunner.h | ||
| DMTestTask.cpp | ||
| DMTestTask.h | ||
| DMUtil.cpp | ||
| DMUtil.h | ||
| DMWriteTask.cpp | ||
| DMWriteTask.h | ||
| README | ||
DM is like GM, but multithreaded. It doesn't do everything GM does.
DM's design is based around Tasks and a TaskRunner.
A Task represents an independent unit of work that might fail. We make a task
for each GM/configuration pair we want to run. Tasks can kick off new tasks
themselves. For example, a CpuTask can kick off a ReplayTask to make sure
recording and playing back an SkPicture gives the same result as direct
rendering.
The TaskRunner runs all tasks on one of two threadpools, whose sizes are
configurable by --cpuThreads and --gpuThreads. Ideally we'd run these on a
single threadpool but it can swamp the GPU if we shove too much work into it at
once. --cpuThreads defaults to the number of cores on the machine.
--gpuThreads defaults to 1, but you may find 2 or 4 runs a little faster.
So the main flow of DM is:
for each GM:
for each configuration:
kick off a new task
< tasks run, maybe fail, and maybe kick off new tasks >
wait for all tasks to finish
report failures