a2d22b2e08
Previously, DSLVar represented local, global, and parameter variables. This splits it into three separate subclasses. In addition to just being a cleaner API in general, this also addresses an issue we ran into with the upcoming DSLParser: previously, a global DSLVar's storage was not set correctly until DeclareGlobal was called, so an AddToSymbolTable call prior to DeclareGlobal would create the SkSL variable with the wrong storage, causing spurious errors on global-only modifiers. But holding off on the AddToSymbolTable tends to break constructs like "int x = 0, y = x", so improving the API seemed like the best way to address it. Now that we have greater type safety around variables, we can potentially avoid having to call AddToSymbolTable for DSLVar and DSLGlobalVar altogether, since we know they are both supposed to end up in the symbol table, but that isn't something I want to change in this CL. Change-Id: I5f390a7384ce0af6a2131d84f97fc5e5b318063f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428576 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
35 lines
658 B
C++
35 lines
658 B
C++
/*
|
|
* Copyright 2020 Google LLC
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef SKSL_DSL
|
|
#define SKSL_DSL
|
|
|
|
#include "include/sksl/DSLCore.h"
|
|
|
|
namespace SkSL {
|
|
|
|
namespace dsl {
|
|
|
|
using Block = DSLBlock;
|
|
using Case = DSLCase;
|
|
using Expression = DSLExpression;
|
|
using Field = DSLField;
|
|
using Function = DSLFunction;
|
|
using GlobalVar = DSLGlobalVar;
|
|
using Layout = DSLLayout;
|
|
using Modifiers = DSLModifiers;
|
|
using Parameter = DSLParameter;
|
|
using Statement = DSLStatement;
|
|
using Var = DSLVar;
|
|
template<typename T> using Wrapper = DSLWrapper<T>;
|
|
|
|
} // namespace dsl
|
|
|
|
} // namespace SkSL
|
|
|
|
#endif
|