Go to file
Tyler Denniston 283dba5785 Revert "Add format-specifier warnings to SkDebugf."
This reverts commit e58831cd95.

Reason for revert: looks like breaking a few build bots

Original change's description:
> Add format-specifier warnings to SkDebugf.
>
> This CL fixes up many existing format-specifier violations in Skia.
> Note that GCC has a warning for formatting nothing, so existing calls to
> `SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
> These were apparently meant to be used as a place to set a breakpoint.
>
> Some of our clients also use SkDebug with bad format specifiers, so this
> check is currently only enabled when SKIA_IMPLEMENTATION is true.
>
> Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
> Bug: skia:12143
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: I07848c1bf8992925c9498e916744d0840355a077
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:12143
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421917
Reviewed-by: Tyler Denniston <tdenniston@google.com>
Commit-Queue: Tyler Denniston <tdenniston@google.com>
2021-06-25 13:33:10 +00:00
animations
bazel bazel baby steps 2020-09-14 15:18:32 +00:00
bench Revert "Don't keep "outResultsFile" open in nanobench" 2021-06-19 22:12:48 +00:00
bin [infra] Fix fetch-sk and fetch-skps 2021-06-18 15:20:38 +00:00
build/fuchsia [fuchsia] Fix fidlc command. 2020-06-10 03:29:24 +00:00
build_overrides Fix ANGLE roll 2021-05-10 15:34:52 +00:00
client_utils/android Replace 'typedef xxxxx INHERITED' with 'using INHERITED = xxxx;'. 2020-09-03 03:41:26 +00:00
demos.skia.org [canvaskit] Fix demo image link 2021-06-03 12:57:50 +00:00
dm Convert dmsaa to an SkSurfaceProp 2021-04-20 16:24:56 +00:00
docker [infra] Fix index.d.ts copy in Wasm Docker build 2021-02-23 15:54:11 +00:00
docs/examples Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
example Remove SDL from DEPS (and SDL example that used it) 2021-05-27 21:37:57 +00:00
experimental Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
fuzz Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
gm Rewrite tessellation atlases as normal render tasks 2021-06-24 01:44:19 +00:00
gn Replace some gradient .fps with runtime FPs 2021-06-25 13:08:49 +00:00
include Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
infra [canvaskit] Ensure clean build on CI 2021-06-24 18:54:52 +00:00
modules Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
platform_tools [androidkit] Add remaining gradients 2021-06-24 17:43:38 +00:00
resources Remove SkBlendMode from SkSL 2021-06-16 21:01:30 +00:00
samplecode Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
site Fix typo in link 2021-06-17 20:55:05 +00:00
specs
src Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
tests Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
third_party Build HarfBuzz without ICU support 2021-06-17 15:44:13 +00:00
tools Revert "Add format-specifier warnings to SkDebugf." 2021-06-25 13:33:10 +00:00
.bazelignore bazel baby steps 2020-09-14 15:18:32 +00:00
.clang-format no more bin packing in .clang-format 2021-03-04 17:22:50 +00:00
.clang-tidy Disable ClangTidy namespace comments for short blocks. 2020-08-24 14:01:22 +00:00
.gitignore [infra] Add bin/fetch-sk 2021-05-24 17:42:17 +00:00
.gn Pre-emptive fix for upcoming ANGLE change. 2021-01-08 17:23:52 +00:00
AUTHORS Add UWP support 2021-02-10 19:04:42 +00:00
BUILD.bazel bazel baby steps 2020-09-14 15:18:32 +00:00
BUILD.gn Migrate matrix-inversion code to a dedicated SkMatrixInvert file. 2021-06-22 17:11:15 +00:00
codereview.settings
CONTRIBUTING
CQ_COMMITTERS
DEPS Roll ANGLE from 4375d6c732ef to c24494415a1a (17 revisions) 2021-06-25 05:17:42 +00:00
DIR_METADATA Move metadata in OWNERS files to DIR_METADATA files 2021-02-02 23:41:54 +00:00
go.mod Reland "[infra] Roll Infra dep to update CIPD packages" with fix 2021-06-22 17:31:55 +00:00
go.sum Reland "[infra] Roll Infra dep to update CIPD packages" with fix 2021-06-22 17:31:55 +00:00
LICENSE
PRESUBMIT.py Remove mtklein from housekeeper message 2021-06-18 17:36:22 +00:00
public.bzl Reland "Purge ccpr" 2021-06-19 18:42:38 +00:00
README
README.chromium
RELEASE_NOTES.txt Enable reduceOpsTaskSplitting by default 2021-06-21 16:32:13 +00:00
whitespace.txt Test master branch deletion 2021-05-25 13:20:41 +00:00
WORKSPACE.bazel bazel baby steps 2020-09-14 15:18:32 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at https://skia.org.