84836b799a
Like any normal variable, flags can be made file-scoped static, and like any normal variable, mostly they should be if they can. This CL converts most flags to be static, if only so that the ones that do cross files stand out more clearly, and so that there's more examples of static flags through the codebase for people to ape. Change-Id: Ibb5ddd7aa09fce073d0996ac3ef0487b078b7d79 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202800 Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
89 lines
3.0 KiB
C++
89 lines
3.0 KiB
C++
/*
|
|
* Copyright 2017 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "EventTracingPriv.h"
|
|
|
|
#include "ChromeTracingTracer.h"
|
|
#include "CommandLineFlags.h"
|
|
#include "SkATrace.h"
|
|
#include "SkDebugfTracer.h"
|
|
#include "SkEventTracer.h"
|
|
#include "SkTraceEvent.h"
|
|
|
|
static DEFINE_string(trace,
|
|
"",
|
|
"Log trace events in one of several modes:\n"
|
|
" debugf : Show events using SkDebugf\n"
|
|
" atrace : Send events to Android ATrace\n"
|
|
" <filename> : Any other string is interpreted as a filename. Writes\n"
|
|
" trace events to specified file as JSON, for viewing\n"
|
|
" with chrome://tracing");
|
|
|
|
static DEFINE_string(traceMatch,
|
|
"",
|
|
"Filter which categories are traced.\n"
|
|
"Uses same format as --match\n");
|
|
|
|
void initializeEventTracingForTools(const char* traceFlag) {
|
|
if (!traceFlag) {
|
|
if (FLAGS_trace.isEmpty()) {
|
|
return;
|
|
}
|
|
traceFlag = FLAGS_trace[0];
|
|
}
|
|
|
|
SkEventTracer* eventTracer = nullptr;
|
|
if (0 == strcmp(traceFlag, "atrace")) {
|
|
eventTracer = new SkATrace();
|
|
} else if (0 == strcmp(traceFlag, "debugf")) {
|
|
eventTracer = new SkDebugfTracer();
|
|
} else {
|
|
eventTracer = new ChromeTracingTracer(traceFlag);
|
|
}
|
|
|
|
SkAssertResult(SkEventTracer::SetInstance(eventTracer));
|
|
}
|
|
|
|
uint8_t* SkEventTracingCategories::getCategoryGroupEnabled(const char* name) {
|
|
static_assert(0 == offsetof(CategoryState, fEnabled), "CategoryState");
|
|
|
|
// We ignore the "disabled-by-default-" prefix in our internal tools
|
|
if (SkStrStartsWith(name, TRACE_CATEGORY_PREFIX)) {
|
|
name += strlen(TRACE_CATEGORY_PREFIX);
|
|
}
|
|
|
|
// Chrome's implementation of this API does a two-phase lookup (once without a lock, then again
|
|
// with a lock. But the tracing macros avoid calling these functions more than once per site,
|
|
// so just do something simple (and easier to reason about):
|
|
SkAutoMutexAcquire lock(&fMutex);
|
|
for (int i = 0; i < fNumCategories; ++i) {
|
|
if (0 == strcmp(name, fCategories[i].fName)) {
|
|
return reinterpret_cast<uint8_t*>(&fCategories[i]);
|
|
}
|
|
}
|
|
|
|
if (fNumCategories >= kMaxCategories) {
|
|
SkDEBUGFAIL("Exhausted event tracing categories. Increase kMaxCategories.");
|
|
return reinterpret_cast<uint8_t*>(&fCategories[0]);
|
|
}
|
|
|
|
fCategories[fNumCategories].fEnabled =
|
|
CommandLineFlags::ShouldSkip(FLAGS_traceMatch, name)
|
|
? 0
|
|
: SkEventTracer::kEnabledForRecording_CategoryGroupEnabledFlags;
|
|
|
|
fCategories[fNumCategories].fName = name;
|
|
return reinterpret_cast<uint8_t*>(&fCategories[fNumCategories++]);
|
|
}
|
|
|
|
const char* SkEventTracingCategories::getCategoryGroupName(const uint8_t* categoryEnabledFlag) {
|
|
if (categoryEnabledFlag) {
|
|
return reinterpret_cast<const CategoryState*>(categoryEnabledFlag)->fName;
|
|
}
|
|
return nullptr;
|
|
}
|