4511c7b7fb
gazelle ended up being more liability than asset for our C++ rules. It required devs to manually run the command frequently (and was easy to forget until the CQ failed). The fact that we still had to edit the source files (e.g. the "srcs" cc_libraries) meant that the mixture between generated and hand-written caused some tension (see include/third_party/vulkan for a good example). The combination of gazelle and our IWYU enforcement added several bits of churn without any real benefit. The generated rules also didn't help identify cases where we were not keeping tight boundaries (e.g. non-gpu code and gpu code). Identifying third_party deps automatically ended up being trickier than anticipated (see the deleted //third_party/file_map_for_bazel.json) Using the "maximum set of dependencies" worked ok, but ended up increasing build time unnecessarily. For example, compiling CanvasKit for WebGL always needed to compile Dawn because SkSLCompiler.cpp sometimes needs to include tint/tint.h. Follow-up CLs will rebuild the BUILD.bazel rules without gazelle. Note to Reviewers: - The only file worth manually reviewing here is bazel/Makefile. Change-Id: I36d6fc3747487fabaf699690780c95f1f6765770 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/543976 Reviewed-by: Leandro Lovisolo <lovisolo@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> |
||
|---|---|---|
| .. | ||
| sk_canvas.h | ||
| sk_colorspace.h | ||
| sk_data.h | ||
| sk_image.h | ||
| sk_imageinfo.h | ||
| sk_maskfilter.h | ||
| sk_matrix.h | ||
| sk_paint.h | ||
| sk_path.h | ||
| sk_picture.h | ||
| sk_shader.h | ||
| sk_surface.h | ||
| sk_types.h | ||