AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2dd7f3bf23
skia2/experimental/svg/model
History
Mike Klein 2d9e543a58 some SkAtomics cleanup 
- Replace sk_memory_order with std::memory_order.
 - Remove SkAtomic<T>.

SkPath was the only user of SkAtomic<T>, for its fConvexity and
fFirstDirection fields.  I've replaced them with std::atomic types, and
funneled access to them through methods that enforce the relaxed memory
order like SkAtomic<T> did.

For fConvexity, we can use the exisiting setConvexity() and
getConvexityOrUnknown() methods, adding a private const setConvexity()
to mutate convexity from const methods.  For fFirstDirection I've added
private setFirstDirection() and getFirstDirection() methods.

Removing SkAtomic<T> means SkAtomics.h no longer needs SkNoncopyable.h.
I've had to update a bunch of other headers that were depending on
transitive inclusion.

Change-Id: Ib238be71a121519db6e970a9a8955834e1298c87
Reviewed-on: https://skia-review.googlesource.com/c/174220
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-04 13:53:39 +00:00
..
SkPEG.h Reland: Experimental parsing expression grammar (PEG) template library 2016-08-25 08:44:35 -07:00
SkSVGAttribute.cpp [SVGDom] Add 'stroke-dashoffset' support 2017-10-13 22:53:32 +00:00
SkSVGAttribute.h [SVGDom] Add 'stroke-dashoffset' support 2017-10-13 22:53:32 +00:00
SkSVGAttributeParser.cpp migrating SkTDArray towards std::vector api 2018-08-08 15:51:44 +00:00
SkSVGAttributeParser.h some SkAtomics cleanup 2018-12-04 13:53:39 +00:00
SkSVGCircle.cpp [SVGDom] ClipPath support 2016-12-08 15:00:18 +00:00
SkSVGCircle.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkSVGClipPath.cpp [SVGDom] ClipPath support 2016-12-08 15:00:18 +00:00
SkSVGClipPath.h [SVGDom] ClipPath support 2016-12-08 15:00:18 +00:00
SkSVGContainer.cpp [SVGDom] ClipPath support 2016-12-08 15:00:18 +00:00
SkSVGContainer.h [SVGDom] Initial <use> support 2017-10-11 18:21:37 +00:00
SkSVGDefs.h [SVGDom] Initial linear gradient support 2016-09-12 17:06:47 -07:00
SkSVGDOM.cpp Revert "Revert "SkTypes: extract SkTo"" 2018-06-14 14:55:17 +00:00
SkSVGDOM.h [SVGDom] Expose intrinsic size info 2016-09-14 12:04:30 -07:00
SkSVGEllipse.cpp [SVGDom] ClipPath support 2016-12-08 15:00:18 +00:00
SkSVGEllipse.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkSVGG.h
SkSVGGradient.cpp [SVGDom] Fix href handling for radial gradients 2017-10-10 11:39:32 +00:00
SkSVGGradient.h [SVGDom] Factor out common gradient logic 2017-10-09 19:36:44 +00:00
SkSVGHiddenContainer.h [SVGDom] Initial linear gradient support 2016-09-12 17:06:47 -07:00
SkSVGIDMapper.h [SVGDom] Initial linear gradient support 2016-09-12 17:06:47 -07:00
SkSVGLine.cpp SkCanvas: Helpers for draw{Point,Line,Circle} 2017-05-16 12:59:11 +00:00
SkSVGLine.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkSVGLinearGradient.cpp [SVGDom] Factor out common gradient logic 2017-10-09 19:36:44 +00:00
SkSVGLinearGradient.h [SVGDom] Factor out common gradient logic 2017-10-09 19:36:44 +00:00
SkSVGNode.cpp Guard ignored SVG attribute logging with SK_VERBOSE_SVG_PARSING 2018-02-16 19:13:26 +00:00
SkSVGNode.h [SVGDom] Add 'stroke-dashoffset' support 2017-10-13 22:53:32 +00:00
SkSVGPath.cpp [SVGDom] Add clip-rule support 2017-10-10 19:23:23 +00:00
SkSVGPath.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkSVGPattern.cpp [SVGDom] Initial <pattern> support 2017-10-11 18:56:38 +00:00
SkSVGPattern.h [SVGDom] Initial <pattern> support 2017-10-11 18:56:38 +00:00
SkSVGPoly.cpp [SVGDom] Add clip-rule support 2017-10-10 19:23:23 +00:00
SkSVGPoly.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkSVGRadialGradient.cpp [SVGDom] Radial gradient support 2017-10-09 20:26:54 +00:00
SkSVGRadialGradient.h [SVGDom] Radial gradient support 2017-10-09 20:26:54 +00:00
SkSVGRect.cpp [SVGDom] ClipPath support 2016-12-08 15:00:18 +00:00
SkSVGRect.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkSVGRenderContext.cpp Revert "Revert "SkTypes: extract SkTo"" 2018-06-14 14:55:17 +00:00
SkSVGRenderContext.h [SVGDom] Initial <pattern> support 2017-10-11 18:56:38 +00:00
SkSVGShape.cpp [SVGDom] Add clip-rule support 2017-10-10 19:23:23 +00:00
SkSVGShape.h [SVGDom] Add clip-rule support 2017-10-10 19:23:23 +00:00
SkSVGStop.cpp [SVGDom] Initial linear gradient support 2016-09-12 17:06:47 -07:00
SkSVGStop.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkSVGSVG.cpp [SVGDom] Avoid some unneeded canvas save()s 2017-10-11 18:32:37 +00:00
SkSVGSVG.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkSVGTransformableNode.cpp [SVGDom] Avoid some unneeded canvas save()s 2017-10-11 18:32:37 +00:00
SkSVGTransformableNode.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SkSVGTypes.h [SVGDom] Add 'stroke-dasharray' support 2017-10-13 19:14:39 +00:00
SkSVGUse.cpp [SVGDom] Avoid some unneeded canvas save()s 2017-10-11 18:32:37 +00:00
SkSVGUse.h [SVGDom] Initial <use> support 2017-10-11 18:21:37 +00:00
SkSVGValue.cpp [SVGDom] Initial SVGLength support 2016-08-03 10:21:11 -07:00
SkSVGValue.h some SkAtomics cleanup 2018-12-04 13:53:39 +00:00