skia2/infra/bots
Mike Klein 9d4b788807 Revert "Split building encoding from decoding"
This reverts commit 94aaf7cdf5.

Reason for revert: you know what I already typed the reason stop making rules that people have to follow, robots.

Original change's description:
> Split building encoding from decoding
> 
> Bug: skia:9756
> 
> In CanvasKit, a large part of the binary is for encoding. Clients
> would be happier with a smaller binary and no webp/jpeg encoding. Make
> this an option by splitting up the GN arguments.
> 
> Split SK_HAS_WEBP_LIBRARY into SK_CODEC_DECODES_WEBP (to match the
> existing SK_CODEC_DECODES_RAW) and SK_ENCODE_WEBP. Same for JPEG and
> PNG.
> 
> Update CanvasKit compile script to disable webp and jpeg encoding.
> Update debugger compile script to disable all encoding.
> 
> Change IsPng signature to match other SkCodecs.
> 
> Change-Id: Iec8466ee1b76bc3d1e377c24201068b776cd7718
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/273768
> Commit-Queue: Leon Scroggins <scroggo@google.com>
> Reviewed-by: Derek Sollenberger <djsollen@google.com>
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Reviewed-by: Nathaniel Nifong <nifong@google.com>

TBR=djsollen@google.com,scroggo@google.com,kjlubick@google.com,nifong@google.com

Change-Id: I4fc2ea916743fda7e7d0d668b59e52052e880104
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:9756
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275710
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2020-03-06 21:39:21 +00:00
..
android_compile [Tree Status] Update all references in Skia repo to tree-status 2020-03-02 18:43:49 +00:00
assets [infra] Update node to 12.16.1 2020-03-05 15:46:16 +00:00
buildstats
g3_compile [Tree Status] Update all references in Skia repo to tree-status 2020-03-02 18:43:49 +00:00
gen_tasks_logic Add iPhone11 jobs 2020-03-04 18:46:17 +00:00
recipe_modules Revert "Split building encoding from decoding" 2020-03-06 21:39:21 +00:00
recipes Revert "Split building encoding from decoding" 2020-03-06 21:39:21 +00:00
tools/luci-go
assets.isolate
build_task_drivers.sh [infra] Fix build_task_drivers.sh, update infra dep 2020-01-08 14:53:41 +00:00
bundle_recipes.sh
calmbench.isolate
canvaskit.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
cfg.json Enable ASAN on Windows 2019-12-30 17:06:26 +00:00
check_deps.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
compile_android_framework.isolate [infra] swarm_recipe.isolate shouldn't need infrabots.isolate 2019-07-19 18:40:02 +00:00
compile_g3_framework.isolate Fix G3 compile bot 2019-07-22 21:09:38 +00:00
compile.isolate fix build minimal_ios_mtl_skia_app 2019-12-16 19:44:36 +00:00
empty.isolate
gen_compile_isolate.py fix build minimal_ios_mtl_skia_app 2019-12-16 19:44:36 +00:00
gen_tasks.go Reland "[infra] Make most builds idempotent" 2019-07-19 12:11:27 +00:00
git_utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
infra_tests.isolate [infra] swarm_recipe.isolate shouldn't need infrabots.isolate 2019-07-19 18:40:02 +00:00
infra_tests.py [infra] Update docs with respect to Go modules. 2019-11-18 18:04:19 +00:00
infrabots.isolate
ios_bin.isolate
isolate_android_sdk_linux.isolate
isolate_gcloud_linux.isolate
isolate_go.isolate
jobs.json Remove bot to record DDL creation time 2020-03-06 20:20:50 +00:00
lottie_web.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
Makefile
OWNERS [infra] Remove stephana@ from OWNERS 2019-06-21 12:07:54 +00:00
pathkit.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
perf_skia_bundled.isolate
README.md
recipes.isolate [infra] Trim down isolate for recipe bundle 2019-06-27 18:27:44 +00:00
recipes.py Roll recipe dependencies (trivial). 2019-05-22 17:57:25 +00:00
resources.isolate
run_recipe.isolate [infra] Use Swarming task ID for logdog URL 2019-06-27 18:51:56 +00:00
run_recipe.py [infra] Use CIPD packages from infra repo 2019-11-20 14:02:48 +00:00
skottie_wasm.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
skpbench_skia_bundled.isolate
skqp.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
swarm_recipe.isolate [infra] swarm_recipe.isolate shouldn't need infrabots.isolate 2019-07-19 18:40:02 +00:00
task_drivers.isolate [infra] Add UpdateGoDeps bot 2019-06-18 18:25:13 +00:00
tasks.json Remove bot to record DDL creation time 2020-03-06 20:20:50 +00:00
test_skia_bundled.isolate
test_utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
update_meta_config.py Change name from skia.primary->luci.skia.skia.primary 2020-02-06 13:14:21 +00:00
upload_skps.py [Android compile bots] Add comment to CL when both nopatch and withpatch builds fail 2019-10-28 14:55:01 +00:00
utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
zip_utils_test.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
zip_utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00

Skia Infrastructure

This directory contains infrastructure elements.

Tasks and Jobs

Files in this directory define a DAG of tasks which run at every Skia commit. A task is a small, self-contained unit which runs via Swarming on a machine in the pool. Tasks may be chained together, eg. one task to compile test binaries and another to actually run them.

Jobs are collections of related tasks which help define sub-sections of the DAG, for example, to be used as try jobs. Each job is defined as an entry point into the DAG.

The tasks.json file in this directory is the master list of tasks and jobs for the repo. Note that tasks.json is NEVER edited by hand but generated via gen_task.go and the input files enumerated below. The Task Scheduler reads the tasks.json file at each commit to determine which jobs to run. For convenience, gen_tasks.go is provided to generate tasks.json and also to test it for correct syntax and detecting cycles and orphaned tasks. Always edit gen_tasks.go or one of the following input JSON files, rather than tasks.json itself:

  • cfg.json - Basic configuration information for gen_tasks.go.
  • jobs.json - The master list of all jobs to run. Edit this to add or remove bots.

Whenever gen_tasks.go, any of the above JSON files, or assets are changed, you need to run gen_tasks.go to regenerate tasks.json:

$ go run infra/bots/gen_tasks.go

Or:

$ cd infra/bots; make train

There is also a test mode which performs sanity-checks and verifies that tasks.json is unchanged:

$ go run infra/bots/gen_tasks.go --test

Or:

$ cd infra/bots; make test

Recipes

Recipes are the framework used by Skia's infrastructure to perform work inside of Swarming tasks. The main elements are:

  • recipes.py - Used for running and testing recipes.
  • recipes - These are the entry points for each type of task, eg. compiling or running tests.
  • recipe_modules - Shared modules which are used by recipes.
  • .recipe_deps - Recipes and modules may depend on modules from other repos. The recipes.py script automatically syncs those dependencies in this directory.

Isolate Files

These files determine which parts of the repository are transferred to the bot when a Swarming task is triggered. The Isolate tool hashes each file and will upload any new/changed files. Bots maintain a cache so that they can efficiently download only the files they don't have.

Assets

Artifacts used by the infrastructure are versioned here, along with scripts for recreating/uploading/downloading them. See the README in that directory for more information. Any time an asset used by the bots changes, you need to re-run gen_tasks.go.

Tools

Assorted other infrastructure-related tools, eg. isolate and CIPD binaries.

CT

Helpers for running Skia tasks in Cluster Telemetry.