dbfd7ab108
'static const' means, there must be at most one of these, and initialize it at compile time if possible or runtime if necessary. This leads to unexpected code execution, and TSAN* will complain about races on the guard variables. Generally 'constexpr' or 'const' are better choices. Neither can cause races: they're either intialized at compile time (constexpr) or intialized each time independently (const). This CL prefers constexpr where possible, and uses const where not. It even prefers constexpr over const where they don't make a difference... I want to have lots of examples of constexpr for people to see and mimic. The scoped-to-class static has nothing to do with any of this, and is not changed. * Not yet on the bots, which use an older TSAN. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005 Review-Url: https://codereview.chromium.org/2300623005
92 lines
2.8 KiB
C++
92 lines
2.8 KiB
C++
/*
|
|
* Copyright 2015 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "gm.h"
|
|
#include "SkImage.h"
|
|
#include "SkImageSource.h"
|
|
#include "SkSurface.h"
|
|
|
|
namespace skiagm {
|
|
|
|
// This GM reproduces the issue in crbug.com/472795. The SkImageSource image
|
|
// is shifted for high quality mode between cpu and gpu.
|
|
class ImageSourceGM : public GM {
|
|
public:
|
|
ImageSourceGM(const char* suffix, SkFilterQuality filter) : fSuffix(suffix), fFilter(filter) {
|
|
this->setBGColor(0xFFFFFFFF);
|
|
}
|
|
|
|
protected:
|
|
SkString onShortName() override {
|
|
SkString name("imagesrc2_");
|
|
name.append(fSuffix);
|
|
return name;
|
|
}
|
|
|
|
SkISize onISize() override { return SkISize::Make(256, 256); }
|
|
|
|
// Create an image with high frequency vertical stripes
|
|
void onOnceBeforeDraw() override {
|
|
constexpr SkPMColor gColors[] = {
|
|
SK_ColorRED, SK_ColorGRAY,
|
|
SK_ColorGREEN, SK_ColorGRAY,
|
|
SK_ColorBLUE, SK_ColorGRAY,
|
|
SK_ColorCYAN, SK_ColorGRAY,
|
|
SK_ColorMAGENTA, SK_ColorGRAY,
|
|
SK_ColorYELLOW, SK_ColorGRAY,
|
|
SK_ColorWHITE, SK_ColorGRAY,
|
|
};
|
|
|
|
auto surface(SkSurface::MakeRasterN32Premul(kImageSize, kImageSize));
|
|
SkCanvas* canvas = surface->getCanvas();
|
|
|
|
int curColor = 0;
|
|
|
|
for (int x = 0; x < kImageSize; x += 3) {
|
|
SkRect r = SkRect::MakeXYWH(SkIntToScalar(x), SkIntToScalar(0),
|
|
SkIntToScalar(3), SkIntToScalar(kImageSize));
|
|
SkPaint p;
|
|
p.setColor(gColors[curColor]);
|
|
canvas->drawRect(r, p);
|
|
|
|
curColor = (curColor+1) % SK_ARRAY_COUNT(gColors);
|
|
}
|
|
|
|
fImage = surface->makeImageSnapshot();
|
|
}
|
|
|
|
void onDraw(SkCanvas* canvas) override {
|
|
const SkRect srcRect = SkRect::MakeLTRB(0, 0,
|
|
SkIntToScalar(kImageSize),
|
|
SkIntToScalar(kImageSize));
|
|
const SkRect dstRect = SkRect::MakeLTRB(0.75f, 0.75f, 225.75f, 225.75f);
|
|
|
|
SkPaint p;
|
|
p.setImageFilter(SkImageSource::Make(fImage, srcRect, dstRect, fFilter));
|
|
|
|
canvas->saveLayer(nullptr, &p);
|
|
canvas->restore();
|
|
}
|
|
|
|
private:
|
|
static constexpr int kImageSize = 503;
|
|
|
|
SkString fSuffix;
|
|
SkFilterQuality fFilter;
|
|
sk_sp<SkImage> fImage;
|
|
|
|
typedef GM INHERITED;
|
|
};
|
|
|
|
//////////////////////////////////////////////////////////////////////////////
|
|
|
|
DEF_GM(return new ImageSourceGM("none", kNone_SkFilterQuality);)
|
|
DEF_GM(return new ImageSourceGM("low", kLow_SkFilterQuality);)
|
|
DEF_GM(return new ImageSourceGM("med", kMedium_SkFilterQuality);)
|
|
DEF_GM(return new ImageSourceGM("high", kHigh_SkFilterQuality);)
|
|
}
|