skia2/infra/bots
Adlai Holler e5c379d3a1 Reland "Update skpbench to let the gpu thread run alongside the recording threads"
This reverts commit 2403a1001b.

Reason for revert: Fixed bot failure

Original change's description:
> Revert "Update skpbench to let the gpu thread run alongside the recording threads"
>
> This reverts commit ca06ce48f1.
>
> Reason for revert: It is dying on a bot with the error:
> skpbench.py: error: unrecognized arguments: --ddlNumRecordingThreads c:\b\s\w\ir\skp
>
> Original change's description:
> > Update skpbench to let the gpu thread run alongside the recording threads
> >
> > Bug: skia:10176
> > Change-Id: Ibadd52b86abfd2802b9b3f31c86ab573554601db
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289883
> > Commit-Queue: Adlai Holler <adlai@google.com>
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
>
> TBR=robertphillips@google.com,adlai@google.com
>
> Change-Id: Iec316410563f0fe1d06f44bcfa58f6790c547f98
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:10176
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290117
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>

TBR=robertphillips@google.com,adlai@google.com


Bug: skia:10176
Change-Id: I1b57c91ed60b093440191274d1acb72d9e0c3b37
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290443
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Adlai Holler <adlai@google.com>
2020-05-18 15:12:47 +00:00
..
android_compile [Tree Status] Update all references in Skia repo to tree-status 2020-03-02 18:43:49 +00:00
assets Update SKP version 2020-05-17 08:50:18 +00:00
buildstats
g3_compile [Tree Status] Update all references in Skia repo to tree-status 2020-03-02 18:43:49 +00:00
gen_tasks_logic Blacklist gpu_blur_utils GMs from gltestthreading 2020-05-14 23:13:36 +00:00
recipe_modules not all bots have env 2020-05-14 02:02:18 +00:00
recipes Reland "Update skpbench to let the gpu thread run alongside the recording threads" 2020-05-18 15:12:47 +00:00
task_drivers [infra] use more unique task id for perf upload 2020-05-04 17:19:03 +00:00
tools/luci-go
assets.isolate
build_task_drivers.sh [infra] Add POC task driver 2020-04-28 11:50:17 +00:00
bundle_recipes.sh
calmbench.isolate
canvaskit.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
cfg.json Enable ASAN on Windows 2019-12-30 17:06:26 +00:00
check_deps.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
compile_android_framework.isolate [infra] swarm_recipe.isolate shouldn't need infrabots.isolate 2019-07-19 18:40:02 +00:00
compile_g3_framework.isolate Fix G3 compile bot 2019-07-22 21:09:38 +00:00
compile.isolate Remove SkFrontBufferedStream 2020-04-28 13:51:40 +00:00
empty.isolate
gen_compile_isolate.py fix build minimal_ios_mtl_skia_app 2019-12-16 19:44:36 +00:00
gen_tasks.go Reland "[infra] Make most builds idempotent" 2019-07-19 12:11:27 +00:00
git_utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
infra_tests.isolate [infra] swarm_recipe.isolate shouldn't need infrabots.isolate 2019-07-19 18:40:02 +00:00
infra_tests.py [infra] Run recipe and python unittests unbuffered 2020-03-18 15:33:38 +00:00
infrabots.isolate
ios_bin.isolate
isolate_android_sdk_linux.isolate
isolate_gcloud_linux.isolate
isolate_go.isolate
jobs.json S20 vk? 2020-05-13 22:23:43 +00:00
lottie_web.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
Makefile
OWNERS [infra] Remove stephana@ from OWNERS 2019-06-21 12:07:54 +00:00
pathkit.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
perf_puppeteer.isolate [canvaskit] Start a generic puppeteer perfing system. 2020-05-01 19:23:08 +00:00
perf_skia_bundled.isolate
README.md Add more detail on configuring jobs. 2019-03-21 10:54:17 +00:00
recipes.isolate [infra] Trim down isolate for recipe bundle 2019-06-27 18:27:44 +00:00
recipes.py Roll recipe dependencies (trivial). 2019-05-22 17:57:25 +00:00
resources.isolate
run_recipe.isolate [infra] Use Swarming task ID for logdog URL 2019-06-27 18:51:56 +00:00
run_recipe.py [infra] Use CIPD packages from infra repo 2019-11-20 14:02:48 +00:00
skottie_wasm.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
skpbench_skia_bundled.isolate
skqp.isolate [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 18:46:34 +00:00
swarm_recipe.isolate [infra] swarm_recipe.isolate shouldn't need infrabots.isolate 2019-07-19 18:40:02 +00:00
task_drivers.isolate [infra] Add POC task driver 2020-04-28 11:50:17 +00:00
tasks.json Update Go Deps 2020-05-18 05:38:13 +00:00
test_skia_bundled.isolate
test_utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
update_meta_config.py Change name from skia.primary->luci.skia.skia.primary 2020-02-06 13:14:21 +00:00
upload_skps.py [Android compile bots] Add comment to CL when both nopatch and withpatch builds fail 2019-10-28 14:55:01 +00:00
utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
zip_utils_test.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00
zip_utils.py [minor] mark scripts as executable 2019-11-21 17:06:27 +00:00

Skia Infrastructure

This directory contains infrastructure elements.

Tasks and Jobs

Files in this directory define a DAG of tasks which run at every Skia commit. A task is a small, self-contained unit which runs via Swarming on a machine in the pool. Tasks may be chained together, eg. one task to compile test binaries and another to actually run them.

Jobs are collections of related tasks which help define sub-sections of the DAG, for example, to be used as try jobs. Each job is defined as an entry point into the DAG.

The tasks.json file in this directory is the master list of tasks and jobs for the repo. Note that tasks.json is NEVER edited by hand but generated via gen_task.go and the input files enumerated below. The Task Scheduler reads the tasks.json file at each commit to determine which jobs to run. For convenience, gen_tasks.go is provided to generate tasks.json and also to test it for correct syntax and detecting cycles and orphaned tasks. Always edit gen_tasks.go or one of the following input JSON files, rather than tasks.json itself:

  • cfg.json - Basic configuration information for gen_tasks.go.
  • jobs.json - The master list of all jobs to run. Edit this to add or remove bots.

Whenever gen_tasks.go, any of the above JSON files, or assets are changed, you need to run gen_tasks.go to regenerate tasks.json:

$ go run infra/bots/gen_tasks.go

Or:

$ cd infra/bots; make train

There is also a test mode which performs sanity-checks and verifies that tasks.json is unchanged:

$ go run infra/bots/gen_tasks.go --test

Or:

$ cd infra/bots; make test

Recipes

Recipes are the framework used by Skia's infrastructure to perform work inside of Swarming tasks. The main elements are:

  • recipes.py - Used for running and testing recipes.
  • recipes - These are the entry points for each type of task, eg. compiling or running tests.
  • recipe_modules - Shared modules which are used by recipes.
  • .recipe_deps - Recipes and modules may depend on modules from other repos. The recipes.py script automatically syncs those dependencies in this directory.

Isolate Files

These files determine which parts of the repository are transferred to the bot when a Swarming task is triggered. The Isolate tool hashes each file and will upload any new/changed files. Bots maintain a cache so that they can efficiently download only the files they don't have.

Assets

Artifacts used by the infrastructure are versioned here, along with scripts for recreating/uploading/downloading them. See the README in that directory for more information. Any time an asset used by the bots changes, you need to re-run gen_tasks.go.

Tools

Assorted other infrastructure-related tools, eg. isolate and CIPD binaries.

CT

Helpers for running Skia tasks in Cluster Telemetry.