089b7c96ca
I created this problem with my fix to crbug.com/1108475 Bug: 1112259 Change-Id: Ieb001fa61bd9ed68dcae43e7d511b4581f16ef0f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308638 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
134 lines
5.6 KiB
C++
134 lines
5.6 KiB
C++
/*
|
|
* Copyright 2020 Google LLC
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "include/gpu/GrDirectContext.h"
|
|
#include "include/gpu/GrRecordingContext.h"
|
|
#include "src/gpu/GrContextPriv.h"
|
|
#include "src/gpu/GrProxyProvider.h"
|
|
#include "src/gpu/GrRecordingContextPriv.h"
|
|
#include "src/gpu/ops/GrTextureOp.h"
|
|
#include "src/gpu/ops/GrTextureOp.h"
|
|
#include "tests/Test.h"
|
|
|
|
class OpsTaskTestingAccess {
|
|
public:
|
|
typedef GrOpsTask::OpChain OpChain;
|
|
};
|
|
|
|
static void check_chain(OpsTaskTestingAccess::OpChain* chain, SkRect firstRect, SkRect lastRect,
|
|
int expectedNumOps) {
|
|
int actualNumOps = 0;
|
|
for (const auto& op : GrOp::ChainRange<>(chain->head())) {
|
|
++actualNumOps;
|
|
|
|
if (actualNumOps == 1) {
|
|
SkAssertResult(op.bounds() == firstRect.makeOutset(0.5f, 0.5f));
|
|
} else if (actualNumOps == expectedNumOps) {
|
|
SkAssertResult(op.bounds() == lastRect.makeOutset(0.5f, 0.5f));
|
|
}
|
|
}
|
|
|
|
SkAssertResult(actualNumOps == expectedNumOps);
|
|
}
|
|
|
|
static sk_sp<GrSurfaceProxy> create_proxy(GrRecordingContext* rContext) {
|
|
const GrCaps* caps = rContext->priv().caps();
|
|
|
|
static constexpr SkISize kDimensions = {16, 16};
|
|
|
|
const GrBackendFormat format = caps->getDefaultBackendFormat(GrColorType::kRGBA_8888,
|
|
GrRenderable::kYes);
|
|
return rContext->priv().proxyProvider()->createProxy(
|
|
format, kDimensions, GrRenderable::kYes, 1, GrMipmapped::kNo, SkBackingFit::kExact,
|
|
SkBudgeted::kNo, GrProtected::kNo, GrInternalSurfaceFlags::kNone);
|
|
}
|
|
|
|
static std::unique_ptr<GrDrawOp> create_op(GrDirectContext* dContext, SkRect rect,
|
|
const GrSurfaceProxyView& proxyView, bool isAA) {
|
|
DrawQuad quad;
|
|
|
|
quad.fDevice = GrQuad::MakeFromRect(rect.makeOutset(0.5f, 0.5f), SkMatrix::I());
|
|
quad.fLocal = GrQuad(rect);
|
|
quad.fEdgeFlags = isAA ? GrQuadAAFlags::kAll : GrQuadAAFlags::kNone;
|
|
|
|
return GrTextureOp::Make(dContext,
|
|
proxyView,
|
|
kPremul_SkAlphaType,
|
|
nullptr,
|
|
GrSamplerState::Filter::kNearest,
|
|
GrSamplerState::MipmapMode::kNone,
|
|
{1.f, 1.f, 1.f, 1.f},
|
|
GrTextureOp::Saturate::kYes,
|
|
SkBlendMode::kSrcOver,
|
|
isAA ? GrAAType::kCoverage
|
|
: GrAAType::kNone,
|
|
&quad,
|
|
nullptr);
|
|
}
|
|
|
|
// This unit test exercises the crbug.com/1112259 case.
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(TextureOpTest, reporter, ctxInfo) {
|
|
|
|
GrDirectContext* dContext = ctxInfo.directContext();
|
|
const GrCaps* caps = dContext->priv().caps();
|
|
GrRecordingContext::Arenas arenas = dContext->priv().arenas();
|
|
auto auditTrail = dContext->priv().auditTrail();
|
|
|
|
if (!caps->dynamicStateArrayGeometryProcessorTextureSupport()) {
|
|
// This test requires chaining
|
|
return;
|
|
}
|
|
|
|
GrSurfaceProxyView proxyViewA(create_proxy(dContext),
|
|
kTopLeft_GrSurfaceOrigin,
|
|
GrSwizzle::RGBA());
|
|
GrSurfaceProxyView proxyViewB(create_proxy(dContext),
|
|
kTopLeft_GrSurfaceOrigin,
|
|
GrSwizzle::RGBA());
|
|
GrSurfaceProxyView proxyViewC(create_proxy(dContext),
|
|
kTopLeft_GrSurfaceOrigin,
|
|
GrSwizzle::RGBA());
|
|
|
|
static const SkRect kOpARect{ 0, 0, 16, 16 };
|
|
static const SkRect kOpBRect{ 32, 0, 48, 16 };
|
|
static const SkRect kOpCRect{ 0, 32, 16, 48 };
|
|
static const SkRect kOpDRect{ 32, 32, 48, 48 };
|
|
|
|
// opA & opB can chain together but can't merge bc they have different proxies
|
|
std::unique_ptr<GrDrawOp> opA = create_op(dContext, kOpARect, proxyViewA, false);
|
|
std::unique_ptr<GrDrawOp> opB = create_op(dContext, kOpBRect, proxyViewB, false);
|
|
|
|
GrAppliedClip noClip = GrAppliedClip::Disabled();
|
|
OpsTaskTestingAccess::OpChain chain1(std::move(opA), GrProcessorSet::EmptySetAnalysis(),
|
|
&noClip, nullptr);
|
|
chain1.appendOp(std::move(opB), GrProcessorSet::EmptySetAnalysis(), nullptr, &noClip, *caps,
|
|
&arenas, dContext->priv().auditTrail());
|
|
check_chain(&chain1, kOpARect, kOpBRect, 2);
|
|
|
|
// opC & opD can also chain together but can't merge (bc, again, they have different
|
|
// proxies). Note, however, that opA and opD do share a proxy so can be merged if opA's
|
|
// anti-aliasing is upgraded to coverage.
|
|
std::unique_ptr<GrDrawOp> opC = create_op(dContext, kOpCRect, proxyViewC, true);
|
|
std::unique_ptr<GrDrawOp> opD = create_op(dContext, kOpDRect, proxyViewA, true);
|
|
|
|
OpsTaskTestingAccess::OpChain chain2(std::move(opC), GrProcessorSet::EmptySetAnalysis(),
|
|
&noClip, nullptr);
|
|
chain2.appendOp(std::move(opD), GrProcessorSet::EmptySetAnalysis(), nullptr, &noClip, *caps,
|
|
&arenas, auditTrail);
|
|
check_chain(&chain2, kOpCRect, kOpDRect, 2);
|
|
|
|
// opA and opD, now in separate chains, can merge when the two chains are combined while
|
|
// opB and opC can still only chain.
|
|
chain1.prependChain(&chain2, *caps, &arenas, auditTrail);
|
|
|
|
// We should end up with the chain
|
|
// opC - opD/opA - opB
|
|
check_chain(&chain1, kOpCRect, kOpBRect, 3);
|
|
|
|
chain1.deleteOps(arenas.opMemoryPool());
|
|
}
|