343258fa0c
sk_SecondaryFragColor corresponds to an ES2-only concept (gl_SecondaryFragColorEXT) and does not have any SPIR-V equivalent. Two fixes were needed: - sk_SecondaryFragColor shouldn't be in SPIR-V code at all. Report it as an error when it appears. - We don't stop compilation when this error is reported, so we need to fix up the assertion that the fuzzer initially discovered. Specifically, the fuzzer found that the `sk_SecondaryFragColor` variable never got a SPIR-V ID assigned to it in fVariableMap, so the compiler would assert when assembling an expression containing that variable. Now, we make sure to populate fVariableMap with an (unused) ID in `writeGlobalVar` to avoid this crash. Change-Id: Ib86919dfc9a325b2b82a7f4b2054b747dad7c32f Bug: oss-fuzz:44096 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/501976 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> |
||
|---|---|---|
| .. | ||
| blend | ||
| errors | ||
| es2_conformance | ||
| folding | ||
| glsl | ||
| inliner | ||
| intrinsics | ||
| metal | ||
| runtime | ||
| runtime_errors | ||
| shared | ||
| spirv | ||
| workarounds | ||
| README.txt | ||
| update_fuzzer.py | ||
This directory contains source files for testing skslc compilation. The compiled output files are in the /tests/sksl/ directory.