380d7d7339
Reason for revert: Want to think about how to do this only to skialib and not to tools (gms, tests, etc.) Original issue's description: > No threadsafe statics. > > Chrome disables these for speed and code size, so we need > to disable them to make sure our code is safe when used > this way. > > int foo() { > static int32_t atomic_thing; > return sk_atomic_inc(&atomic_thing); > } > > is not safe in Chrome. Making the static global is: > > static int32_t atomic_thing; > int foo() { > return sk_atomic_inc(&atomic_thing); > } > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/cad5d3e264535c919b80e1e2a85407307961f221 TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/649343003 |
||
---|---|---|
animations | ||
bench | ||
debugger | ||
dm | ||
docs | ||
expectations | ||
experimental | ||
forth | ||
gm | ||
gyp | ||
include | ||
platform_tools | ||
resources | ||
samplecode | ||
src | ||
tests | ||
third_party | ||
tools | ||
trybots_to_run/chrome | ||
.gitignore | ||
AUTHORS | ||
codereview.settings | ||
CONTRIBUTING | ||
CQ_COMMITTERS | ||
DEPS | ||
Doxyfile | ||
gyp_skia | ||
gyp_skia.py | ||
LICENSE | ||
make.bat | ||
make.py | ||
Makefile | ||
OWNERS | ||
PRESUBMIT.py | ||
README | ||
README.chromium | ||
skia.gyp | ||
SKP_VERSION | ||
whitespace.txt |
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://sites.google.com/site/skiadocs/home