AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3934647d22
skia2/infra/bots
History
John Stiles 3934647d22 Reland "Implement operator== and != for Metal structs and arrays." 
This is a reland of 830c69ca66

Original change's description:
> Implement operator== and != for Metal structs and arrays.
>
> GLSL/SkSL assumes that == and != on struct/array types should work.
> We need to emit equality and inequality operators whenever we find code
> that compares a struct or array.
>
> Structs and arrays can be arbitrarily nested, and either type can
> contain a matrix. All of these things need custom equality operators in
> Metal. Therefore, we need to recursively generate comparison operators
> when any of these types are encountered.
>
> For arrays we get lucky, and we can cover all possible array types and
> sizes with a single templated operator== method. Structs and matrices
> have no such luck, and are generated separately on a per-type basis.
>
> For each of these types, operator== is implemented as an equality check
> on each field, and operator!= is implemented in terms of operator==.
> Equality and inequality are always emitted together. (Previously, matrix
> equality and inequality were emitted and implemented independently, but
> this is no longer the case.)
>
> Change-Id: I69ee01c0a390d7db6bcb2253ed6336ab20cc4d1d
> Bug: skia:11908, skia:11924
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/402016
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

Bug: skia:11908, skia:11924, skia:11929
Change-Id: I6336b6125e9774c1ca73e3d497e3466f11f6f25f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/402559
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-04-29 22:55:58 +00:00
..
assets Update SKP version 2021-04-25 18:43:07 +00:00
buildstats Fix Python3 compatibility 2021-03-25 14:15:35 +00:00
gen_tasks_logic Reland "Implement operator== and != for Metal structs and arrays." 2021-04-29 22:55:58 +00:00
recipe_modules [infra] Update recipe deps 2021-04-20 19:49:56 +00:00
recipes Enable DAG reordering on almost all bots 2021-04-22 16:55:39 +00:00
task_drivers [canvaskit] Skip problematic skp 2021-03-30 13:07:38 +00:00
tools/luci-go
build_task_drivers.sh add Mac/Win FM bots 2021-02-01 17:35:52 +00:00
bundle_recipes.sh
cfg.json [infra] Add Config.PathToSkia 2021-03-01 15:55:30 +00:00
check_deps.py [sk] Add DEPS entry for "sk" tool 2021-04-09 14:21:37 +00:00
gen_tasks.go Reland "[infra] Make most builds idempotent" 2019-07-19 12:11:27 +00:00
git_utils.py [infra] Change git_utils.NewGitRepo to use the default "git clone" dir 2021-02-24 17:43:04 +00:00
infra_tests.py Fix Python3 compatibility 2021-03-25 14:15:35 +00:00
jobs.json Remove pixelbook devices. 2021-04-23 17:09:53 +00:00
Makefile
OWNERS [infra] Remove stephana@ from OWNERS 2019-06-21 12:07:54 +00:00
README.md Remove "sanity"/"insane" to comply with Android's inclusive language guidance 2020-07-31 19:21:04 +00:00
README.recipes.md [infra] Update recipe deps 2021-04-20 19:49:56 +00:00
recipes.py [infra] Update recipe deps 2021-04-20 19:49:56 +00:00
run_recipe.py Fix Python3 compatibility 2021-03-25 14:15:35 +00:00
tasks.json Update SKP version 2021-04-25 18:43:07 +00:00
test_utils.py Fix Python3 compatibility 2021-03-25 14:15:35 +00:00
upload_skps.py [Android compile bots] Add comment to CL when both nopatch and withpatch builds fail 2019-10-28 14:55:01 +00:00
utils.py Fix Python3 compatibility 2021-03-25 14:15:35 +00:00
zip_utils_test.py Fix Python3 compatibility 2021-03-25 14:15:35 +00:00
zip_utils.py Fix Python3 compatibility 2021-03-25 14:15:35 +00:00

README.md

Skia Infrastructure

This directory contains infrastructure elements.

Tasks and Jobs

Files in this directory define a DAG of tasks which run at every Skia commit. A task is a small, self-contained unit which runs via Swarming on a machine in the pool. Tasks may be chained together, eg. one task to compile test binaries and another to actually run them.

Jobs are collections of related tasks which help define sub-sections of the DAG, for example, to be used as try jobs. Each job is defined as an entry point into the DAG.

The tasks.json file in this directory is the list of tasks and jobs for the repo. Note that tasks.json is NEVER edited by hand but generated via gen_task.go and the input files enumerated below. The Task Scheduler reads the tasks.json file at each commit to determine which jobs to run. For convenience, gen_tasks.go is provided to generate tasks.json and also to test it for correct syntax and detecting cycles and orphaned tasks. Always edit gen_tasks.go or one of the following input JSON files, rather than tasks.json itself:

  • cfg.json - Basic configuration information for gen_tasks.go.
  • jobs.json - The list of all jobs to run. Edit this to add or remove bots.

Whenever gen_tasks.go, any of the above JSON files, or assets are changed, you need to run gen_tasks.go to regenerate tasks.json:

$ go run infra/bots/gen_tasks.go

Or:

$ cd infra/bots; make train

There is also a test mode which performs consistency checks and verifies that tasks.json is unchanged:

$ go run infra/bots/gen_tasks.go --test

Or:

$ cd infra/bots; make test

Recipes

Recipes are the framework used by Skia's infrastructure to perform work inside of Swarming tasks. The main elements are:

  • recipes.py - Used for running and testing recipes.
  • recipes - These are the entry points for each type of task, eg. compiling or running tests.
  • recipe_modules - Shared modules which are used by recipes.
  • .recipe_deps - Recipes and modules may depend on modules from other repos. The recipes.py script automatically syncs those dependencies in this directory.

Isolate Files

These files determine which parts of the repository are transferred to the bot when a Swarming task is triggered. The Isolate tool hashes each file and will upload any new/changed files. Bots maintain a cache so that they can efficiently download only the files they don't have.

Assets

Artifacts used by the infrastructure are versioned here, along with scripts for recreating/uploading/downloading them. See the README in that directory for more information. Any time an asset used by the bots changes, you need to re-run gen_tasks.go.

Tools

Assorted other infrastructure-related tools, eg. isolate and CIPD binaries.

CT

Helpers for running Skia tasks in Cluster Telemetry.