skia2/samplecode
Brian Osman 3e31e99bab Revert "Alloc glyph image correctly for SkMask::k3D_Format."
This reverts commit 1662257bda.

Reason for revert: Android still using this API

Original change's description:
> Alloc glyph image correctly for SkMask::k3D_Format.
> 
> Remove the no longer used outside Skia SK_SUPPORT_LEGACY_EMBOSSMASKFILTER
> define, and either delete the code it guards or update it to use the new
> emboss mask filter factory.
> 
> Re-enable the code to test the emboss mask filter.
> 
> Add a test to ensure that embossed text is drawn correctly, as before
> glyphs did not allocate the proper amount of memory for the k3D_Format
> which the emboss mask filter produces.
> 
> Fixes SkEmbossMask::Emboss to write the whole of the mul and add planes
> to avoid pixel differences and MemorySanitizer errors.
> 
> Update the GPU to understand the k3D_Format and use just the alpha
> plane, ignoring the mul and add plane which it currently cannot support.
> 
> Change-Id: Icac1a3f37d6e8c6be3151df570f5e14111e18585
> Reviewed-on: https://skia-review.googlesource.com/70260
> Reviewed-by: Herb Derby <herb@google.com>
> Reviewed-on: https://skia-review.googlesource.com/70962
> Commit-Queue: Ben Wagner <bungeman@google.com>

TBR=djsollen@google.com,bungeman@google.com,herb@google.com

Change-Id: Id6625bae8d3bd70ce7aa3045348c04fdd146c637
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/71183
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2017-11-14 16:16:45 +00:00
..
ClockFaceView.cpp Remove internal use of SkTypeface::Style. 2017-07-27 21:30:45 +00:00
DecodeFile.h use unique_ptr for codec factories 2017-07-25 15:35:23 +00:00
GMSampleView.cpp move files out of private, and fix up callers to IWYU 2017-05-16 21:29:03 +00:00
GMSampleView.h Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
OverView.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
OverView.h
PerlinPatch.cpp Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
Sample2PtRadial.cpp
SampleAAClip.cpp
SampleAAGeometry.cpp move parts of SkPoint to SkPointPriv 2017-11-08 18:25:17 +00:00
SampleAARectModes.cpp Use SkBlendMode_Name rather than one-off tables 2017-03-15 16:52:49 +00:00
SampleAARects.cpp
SampleAll.cpp Revert "Alloc glyph image correctly for SkMask::k3D_Format." 2017-11-14 16:16:45 +00:00
SampleAndroidShadows.cpp Add tonal color support for shadows. 2017-06-09 17:18:58 +00:00
SampleAnimatedText.cpp Revert "Revert "Reland: Remove SkLights include from SkCanvas.h"" 2017-05-03 19:17:11 +00:00
SampleAnimator.cpp SkFontData to use smart pointers. 2016-09-16 06:24:20 -07:00
SampleAnimBlur.cpp
SampleApp.cpp clean up cruft about --portableFonts and --resourceFonts 2017-11-06 15:09:09 +00:00
SampleApp.h Add measurement command line args to SampleApp 2017-09-25 19:12:50 +00:00
SampleArc.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleAtlas.cpp remove xfermode from public api 2016-10-28 20:06:17 +00:00
SampleBigBlur.cpp
SampleBigGradient.cpp Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
SampleBitmapRect.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleBlur.cpp remove unneeded code for index8 imagse 2017-07-03 19:07:25 +00:00
SampleCamera.cpp
SampleCCPRGeometry.cpp Convert geometry shaders to operate in Skia device space 2017-10-25 15:59:18 +00:00
SampleChart.cpp hide trivial helpers on canvas 2017-02-22 19:41:04 +00:00
SampleChineseFling.cpp Miscellaneous dynamic atlas fixes. 2017-09-28 19:38:42 +00:00
SampleCircle.cpp
SampleClamp.cpp
SampleClip.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleClipDrawMatch.cpp hide trivial helpers on canvas 2017-02-22 19:41:04 +00:00
SampleClock.cpp
SampleCode.cpp Misc batch->op cleanup Part 1 of 2 2016-12-21 16:45:40 +00:00
SampleCode.h
SampleColorFilter.cpp remove xfermode from public api 2016-10-28 20:06:17 +00:00
SampleComplexClip.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleConcavePaths.cpp Revert "Revert "make it illegal to include SkXfermode.h"" 2016-11-23 22:17:17 +00:00
SampleCowboy.cpp Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
SampleDash.cpp
SampleDegenerateTwoPtRadials.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleDither.cpp Revert "Revert "Delete copyTo(Allocator), hide copyTo() behind flag"" 2017-04-28 15:49:04 +00:00
SampleEffects.cpp Revert "Alloc glyph image correctly for SkMask::k3D_Format." 2017-11-14 16:16:45 +00:00
SampleEmboss.cpp Revert "Revert "make it illegal to include SkXfermode.h"" 2016-11-23 22:17:17 +00:00
SampleFatBits.cpp move parts of SkPoint to SkPointPriv 2017-11-08 18:25:17 +00:00
SampleFillType.cpp
SampleFilter2.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleFilterFuzz.cpp Remove SkTypeface::Style from fuzzers and lua. 2017-08-08 15:27:19 +00:00
SampleFilterQuality.cpp Move expensive initialization to onOnceBeforeDraw 2017-07-12 20:30:50 +00:00
SampleFontCache.cpp
SampleFontScalerTest.cpp Remove internal use of SkTypeface::Style. 2017-07-27 21:30:45 +00:00
SampleFuzz.cpp Revert "Revert "make it illegal to include SkXfermode.h"" 2016-11-23 22:17:17 +00:00
SampleGradients.cpp
SampleHairCurves.cpp
SampleHairline.cpp SkCanvas: Helpers for draw{Point,Line,Circle} 2017-05-16 12:59:11 +00:00
SampleHairModes.cpp Use SkBlendMode_Name rather than one-off tables 2017-03-15 16:52:49 +00:00
SampleHT.cpp move parts of SkPoint to SkPointPriv 2017-11-08 18:25:17 +00:00
SampleIdentityScale.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleLayerMask.cpp Revert "Revert "Reland: Remove SkLights include from SkCanvas.h"" 2017-05-03 19:17:11 +00:00
SampleLayers.cpp Initial clip-mask-layer support 2017-05-01 14:07:10 +00:00
SampleLCD.cpp
SampleLines.cpp Revert "Revert "make it illegal to include SkXfermode.h"" 2016-11-23 22:17:17 +00:00
SampleLua.cpp Mark ~LuaView as override. 2017-10-09 14:53:15 +00:00
SampleManyRects.cpp hide trivial helpers on canvas 2017-02-22 19:41:04 +00:00
SampleMeasure.cpp
SampleMegaStroke.cpp
SamplePatch.cpp move vertex-mode enum into SkVertices 2017-04-03 15:50:16 +00:00
SamplePath.cpp Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
SamplePathClip.cpp SkCanvas: Helpers for draw{Point,Line,Circle} 2017-05-16 12:59:11 +00:00
SamplePathEffects.cpp begin to hide details of SkPathEffect 2017-02-26 18:36:11 +00:00
SamplePathFill.cpp stop using SkScalarMul 2017-02-14 19:45:24 +00:00
SamplePathFinder.cpp Add a SampleApp flag to automate keystrokes on startup 2017-10-18 17:25:56 +00:00
SamplePathFuzz.cpp simplify path validate 2017-08-29 18:37:11 +00:00
SamplePathOverstroke.cpp
SamplePathText.cpp Add clipping options to path text bench and samples 2017-11-07 01:51:31 +00:00
SamplePdfFileViewer.cpp Revert "Revert "make it illegal to include SkXfermode.h"" 2016-11-23 22:17:17 +00:00
SamplePictFile.cpp Remove trailing whitespace. 2017-10-09 21:20:34 +00:00
SamplePoints.cpp Revert "Revert "make it illegal to include SkXfermode.h"" 2016-11-23 22:17:17 +00:00
SamplePolyToPoly.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleQuadStroker.cpp move parts of SkPoint to SkPointPriv 2017-11-08 18:25:17 +00:00
SampleRectanizer.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleRegion.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleRepeatTile.cpp
SampleShaders.cpp hide trivial helpers on canvas 2017-02-22 19:41:04 +00:00
SampleShaderText.cpp
SampleShadowColor.cpp Add tonal color support for shadows. 2017-06-09 17:18:58 +00:00
SampleShadowReference.cpp Add Material Design shadow reference sample 2017-05-23 18:12:15 +00:00
SampleShadowUtils.cpp Revert "Revert "Delete SkGaussianEdgeShader"" 2017-05-31 14:52:12 +00:00
SampleShip.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleSlides.cpp Remove internal use of SkTypeface::Style. 2017-07-27 21:30:45 +00:00
SampleStringArt.cpp
SampleStrokePath.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleStrokeRect.cpp
SampleSubpixelTranslate.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleSVGFile.cpp Mark overridden destructors with 'override' and remove 'virtual' 2017-03-22 16:06:18 +00:00
SampleSVGPong.cpp [SVGDom] Expose intrinsic size info 2016-09-14 12:04:30 -07:00
SampleText.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleTextAlpha.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleTextBox.cpp Revert "Revert "make it illegal to include SkXfermode.h"" 2016-11-23 22:17:17 +00:00
SampleTextOnPath.cpp
SampleTextureDomain.cpp hide lockpixels api behind flag 2017-04-17 15:33:36 +00:00
SampleTiling.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleUnpremul.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleVertices.cpp hide lockpixels api behind flag 2017-04-17 15:33:36 +00:00
SampleWritePixels.cpp
SampleXfer.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
SampleXfermodesBlur.cpp add drawString helper to canvas 2017-04-28 20:41:04 +00:00
vertexdump.cpp