3e62762229
Previously, GrColorSpaceXformEffect had separate Make methods; one took a child FP, the other did not, and they had slightly different color- transform inputs (the destination alpha type was assumed to be premul when a child FP was provided). A null FP was considered invalid. This has been updated to work more like other FPs. An childFP must always be supplied, and nullptr is interpreted as "use the sk_InColor". The destination alpha type is now always supplied. Existing call sites were fixed up as needed. Previously, the child-FP path would actually render the product of the child FP and the sk_InColor. This extra multiplication step no longer occurs; the sk_InColor is simply ignored when a child FP is used. In practice, this did not affect any existing GM tests. Change-Id: Id53449234948255cbdaab9b88b1c94201eeb0a0d Bug: skia:10217 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299576 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Auto-Submit: John Stiles <johnstiles@google.com> |
||
|---|---|---|
| animations | ||
| bench | ||
| bin | ||
| build/fuchsia | ||
| build_overrides | ||
| client_utils/android | ||
| demos.skia.org | ||
| dm | ||
| docker | ||
| docs/examples | ||
| example | ||
| experimental | ||
| fuzz | ||
| gm | ||
| gn | ||
| include | ||
| infra | ||
| modules | ||
| platform_tools | ||
| resources | ||
| samplecode | ||
| site | ||
| specs | ||
| src | ||
| tests | ||
| third_party | ||
| tools | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| codereview.settings | ||
| CONTRIBUTING | ||
| CQ_COMMITTERS | ||
| DEPS | ||
| go.mod | ||
| go.sum | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| public.bzl | ||
| README | ||
| README.chromium | ||
| RELEASE_NOTES.txt | ||
| whitespace.txt | ||
Skia is a complete 2D graphic library for drawing Text, Geometries, and Images. See full details, and build instructions, at https://skia.org.