973d92cf91
Remove SkWindow::setColorType, it is used wrong and inconsistently. The color type is actually property of window backbuffer, used when the window is painted with software. This is as opposed to a generic window property that would affect all operation. Similar to MSAA sample count for window GPU backbuffer, the bitmap backbuffer color type should be a parameter of "attach" or "create window" functions, should this property ever be added back. The apps use the call wrong, setting the type as kRGBA_8888 or kBGRRA_8888 without no apparent rationale. These color types are incorrect, as the raster surface can not work with these. Reorganize the SkWindow::resize, since no change in SkWindow backbuffer size does not neccessarily mean that SkView would not need the call. Do not show the sw backbuffer color type in SampleApp title, as it does not really provide any information. On small screens, kBGRA_8888_ColorType fills up the whole title. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1595503002 Review URL: https://codereview.chromium.org/1595503002 |
||
|---|---|---|
| .. | ||
| compare | ||
| js | ||
| DrawingMethods.cpp | ||
| DrawingMethods.h | ||
| Global.cpp | ||
| Global.h | ||
| JsContext.cpp | ||
| JsContext.h | ||
| Path2D.cpp | ||
| Path2D.h | ||
| Path2DBuilder.cpp | ||
| Path2DBuilder.h | ||
| README | ||
| SkV8Example.cpp | ||
| SkV8Example.h | ||
Build Instructions
==================
V8 gyp is not quite standard and Chromium uses a Python script
to work around that, for now we have some manual steps to do
before you can compile and run this sample:
1. Uncomment out the v8 dep in DEPS and re-run gclient sync.
2. Run 'make dependencies' in third_pary/externals/v8.
3. Run 'make native' in third_pary/externals/v8.
4. Uncomment SkV8Example in gyp/everything.gyp.
5. Run 'ninja -C out/Debug SkV8Example'
6. Run the sample as:
./out/Debug/SkV8Example --infile experimental/SkV8Example/js/speed.js