Go to file
mtklein 404eb87993 Revert of Add test for new FrontBufferedStream behavior. (patchset #1 id:1 of https://codereview.chromium.org/641813009/)
Reason for revert:
Test is SkASSERTing on Macs, e.g:

http://chromegw.corp.google.com/i/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/builds/257/steps/dm/logs/stdio

210 tasks left	1737M peak	    1ms	test FrontBufferedStream../../src/ports/SkImageDecoder_CG.cpp:43: failed assertion "data"

Signal 11:
_sigtramp (+0x1a)
SkStreamToCGImageSource(SkStream*) (+0x62)
SkImageDecoder_CG::onDecode(SkStream*, SkBitmap*, SkImageDecoder::Mode) (+0x2e)
SkImageDecoder::decode(SkStream*, SkBitmap*, SkColorType, SkImageDecoder::Mode) (+0x81)
SkImageDecoder::DecodeStream(SkStreamRewindable*, SkBitmap*, SkColorType, SkImageDecoder::Mode, SkImageDecoder::Format*) (+0xff)
SkImageDecoder::DecodeStream(SkStreamRewindable*, SkBitmap*) (+0x31)
test_ShortFrontBufferedStream(skiatest::Reporter*) (+0x97)
skiatest::ShortFrontBufferedStreamClass::onRun(skiatest::Reporter*) (+0x19)
skiatest::Test::run() (+0x7c)
DM::CpuTestTask::draw() (+0x5a)
DM::CpuTask::run() (+0x9e)
non-virtual thunk to DM::CpuTask::run() (+0x1c)
(anonymous namespace)::ThreadPool::Loop(void*) (+0xf4)
thread_start(void*) (+0x54)
_pthread_start (+0x14b)

Original issue's description:
> Add test for new FrontBufferedStream behavior.
>
> Test for https://skia.googlesource.com/skia/+/dd5a1e094c19fa10202c37c50a1f799e5af5dac0
>
> Verify that FrontBufferedStream does not attempt to read beyond the
> end of its underlying stream.
>
> Committed: https://skia.googlesource.com/skia/+/da59f05c6738dbb9a92cad21c608cdfae53a76b2

TBR=reed@google.com,scroggo@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/649553003
2014-10-23 12:08:03 -07:00
animations first cut at a checkbox 2009-10-21 19:41:10 +00:00
bench Qualify the return value of SkImageDecoder::decode 2014-10-22 12:07:00 -07:00
debugger Update old tools to allow MultiPictureDraw rendering 2014-10-09 04:59:19 -07:00
dm Fix DMWriteTask to write PDF files correctly 2014-10-17 14:36:10 -07:00
docs Remove references to out/Debug/tests executable. 2014-10-09 08:56:55 -07:00
expectations updating k1 expectations 2014-10-23 11:34:08 -07:00
experimental fix some bit-rot in the ios port of sampleapp 2014-10-22 13:06:00 -07:00
forth Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
gm Update fontMgr to take list of bcp47 language tags. 2014-10-23 07:08:06 -07:00
gyp Add SkMaskCache 2014-10-23 07:58:17 -07:00
include Remove android specific genID from SkPaint. 2014-10-23 10:23:07 -07:00
platform_tools Make -d x86 have the default GPU cache size. 2014-09-09 12:07:05 -07:00
resources use - and = to zoom text in slides 2014-10-21 10:46:01 -07:00
samplecode fix some bit-rot in the ios port of sampleapp 2014-10-22 13:06:00 -07:00
src Allocate only the vertices we need for text. 2014-10-23 11:57:12 -07:00
tests Revert of Add test for new FrontBufferedStream behavior. (patchset #1 id:1 of https://codereview.chromium.org/641813009/) 2014-10-23 12:08:03 -07:00
third_party "NULL !=" = NULL 2014-09-05 13:34:00 -07:00
tools Add back page_sets/skia_googlespreadsheet_desktop 2014-10-22 06:19:51 -07:00
trybots_to_run/chrome Deleting the hardcoded list of compile bots in trybots_to_run. 2013-04-09 11:59:42 +00:00
.gitignore Add recreate_skps script 2014-10-17 07:37:05 -07:00
AUTHORS Improve SkARGB32_A8_BlitMask_SSE2 2014-10-09 11:43:02 -07:00
codereview.settings Add Project to skia 2014-06-20 09:39:15 -07:00
CONTRIBUTING Add CONTRIBUTING file 2014-01-13 15:06:26 +00:00
CQ_COMMITTERS Adding myself to comitters 2014-09-16 11:03:39 -07:00
DEPS Add recreate_skps script 2014-10-17 07:37:05 -07:00
Doxyfile Fix links to skia-buildbot code in preparation for deletion 2014-10-14 04:44:44 -07:00
gyp_skia allow caller to override the default output directory for gyp 2014-09-29 11:42:25 -07:00
gyp_skia.py Roll gyp deps from 1765 to 1796. 2013-11-21 18:11:14 +00:00
LICENSE Manually update copyright notices in files that defied the automated process 2011-07-28 14:24:55 +00:00
make.bat Link to skiadocs site, since that is the canonical location for documentation. 2014-10-13 17:56:30 -03:00
make.py Fix reference to non-existant 'tests' target. 2014-10-13 17:51:57 -03:00
Makefile Update LSAN suppressions. 2014-08-29 07:55:35 -07:00
OWNERS add root files from chrome 2013-08-13 19:11:15 +00:00
PRESUBMIT.py PRESUBMIT should only check owners for the top level include directory 2014-08-26 14:00:55 -07:00
README Point to skiadocs in our README. 2014-05-09 04:30:09 +00:00
README.chromium add root files from chrome 2013-08-13 19:11:15 +00:00
skia.gyp Remove the comments settings for vim tab width and expansion variables. 2013-12-02 22:23:03 +00:00
SKP_VERSION Update SKP version 2014-10-17 15:00:23 -07:00
whitespace.txt Whitespace change to verify lab machines can now sync 2014-10-16 08:37:31 -07:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at https://sites.google.com/site/skiadocs/home