a1121331a4
I will follow this up with a Chrome-side CL to fix the call sites of the following factories: MakeFromCompressedTexture MakeFromTexture MakeFromYUVATexturesCopyWithExternalBackend MakeFromYUVTexturesCopyWithExternalBackend MakeFromNV12TexturesCopyWithExternalBackend Here is the Chrome-side CL: https://chromium-review.googlesource.com/c/chromium/src/+/2264598/ (Skia's SkImage::Make* factories now guarantee cleanup) Here is the Chrome-side CL that adds the guard flag: https://chromium-review.googlesource.com/c/chromium/src/+/2273067/ (Add flag in order to roll a Skia CL into Chrome) TBR=bsalomon@google.com Bug: 1097484 Change-Id: Ic2fcdc116f0f866b33d752b6d5abc784c7f65be6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299663 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
172 lines
7.3 KiB
C++
172 lines
7.3 KiB
C++
/*
|
|
* Copyright 2016 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
// This is a GPU-backend specific test.
|
|
|
|
#include "tests/Test.h"
|
|
|
|
#include "include/gpu/GrBackendSurface.h"
|
|
#include "src/gpu/GrContextPriv.h"
|
|
#include "src/gpu/GrGpu.h"
|
|
#include "src/gpu/GrProxyProvider.h"
|
|
#include "src/gpu/GrRenderTarget.h"
|
|
#include "src/gpu/GrRenderTargetProxy.h"
|
|
#include "src/gpu/GrSurfaceProxy.h"
|
|
#include "src/gpu/GrTexture.h"
|
|
#include "src/gpu/GrTextureProxy.h"
|
|
|
|
static sk_sp<GrSurfaceProxy> make_wrapped_rt(GrProxyProvider* provider,
|
|
GrGpu* gpu,
|
|
skiatest::Reporter* reporter,
|
|
const SkISize& size,
|
|
GrColorType colorType) {
|
|
auto backendRT =
|
|
gpu->createTestingOnlyBackendRenderTarget(size.width(), size.height(), colorType);
|
|
return provider->wrapBackendRenderTarget(backendRT, nullptr);
|
|
}
|
|
|
|
void clean_up_wrapped_rt(GrGpu* gpu, sk_sp<GrSurfaceProxy> proxy) {
|
|
SkASSERT(proxy->unique());
|
|
SkASSERT(proxy->peekRenderTarget());
|
|
GrBackendRenderTarget rt = proxy->peekRenderTarget()->getBackendRenderTarget();
|
|
proxy.reset();
|
|
gpu->deleteTestingOnlyBackendRenderTarget(rt);
|
|
}
|
|
|
|
static sk_sp<GrSurfaceProxy> make_offscreen_rt(GrProxyProvider* provider,
|
|
SkISize dimensions,
|
|
GrColorType colorType) {
|
|
return provider->testingOnly_createInstantiatedProxy(dimensions, colorType, GrRenderable::kYes,
|
|
1, SkBackingFit::kExact, SkBudgeted::kYes,
|
|
GrProtected::kNo);
|
|
}
|
|
|
|
static sk_sp<GrSurfaceProxy> make_texture(GrProxyProvider* provider,
|
|
SkISize dimensions,
|
|
GrColorType colorType,
|
|
GrRenderable renderable) {
|
|
return provider->testingOnly_createInstantiatedProxy(dimensions, colorType, renderable, 1,
|
|
SkBackingFit::kExact, SkBudgeted::kYes,
|
|
GrProtected::kNo);
|
|
}
|
|
|
|
// Test converting between RenderTargetProxies and TextureProxies for preinstantiated Proxies
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(PreinstantiatedProxyConversionTest, reporter, ctxInfo) {
|
|
GrProxyProvider* proxyProvider = ctxInfo.grContext()->priv().proxyProvider();
|
|
GrGpu* gpu = ctxInfo.grContext()->priv().getGpu();
|
|
|
|
static constexpr auto kSize = SkISize::Make(64, 64);
|
|
static constexpr auto kColorType = GrColorType::kRGBA_8888;
|
|
|
|
{
|
|
// External on-screen render target.
|
|
sk_sp<GrSurfaceProxy> sProxy(
|
|
make_wrapped_rt(proxyProvider, gpu, reporter, kSize, kColorType));
|
|
if (sProxy) {
|
|
// RenderTarget-only
|
|
GrRenderTargetProxy* rtProxy = sProxy->asRenderTargetProxy();
|
|
REPORTER_ASSERT(reporter, rtProxy);
|
|
REPORTER_ASSERT(reporter, !rtProxy->asTextureProxy());
|
|
REPORTER_ASSERT(reporter, rtProxy->asRenderTargetProxy() == rtProxy);
|
|
clean_up_wrapped_rt(gpu, std::move(sProxy));
|
|
}
|
|
}
|
|
|
|
{
|
|
// Internal offscreen render target.
|
|
sk_sp<GrSurfaceProxy> sProxy(make_offscreen_rt(proxyProvider, kSize, kColorType));
|
|
if (sProxy) {
|
|
// Both RenderTarget and Texture
|
|
GrRenderTargetProxy* rtProxy = sProxy->asRenderTargetProxy();
|
|
REPORTER_ASSERT(reporter, rtProxy);
|
|
GrTextureProxy* tProxy = rtProxy->asTextureProxy();
|
|
REPORTER_ASSERT(reporter, tProxy);
|
|
REPORTER_ASSERT(reporter, tProxy->asRenderTargetProxy() == rtProxy);
|
|
REPORTER_ASSERT(reporter, rtProxy->asRenderTargetProxy() == rtProxy);
|
|
}
|
|
}
|
|
|
|
{
|
|
// Internal offscreen render target - but through GrTextureProxy
|
|
sk_sp<GrSurfaceProxy> sProxy(
|
|
make_texture(proxyProvider, kSize, kColorType, GrRenderable::kYes));
|
|
if (sProxy) {
|
|
// Both RenderTarget and Texture
|
|
GrTextureProxy* tProxy = sProxy->asTextureProxy();
|
|
REPORTER_ASSERT(reporter, tProxy);
|
|
GrRenderTargetProxy* rtProxy = tProxy->asRenderTargetProxy();
|
|
REPORTER_ASSERT(reporter, rtProxy);
|
|
REPORTER_ASSERT(reporter, rtProxy->asTextureProxy() == tProxy);
|
|
REPORTER_ASSERT(reporter, tProxy->asTextureProxy() == tProxy);
|
|
}
|
|
}
|
|
|
|
{
|
|
// force no-RT
|
|
sk_sp<GrSurfaceProxy> sProxy(
|
|
make_texture(proxyProvider, kSize, kColorType, GrRenderable::kNo));
|
|
if (sProxy) {
|
|
// Texture-only
|
|
GrTextureProxy* tProxy = sProxy->asTextureProxy();
|
|
REPORTER_ASSERT(reporter, tProxy);
|
|
REPORTER_ASSERT(reporter, tProxy->asTextureProxy() == tProxy);
|
|
REPORTER_ASSERT(reporter, !tProxy->asRenderTargetProxy());
|
|
}
|
|
}
|
|
}
|
|
|
|
// Test converting between RenderTargetProxies and TextureProxies for deferred
|
|
// Proxies
|
|
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(DefferredProxyConversionTest, reporter, ctxInfo) {
|
|
GrContext* context = ctxInfo.grContext();
|
|
GrProxyProvider* proxyProvider = context->priv().proxyProvider();
|
|
const GrCaps* caps = context->priv().caps();
|
|
|
|
static constexpr SkISize kDims = {64, 64};
|
|
|
|
const GrBackendFormat format = caps->getDefaultBackendFormat(GrColorType::kRGBA_8888,
|
|
GrRenderable::kYes);
|
|
{
|
|
sk_sp<GrTextureProxy> proxy = proxyProvider->createProxy(
|
|
format, kDims, GrRenderable::kYes, 1, GrMipMapped::kNo, SkBackingFit::kApprox,
|
|
SkBudgeted::kYes, GrProtected::kNo);
|
|
|
|
// Both RenderTarget and Texture
|
|
GrRenderTargetProxy* rtProxy = proxy->asRenderTargetProxy();
|
|
REPORTER_ASSERT(reporter, rtProxy);
|
|
GrTextureProxy* tProxy = rtProxy->asTextureProxy();
|
|
REPORTER_ASSERT(reporter, tProxy);
|
|
REPORTER_ASSERT(reporter, tProxy->asRenderTargetProxy() == rtProxy);
|
|
REPORTER_ASSERT(reporter, rtProxy->asRenderTargetProxy() == rtProxy);
|
|
}
|
|
|
|
{
|
|
sk_sp<GrTextureProxy> proxy = proxyProvider->createProxy(
|
|
format, kDims, GrRenderable::kYes, 1, GrMipMapped::kNo, SkBackingFit::kApprox,
|
|
SkBudgeted::kYes, GrProtected::kNo);
|
|
|
|
// Both RenderTarget and Texture - but via GrTextureProxy
|
|
GrTextureProxy* tProxy = proxy->asTextureProxy();
|
|
REPORTER_ASSERT(reporter, tProxy);
|
|
GrRenderTargetProxy* rtProxy = tProxy->asRenderTargetProxy();
|
|
REPORTER_ASSERT(reporter, rtProxy);
|
|
REPORTER_ASSERT(reporter, rtProxy->asTextureProxy() == tProxy);
|
|
REPORTER_ASSERT(reporter, tProxy->asTextureProxy() == tProxy);
|
|
}
|
|
|
|
{
|
|
sk_sp<GrTextureProxy> proxy = proxyProvider->createProxy(
|
|
format, kDims, GrRenderable::kNo, 1, GrMipMapped::kNo, SkBackingFit::kApprox,
|
|
SkBudgeted::kYes, GrProtected::kNo);
|
|
// Texture-only
|
|
GrTextureProxy* tProxy = proxy->asTextureProxy();
|
|
REPORTER_ASSERT(reporter, tProxy);
|
|
REPORTER_ASSERT(reporter, tProxy->asTextureProxy() == tProxy);
|
|
REPORTER_ASSERT(reporter, !tProxy->asRenderTargetProxy());
|
|
}
|
|
}
|