afd2c10c98
We used to rely solely on visual bounds for vertical alignment. That had the downside of leading/trailing empty lines being ignored. Then https://skia-review.googlesource.com/c/skia/+/220916 switched to using typographical bounds. This approach produces results in line with AE, but allows some glyphs to overflow the alignment boundary. This CL introduces a hybrid approach: 1) for standard AE text alignment, continue to use typographical bounds 2) for Skottie VAlign extensions (sk_vj), use the union of typographical and visual bounds - this should mitigate both issues mentioned above Change-Id: Ifd3ccae3d721728ce67942206160ebe92056d3a2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224188 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Avinash Parchuri <aparchur@google.com> |
||
---|---|---|
.. | ||
android_fonts | ||
empty_images | ||
fonts | ||
icc_profiles | ||
images | ||
invalid_images | ||
lua | ||
nima | ||
particles | ||
skottie | ||
text | ||
Cowboy.svg | ||
crbug769134.fil | ||
nov-talk-sequence.txt | ||
pdf_command_stream.txt | ||
README | ||
SkVMTest.expected |
The resources directory includes some third party content used by Skia. Licenses for that code are included in this file. Openclipart Openclipart uses the Creative Commons Zero 1.0 Public Domain License every time an artist uploads a piece of clipart to Openclipart to make it clear the artist is releasing the creative work for anyone to use for any reason, even commercially. This act of "sharing" is the foundation Openclipart is based upon. More details on the license can be found at https://creativecommons.org/publicdomain/zero/1.0/. LGPL or compatible (as implied by inclusion in KDE SVN) http://websvn.kde.org/trunk/tests/ksvgtests/custom/cowboy.svg