3674336c33
This is a reland of 166dbd3135
Since last attempt,
- update SkPath::Direction docs
- kIllegal is not an advanced blend mode
Original change's description:
> make enum santizer fatal
>
> This enum sanitizer checks that all the values of the enum we use fall
> within the range of the enumerated values.
>
> The main thing this helps point out is that the size of enum types in
> C++ need only be large enough to hold the largest declared value; larger
> values are undefined. In practice, most enums are implemented as ints
> for compatibility with C, so while this hasn't pointed out anything
> egregiously broken, the sanitizer has found a couple possibly dangerous
> situations in our codebase.
>
> For most types using values outside the enum range, we can just
> explicitly size them to int. This makes their de facto size de jure.
>
> But we need to actually make GrBlendEquation and GrBlendCoeff not store
> values outside their enumerated range. They're packed into bitfields
> that really can't represent those (negative) values. So for these I've
> added new kIllegal values to the enums, forcing us to deal with our
> once-silent illegal values a bit more explicitly.
>
> Change-Id: Ib617694cf1aaa83ae99289e9e760f49cb6393a2f
> Reviewed-on: https://skia-review.googlesource.com/c/168484
> Reviewed-by: Brian Osman <brianosman@google.com>
Cq-Include-Trybots: skia.primary:Housekeeper-PerCommit-Bookmaker,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-All-Android
Change-Id: Id93b80bbeae11872542c9b76715e3c3cb10609fd
Reviewed-on: https://skia-review.googlesource.com/c/168582
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
152 lines
5.4 KiB
C
152 lines
5.4 KiB
C
|
|
/*
|
|
* Copyright 2013 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#ifndef GrBlend_DEFINED
|
|
#define GrBlend_DEFINED
|
|
|
|
#include "SkTypes.h"
|
|
|
|
/**
|
|
* Equations for alpha-blending.
|
|
*/
|
|
enum GrBlendEquation {
|
|
// Basic blend equations.
|
|
kAdd_GrBlendEquation, //<! Cs*S + Cd*D
|
|
kSubtract_GrBlendEquation, //<! Cs*S - Cd*D
|
|
kReverseSubtract_GrBlendEquation, //<! Cd*D - Cs*S
|
|
|
|
// Advanced blend equations. These are described in the SVG and PDF specs.
|
|
kScreen_GrBlendEquation,
|
|
kOverlay_GrBlendEquation,
|
|
kDarken_GrBlendEquation,
|
|
kLighten_GrBlendEquation,
|
|
kColorDodge_GrBlendEquation,
|
|
kColorBurn_GrBlendEquation,
|
|
kHardLight_GrBlendEquation,
|
|
kSoftLight_GrBlendEquation,
|
|
kDifference_GrBlendEquation,
|
|
kExclusion_GrBlendEquation,
|
|
kMultiply_GrBlendEquation,
|
|
kHSLHue_GrBlendEquation,
|
|
kHSLSaturation_GrBlendEquation,
|
|
kHSLColor_GrBlendEquation,
|
|
kHSLLuminosity_GrBlendEquation,
|
|
|
|
kIllegal_GrBlendEquation,
|
|
|
|
kFirstAdvancedGrBlendEquation = kScreen_GrBlendEquation,
|
|
kLast_GrBlendEquation = kIllegal_GrBlendEquation,
|
|
};
|
|
|
|
static const int kGrBlendEquationCnt = kLast_GrBlendEquation + 1;
|
|
|
|
|
|
/**
|
|
* Coefficients for alpha-blending.
|
|
*/
|
|
enum GrBlendCoeff {
|
|
kZero_GrBlendCoeff, //<! 0
|
|
kOne_GrBlendCoeff, //<! 1
|
|
kSC_GrBlendCoeff, //<! src color
|
|
kISC_GrBlendCoeff, //<! one minus src color
|
|
kDC_GrBlendCoeff, //<! dst color
|
|
kIDC_GrBlendCoeff, //<! one minus dst color
|
|
kSA_GrBlendCoeff, //<! src alpha
|
|
kISA_GrBlendCoeff, //<! one minus src alpha
|
|
kDA_GrBlendCoeff, //<! dst alpha
|
|
kIDA_GrBlendCoeff, //<! one minus dst alpha
|
|
kConstC_GrBlendCoeff, //<! constant color
|
|
kIConstC_GrBlendCoeff, //<! one minus constant color
|
|
kConstA_GrBlendCoeff, //<! constant color alpha
|
|
kIConstA_GrBlendCoeff, //<! one minus constant color alpha
|
|
kS2C_GrBlendCoeff,
|
|
kIS2C_GrBlendCoeff,
|
|
kS2A_GrBlendCoeff,
|
|
kIS2A_GrBlendCoeff,
|
|
|
|
kIllegal_GrBlendCoeff,
|
|
|
|
kLast_GrBlendCoeff = kIllegal_GrBlendCoeff,
|
|
};
|
|
|
|
static const int kGrBlendCoeffCnt = kLast_GrBlendCoeff + 1;
|
|
|
|
static constexpr bool GrBlendCoeffRefsSrc(const GrBlendCoeff coeff) {
|
|
return kSC_GrBlendCoeff == coeff || kISC_GrBlendCoeff == coeff || kSA_GrBlendCoeff == coeff ||
|
|
kISA_GrBlendCoeff == coeff;
|
|
}
|
|
|
|
static constexpr bool GrBlendCoeffRefsDst(const GrBlendCoeff coeff) {
|
|
return kDC_GrBlendCoeff == coeff || kIDC_GrBlendCoeff == coeff || kDA_GrBlendCoeff == coeff ||
|
|
kIDA_GrBlendCoeff == coeff;
|
|
}
|
|
|
|
static constexpr bool GrBlendCoeffRefsSrc2(const GrBlendCoeff coeff) {
|
|
return kS2C_GrBlendCoeff == coeff || kIS2C_GrBlendCoeff == coeff ||
|
|
kS2A_GrBlendCoeff == coeff || kIS2A_GrBlendCoeff == coeff;
|
|
}
|
|
|
|
static constexpr bool GrBlendCoeffsUseSrcColor(GrBlendCoeff srcCoeff, GrBlendCoeff dstCoeff) {
|
|
return kZero_GrBlendCoeff != srcCoeff || GrBlendCoeffRefsSrc(dstCoeff);
|
|
}
|
|
|
|
static constexpr bool GrBlendCoeffsUseDstColor(GrBlendCoeff srcCoeff, GrBlendCoeff dstCoeff) {
|
|
return GrBlendCoeffRefsDst(srcCoeff) || kZero_GrBlendCoeff != dstCoeff;
|
|
}
|
|
|
|
static constexpr bool GrBlendEquationIsAdvanced(GrBlendEquation equation) {
|
|
return equation >= kFirstAdvancedGrBlendEquation
|
|
&& equation != kIllegal_GrBlendEquation;
|
|
}
|
|
|
|
static constexpr bool GrBlendModifiesDst(GrBlendEquation equation, GrBlendCoeff srcCoeff,
|
|
GrBlendCoeff dstCoeff) {
|
|
return (kAdd_GrBlendEquation != equation && kReverseSubtract_GrBlendEquation != equation) ||
|
|
kZero_GrBlendCoeff != srcCoeff || kOne_GrBlendCoeff != dstCoeff;
|
|
}
|
|
|
|
/**
|
|
* Advanced blend equations can always tweak alpha for coverage. (See GrCustomXfermode.cpp)
|
|
*
|
|
* For "add" and "reverse subtract" the blend equation with f=coverage is:
|
|
*
|
|
* D' = f * (S * srcCoeff + D * dstCoeff) + (1-f) * D
|
|
* = f * S * srcCoeff + D * (f * dstCoeff + (1 - f))
|
|
*
|
|
* (Let srcCoeff be negative for reverse subtract.) We can tweak alpha for coverage when the
|
|
* following relationship holds:
|
|
*
|
|
* (f*S) * srcCoeff' + D * dstCoeff' == f * S * srcCoeff + D * (f * dstCoeff + (1 - f))
|
|
*
|
|
* (Where srcCoeff' and dstCoeff' have any reference to S pre-multiplied by f.)
|
|
*
|
|
* It's easy to see this works for the src term as long as srcCoeff' == srcCoeff (meaning srcCoeff
|
|
* does not reference S). For the dst term, this will work as long as the following is true:
|
|
*|
|
|
* dstCoeff' == f * dstCoeff + (1 - f)
|
|
* dstCoeff' == 1 - f * (1 - dstCoeff)
|
|
*
|
|
* By inspection we can see this will work as long as dstCoeff has a 1, and any other term in
|
|
* dstCoeff references S.
|
|
*
|
|
* Moreover, if the blend doesn't modify the dst at all then it is ok to arbitrarily modify the src
|
|
* color so folding in coverage is allowed.
|
|
*/
|
|
static constexpr bool GrBlendAllowsCoverageAsAlpha(GrBlendEquation equation,
|
|
GrBlendCoeff srcCoeff,
|
|
GrBlendCoeff dstCoeff) {
|
|
return GrBlendEquationIsAdvanced(equation) ||
|
|
!GrBlendModifiesDst(equation, srcCoeff, dstCoeff) ||
|
|
((kAdd_GrBlendEquation == equation || kReverseSubtract_GrBlendEquation == equation) &&
|
|
!GrBlendCoeffRefsSrc(srcCoeff) &&
|
|
(kOne_GrBlendCoeff == dstCoeff || kISC_GrBlendCoeff == dstCoeff ||
|
|
kISA_GrBlendCoeff == dstCoeff));
|
|
}
|
|
|
|
#endif
|