Florin Malita 42725ae301 Reland "[skottie] Simplify effect builder lookup" ... This reverts commit 187cd367d3. Reason for revert: relanding with legacy enum support Original change's description: > Revert "[skottie] Simplify effect builder lookup" > > This reverts commit ef363a9ce6. > > Reason for revert: G3 unit tests failing > > Original change's description: > > [skottie] Simplify effect builder lookup > > > > Layer effects fall into two categories: > > > > - effects that BM knows about: these get assigned a unique type enum > > - effects that BM doesn't know about: these are still exported, but > > get assigned a dummy type > > > > To handle effects in the latter case, we rely on their canonical AE > > name. > > > > The list of supported effects has grown to the point where a) this > > differentiation doesn't seem valuable anymore and b) the code is quite > > repetitive. > > > > Consoliate the lookup logic to rely solely on effect names + bsearch > > table. > > > > Change-Id: Ib5f9b064a373814865da9e8a26037209992e8b9b > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/259997 > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > Reviewed-by: Mike Reed <reed@google.com> > > Reviewed-by: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com > > Change-Id: I3b4c681c260c121e422ade7395c33a77e788ff43 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260196 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Florin Malita <fmalita@chromium.org> TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2a4360dc8216b8b45e20c6568c0a1d3d069aa56c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260280 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>		2019-12-16 19:56:22 +00:00
..
canvaskit	remove use_PIC.	2019-12-16 16:56:10 +00:00
particles	use std::make_unique	2019-12-12 22:32:45 +00:00
pathkit	remove dead code around old SkPath enums	2019-12-14 01:58:10 +00:00
skottie	Reland "[skottie] Simplify effect builder lookup"	2019-12-16 19:56:22 +00:00
skparagraph	use std::make_unique	2019-12-12 22:32:45 +00:00
skplaintexteditor	tools/skui: put all enums in a common namespace	2019-08-29 15:39:32 +00:00
skresources	use std::make_unique	2019-12-12 22:32:45 +00:00
sksg	remove dead code around old SkPath enums	2019-12-14 01:58:10 +00:00
skshaper	use std::make_unique	2019-12-12 22:32:45 +00:00