AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4511c7b7fb
skia2/tools
History
Kevin Lubick 4511c7b7fb [bazel] Delete gazelle-based BUILD.bazel files 
gazelle ended up being more liability than asset for our C++ rules.

It required devs to manually run the command frequently (and was
easy to forget until the CQ failed). The fact that we still had to
edit the source files (e.g. the "srcs" cc_libraries) meant that
the mixture between generated and hand-written caused some
tension (see include/third_party/vulkan for a good example).

The combination of gazelle and our IWYU enforcement added several
bits of churn without any real benefit. The generated rules
also didn't help identify cases where we were not keeping tight
boundaries (e.g. non-gpu code and gpu code).

Identifying third_party deps automatically ended up being trickier
than anticipated (see the deleted //third_party/file_map_for_bazel.json)

Using the "maximum set of dependencies" worked ok, but ended up
increasing build time unnecessarily. For example, compiling
CanvasKit for WebGL always needed to compile Dawn because
SkSLCompiler.cpp sometimes needs to include tint/tint.h.

Follow-up CLs will rebuild the BUILD.bazel rules without gazelle.

Note to Reviewers:
 - The only file worth manually reviewing here is bazel/Makefile.

Change-Id: I36d6fc3747487fabaf699690780c95f1f6765770
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/543976
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-05-31 14:14:54 +00:00
..
android Reland "[infra] Remove old python scripts and urllib2 references" 2022-05-16 20:15:49 +00:00
calmbench
copyright
debugger [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
doxygen Fix doxygen README.md to use python3. 2022-03-04 14:21:35 +00:00
fiddle [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
flags [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
fm [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
fonts [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
gdb
gpu [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
graphite [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
infra
lottie-web-perf
lottiecap
malisc
perf-canvaskit-puppeteer [canvaskit] Remove deprecated MakeTypefaceFromData and RefDefault 2021-10-21 16:45:42 +00:00
run-wasm-gm-tests [infra] Fix timeouts on WebGL GMs+Unit Tests 2022-03-22 12:42:33 +00:00
sk_app [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
skdiff [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
skiaserve [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
skottie_ios_app [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
skottie-wasm-perf
skp Add skia_motionmarksuites_desktop.py 2021-07-29 19:16:05 +00:00
skpbench [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
skqp [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
sksl-precompile [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
skslc [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
skui [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
svg
timer [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
trace [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
viewer [bazel] Delete gazelle-based BUILD.bazel files 2022-05-31 14:14:54 +00:00
__init__.py
abandon_gerrit_cls.py
add_codereview_message.py
AndroidSkDebugToStdOut.cpp
AutoreleasePool.h
AutoreleasePool.mm
bloaty_treemap.py bloaty_treemap.py: Fix path/symbol name collisions; make symbols unique with _1, _2, ... instead of _x, _x_x, ... 2021-12-01 21:38:55 +00:00
blob_cache_sim.cpp move SkRemoteGlyphCache.h to private 2021-12-10 20:20:56 +00:00
BUILD_simulator.py
build_workaround_header.py Correct a typo in build_workaround_header.py 2021-07-29 13:06:01 +00:00
check-headers-self-sufficient Update Sk4px to use skvx instead of SkNx 2022-05-23 17:41:53 +00:00
chrome_fuzz.cpp
clang-tidy.sh
convert-to-nia.cpp Fix convert-to-NIA stillImage check 2021-11-24 16:45:43 +00:00
cpu_modules.cpp
CrashHandler.cpp Reland "Add format-specifier warnings to SkDebugf." 2021-06-25 17:57:43 +00:00
CrashHandler.h
DDLPromiseImageHelper.cpp mipMapped -> mipmapped 2022-04-18 14:26:19 +00:00
DDLPromiseImageHelper.h mipMapped -> mipmapped 2022-04-18 14:26:19 +00:00
DDLTileHelper.cpp Finish GrMipMapped->GrMipmapped 2022-04-15 15:43:52 +00:00
DDLTileHelper.h
doxygen_footer.txt
dump_record.cpp Fix cases of variable shadowing in /tools/. 2021-08-11 16:05:52 +00:00
embed_resources.py
find_run_binary.py
fix_pythonpath.py
force_older_glibc_math.h
gcov_shim
get_current_monitor_profile.cpp Convert 0 and NULL to nullptr. 2022-02-09 14:20:57 +00:00
get_images_from_skps.cpp
git-sync-deps Remove obsolete python2 references. 2022-03-16 19:56:37 +00:00
HashAndEncode.cpp [includes] Prepare for moving SkColorSpace to forward declare 2022-03-31 19:50:10 +00:00
HashAndEncode.h
image_diff_metric.cpp
imgcvt.cpp
install_dependencies.sh
ios_utils.h
ios_utils.m
list_gms.cpp
list_gpu_unit_tests.cpp Add CurrestTestHarness helper method. 2022-03-10 18:05:28 +00:00
LsanSuppressions.cpp
merge_static_libs.py
milestone.py
mirror-dev.sh
misc_utils.py
MSKPPlayer.cpp Move canvas helper structs to header 2021-08-10 17:53:16 +00:00
MSKPPlayer.h Move canvas helper structs to header 2021-08-10 17:53:16 +00:00
OverwriteLine.h
parse_llvm_coverage.py
pathops_sorter.htm
pathops_visualizer.htm
ProcStats.cpp Convert 0 and NULL to nullptr. 2022-02-09 14:20:57 +00:00
ProcStats.h
public_headers_warnings_check.cpp
random_parse_path.cpp Fix cases of variable shadowing in /tools/. 2021-08-11 16:05:52 +00:00
random_parse_path.h
reformat-json.py
Registry.h Remove obsolete double-initialization check. 2022-03-08 16:01:48 +00:00
remote_demo.cpp [includes] Prepare for moving SkColorSpace to forward declare 2022-03-31 19:50:10 +00:00
ResourceFactory.h
Resources.cpp Revert "create ParticleDrawable for animated Skotties" 2022-05-11 23:35:08 +00:00
Resources.h Revert "create ParticleDrawable for animated Skotties" 2022-05-11 23:35:08 +00:00
rewrite_includes.py Reland "[infra] Use Python3 for our Presubmits" 2022-05-06 14:01:35 +00:00
RuntimeBlendUtils.cpp [bazel] Compile gms for wasm and WebGL 2022-02-09 18:56:17 +00:00
RuntimeBlendUtils.h Simplify GetRuntimeBlendForBlendMode. 2021-07-30 16:42:36 +00:00
sanitize_source_files.py
serve_wasm.py [infra] Deduplicate serve.py 2021-10-12 11:42:50 +00:00
SkMetaData.cpp
SkMetaData.h
skottie2movie.cpp Fix skottie2movie gpu async crash 2021-09-11 15:49:19 +00:00
skp_parser.cpp [includes] Enforce IWYU for //tools/debugger/... 2022-03-30 13:53:13 +00:00
skpinfo.cpp Print out picture version even if its unsupported 2021-07-20 00:11:39 +00:00
SkSharingProc.cpp Reland "[includes] Remove link between SkImage.h and SkImageEncoder.h" 2022-03-10 04:47:51 +00:00
SkSharingProc.h
Stats.h
test_all.py
test_pdfs.py
ToolUtils.cpp Guard GPU parts of ToolUtils 2022-04-25 19:30:42 +00:00
ToolUtils.h Guard GPU parts of ToolUtils 2022-04-25 19:30:42 +00:00
UrlDataManager.cpp
UrlDataManager.h
using_skia_and_harfbuzz.cpp Remove unnecessary ctors now that we have C++17 copy-elision. 2022-01-27 20:26:54 +00:00
valgrind.supp Use updated GPU driver version for GOLO bots 2022-04-01 18:01:23 +00:00
win_dbghelp.cpp
win_dbghelp.h
win_lcid.cpp
xsan.supp