dbfd7ab108
'static const' means, there must be at most one of these, and initialize it at compile time if possible or runtime if necessary. This leads to unexpected code execution, and TSAN* will complain about races on the guard variables. Generally 'constexpr' or 'const' are better choices. Neither can cause races: they're either intialized at compile time (constexpr) or intialized each time independently (const). This CL prefers constexpr where possible, and uses const where not. It even prefers constexpr over const where they don't make a difference... I want to have lots of examples of constexpr for people to see and mimic. The scoped-to-class static has nothing to do with any of this, and is not changed. * Not yet on the bots, which use an older TSAN. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005 Review-Url: https://codereview.chromium.org/2300623005
78 lines
2.2 KiB
C++
78 lines
2.2 KiB
C++
/*
|
|
* Copyright 2015 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "gm.h"
|
|
|
|
#include "SkCanvas.h"
|
|
#include "SkSurface.h"
|
|
#include "SkTextBlob.h"
|
|
|
|
// This tests that we don't try to reuse textblobs from the GPU textblob cache across pixel geometry
|
|
// changes when we have LCD. crbug/486744
|
|
namespace skiagm {
|
|
class TextBlobGeometryChange : public GM {
|
|
public:
|
|
TextBlobGeometryChange() { }
|
|
|
|
protected:
|
|
SkString onShortName() override {
|
|
return SkString("textblobgeometrychange");
|
|
}
|
|
|
|
SkISize onISize() override {
|
|
return SkISize::Make(kWidth, kHeight);
|
|
}
|
|
|
|
void onDraw(SkCanvas* canvas) override {
|
|
const char text[] = "Hamburgefons";
|
|
|
|
SkPaint paint;
|
|
sk_tool_utils::set_portable_typeface(&paint);
|
|
paint.setTextSize(20);
|
|
paint.setAntiAlias(true);
|
|
paint.setLCDRenderText(true);
|
|
|
|
SkTextBlobBuilder builder;
|
|
|
|
sk_tool_utils::add_to_text_blob(&builder, text, paint, 10, 10);
|
|
|
|
SkAutoTUnref<const SkTextBlob> blob(builder.build());
|
|
|
|
SkImageInfo info = SkImageInfo::MakeN32Premul(200, 200);
|
|
SkSurfaceProps props(0, kUnknown_SkPixelGeometry);
|
|
auto surface = canvas->makeSurface(info, &props);
|
|
if (!surface) {
|
|
surface = SkSurface::MakeRaster(info, &props);
|
|
}
|
|
SkCanvas* c = surface->getCanvas();
|
|
|
|
// LCD text on white background
|
|
SkRect rect = SkRect::MakeLTRB(0.f, 0.f, SkIntToScalar(kWidth), kHeight / 2.f);
|
|
SkPaint rectPaint;
|
|
rectPaint.setColor(0xffffffff);
|
|
canvas->drawRect(rect, rectPaint);
|
|
canvas->drawTextBlob(blob.get(), 10, 50, paint);
|
|
|
|
// This should not look garbled since we should disable LCD text in this case
|
|
// (i.e., unknown pixel geometry)
|
|
c->clear(0x00ffffff);
|
|
c->drawTextBlob(blob.get(), 10, 150, paint);
|
|
surface->draw(canvas, 0, 0, nullptr);
|
|
}
|
|
|
|
private:
|
|
static constexpr int kWidth = 200;
|
|
static constexpr int kHeight = 200;
|
|
|
|
typedef GM INHERITED;
|
|
};
|
|
|
|
//////////////////////////////////////////////////////////////////////////////
|
|
|
|
DEF_GM(return new TextBlobGeometryChange;)
|
|
}
|