dbfd7ab108
'static const' means, there must be at most one of these, and initialize it at compile time if possible or runtime if necessary. This leads to unexpected code execution, and TSAN* will complain about races on the guard variables. Generally 'constexpr' or 'const' are better choices. Neither can cause races: they're either intialized at compile time (constexpr) or intialized each time independently (const). This CL prefers constexpr where possible, and uses const where not. It even prefers constexpr over const where they don't make a difference... I want to have lots of examples of constexpr for people to see and mimic. The scoped-to-class static has nothing to do with any of this, and is not changed. * Not yet on the bots, which use an older TSAN. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005 Review-Url: https://codereview.chromium.org/2300623005
76 lines
1.9 KiB
C++
76 lines
1.9 KiB
C++
/*
|
|
* Copyright 2015 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "gm.h"
|
|
|
|
#if SK_SUPPORT_GPU
|
|
|
|
#include "SkCanvas.h"
|
|
#include "SkSurface.h"
|
|
#include "SkTextBlob.h"
|
|
#include "GrContext.h"
|
|
|
|
// This tests that we correctly regenerate textblobs after freeing all gpu resources crbug/491350
|
|
namespace skiagm {
|
|
class TextBlobUseAfterGpuFree : public GM {
|
|
public:
|
|
TextBlobUseAfterGpuFree() { }
|
|
|
|
protected:
|
|
SkString onShortName() override {
|
|
return SkString("textblobuseaftergpufree");
|
|
}
|
|
|
|
SkISize onISize() override {
|
|
return SkISize::Make(kWidth, kHeight);
|
|
}
|
|
|
|
void onDraw(SkCanvas* canvas) override {
|
|
// This GM exists to test a specific feature of the GPU backend.
|
|
if (nullptr == canvas->getGrContext()) {
|
|
skiagm::GM::DrawGpuOnlyMessage(canvas);
|
|
return;
|
|
}
|
|
|
|
const char text[] = "Hamburgefons";
|
|
|
|
SkPaint paint;
|
|
sk_tool_utils::set_portable_typeface(&paint);
|
|
paint.setAntiAlias(true);
|
|
paint.setTextSize(20);
|
|
|
|
SkTextBlobBuilder builder;
|
|
|
|
sk_tool_utils::add_to_text_blob(&builder, text, paint, 10, 10);
|
|
|
|
SkAutoTUnref<const SkTextBlob> blob(builder.build());
|
|
|
|
// draw textblob
|
|
SkRect rect = SkRect::MakeLTRB(0.f, 0.f, SkIntToScalar(kWidth), kHeight / 2.f);
|
|
SkPaint rectPaint;
|
|
rectPaint.setColor(0xffffffff);
|
|
canvas->drawRect(rect, rectPaint);
|
|
canvas->drawTextBlob(blob.get(), 10, 50, paint);
|
|
|
|
// This text should look fine
|
|
canvas->getGrContext()->freeGpuResources();
|
|
canvas->drawTextBlob(blob.get(), 10, 150, paint);
|
|
}
|
|
|
|
private:
|
|
static constexpr int kWidth = 200;
|
|
static constexpr int kHeight = 200;
|
|
|
|
typedef GM INHERITED;
|
|
};
|
|
|
|
//////////////////////////////////////////////////////////////////////////////
|
|
|
|
DEF_GM(return new TextBlobUseAfterGpuFree;)
|
|
}
|
|
#endif
|