AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
497cda3a6b
skia2/include/effects
History
senorblanco 9ea3d57fde Clean up SkImageFilter constructors. 
Now that all creation of SkImageFilters goes through
factory Create() methods, there's no real reason for the
convenience constructors. Some SkImageFilter subclasses
which actually have zero DAG-able inputs were passing NULL
to the superclass constructor. This actually means 1 input,
with a NULL value, not zero inputs. This becomes more
relevant for the upcoming cache infrastructure, where this
indicates that the filter will use its src input, where in
fact some of these filters do not (they are image generators
only).

Limiting SkImageFilter to a single constructor resolves this
ambiguity.

Along the way, I removed all of the default parameters to
the constructors, since the Create methods always call them
with the full argument list.

BUG=skia:
R=reed@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/376953003
2014-07-08 09:16:22 -07:00
..
Sk1DPathEffect.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
Sk2DPathEffect.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkAlphaThresholdFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkArithmeticMode.h Arithmetic mode now has the option of not validating the output color, which will allow multiple arithmetic operations to be done sequentially, without intermediate clamping. This is required for mimicking blink's current behavior. 2014-04-02 19:32:15 +00:00
SkAvoidXfermode.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkBitmapSource.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkBlurDrawLooper.h Remove legacy constructor for blur draw looper. 2014-05-20 14:53:32 +00:00
SkBlurImageFilter.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkBlurMaskFilter.h remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE 2014-05-31 21:47:03 +00:00
SkColorFilterImageFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkColorMatrix.h Revert of Revert "Serialization of SkPictureImageFilter" (https://codereview.chromium.org/153583007/) 2014-02-07 12:20:04 +00:00
SkColorMatrixFilter.h Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. 2014-07-08 06:52:35 -07:00
SkComposeImageFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkCornerPathEffect.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkDashPathEffect.h Move Dashing filterPath to a dashing utils file 2014-06-11 06:51:51 -07:00
SkDiscretePathEffect.h Randomize seed for SkDiscretePathEffect::filterPath() 2014-06-12 22:55:08 -07:00
SkDisplacementMapEffect.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkDrawExtraPathEffect.h Export effects classes with SK_API. 2012-10-12 14:41:39 +00:00
SkDropShadowImageFilter.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkEmbossMaskFilter.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkGradientShader.h Sanitizing source files in Housekeeper-Nightly 2014-05-23 03:03:34 +00:00
SkLayerDrawLooper.h add asAShadowBlur for android to drawlooper 2014-04-29 15:20:16 +00:00
SkLayerRasterizer.h Revert of remove guarded code - there are no more callers (https://codereview.chromium.org/343783002/) 2014-06-18 15:51:20 -07:00
SkLerpXfermode.h Allow toString capability to be toggled independent of developer mode. 2014-03-13 18:02:17 +00:00
SkLightingImageFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkLumaColorFilter.h Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. 2014-07-08 06:52:35 -07:00
SkMagnifierImageFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkMatrixConvolutionImageFilter.h Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. 2014-07-08 06:52:35 -07:00
SkMatrixImageFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkMergeImageFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkMorphologyImageFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkOffsetImageFilter.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkPaintFlagsDrawFilter.h change SkDrawFilter::filter to return a bool, where false means don't-draw 2012-11-26 20:26:54 +00:00
SkPerlinNoiseShader.h Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*. 2014-07-08 06:52:35 -07:00
SkPictureImageFilter.h Implement SkPictureImageFilter bounds computation. 2014-05-30 20:36:15 +00:00
SkPixelXorXfermode.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkPorterDuff.h Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning"" 2013-10-31 17:28:30 +00:00
SkRectShaderImageFilter.h Implement support for a Context parameter in image filters 2014-03-14 15:44:01 +00:00
SkStippleMaskFilter.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkTableColorFilter.h Result of running tools/sanitize_source_files.py (which was added in https://codereview.appspot.com/6465078/) 2012-08-23 18:09:54 +00:00
SkTableMaskFilter.h Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag. 2014-05-15 15:40:41 +00:00
SkTestImageFilters.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkTileImageFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00
SkTransparentShader.h Remove SkShader virtual method validContext 2014-05-05 18:39:18 +00:00
SkXfermodeImageFilter.h Clean up SkImageFilter constructors. 2014-07-08 09:16:22 -07:00