4b09de3c90
Instead of standing goroutines pulling from a work queue, just kick off individual goroutines. No need to write a scheduler on top of another scheduler. Local runs put this at the same wall time as before while saving a little user/sys CPU time. Bot runs typically took 25-50s before this change, and now 40s, 28s, and 29s, so the same there too. We can choose whether to handle re-runs on the same goroutine or kick off new ones. I've chosen here to run them on the same goroutine (see the commented /*go*/), mostly because the bots quickly exhaust their user process limits when the reruns are all spawning FM processes in parallel. I think that means we don't need the extra parallelism. As far as I have seen, whether we kick off a goroutine or not has had no impact on wall/user/sys at all, so might as well not for now. Change-Id: If2990e07a402dee8c5706f537f503421013a5586 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363376 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> |
||
|---|---|---|
| .. | ||
| bots | ||
| canvaskit | ||
| cmake | ||
| config | ||
| cross-compile/docker/cross-linux-arm64 | ||
| docker | ||
| gcc | ||
| lottiecap | ||
| pathkit | ||
| project-config | ||
| skqp | ||
| wasm-common | ||
| README.md | ||
This directory contains infra-specific files. The branch-config/ directory contains configs that are specific to the master branch (e.g. config for the CQ committing to the master branch), while project-config/ directory contains project-wide configuration (e.g. list of buckets for cr-buildbucket service and list of refs known to the infra services).