4bd08c52c0
As a follow-up to https://skia-review.googlesource.com/c/skia/+/476219, this sketches out how we can maybe use cc_library for the things in //modules to make sure something in //src doesn't depend on anything in //modules, for example. The following succeeds: bazel build //modules/skparagraph:skparagraph --config=clang \ --shaper_backend=harfbuzz_shaper --with_icu As does `make bazel_canvaskit_debug` in //modules/canvaskit Suggested Review Order: - third_party/BUILD.bazel for ICU and harfbuzz rules. Pay special attention to the genrules used to call the python script for turning the icu .dat file into .S or .cpp. - bazelrc and bazel/ for new flags and defines that control use of ICU and harfbuzz. Unlike GN, with the public_defines that get added in automatically if icu or harfbuzz is depended upon, we need to set the defines at the top level. This necessity might go away if we change the atoms to depend on //modules/skshaper, which could define that flag. - Top level BUILD.bazel files in //modules/skparagraph, //modules/skshaper, //modules/skunicode, //modules/canvaskit - All other .bazel file changes are automatic. Bug: skia:12541 Change-Id: I38a9e0a9261d7e142eeb271c2ddb23f362f91473 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/478116 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com> |
||
|---|---|---|
| .. | ||
| BUILD.bazel | ||
| Sk1DPathEffect.h | ||
| Sk2DPathEffect.h | ||
| SkBlenders.h | ||
| SkBlurDrawLooper.h | ||
| SkBlurMaskFilter.h | ||
| SkColorMatrix.h | ||
| SkColorMatrixFilter.h | ||
| SkCornerPathEffect.h | ||
| SkDashPathEffect.h | ||
| SkDiscretePathEffect.h | ||
| SkGradientShader.h | ||
| SkHighContrastFilter.h | ||
| SkImageFilters.h | ||
| SkLayerDrawLooper.h | ||
| SkLumaColorFilter.h | ||
| SkOpPathEffect.h | ||
| SkOverdrawColorFilter.h | ||
| SkPerlinNoiseShader.h | ||
| SkRuntimeEffect.h | ||
| SkShaderMaskFilter.h | ||
| SkStrokeAndFillPathEffect.h | ||
| SkTableColorFilter.h | ||
| SkTableMaskFilter.h | ||
| SkTrimPathEffect.h | ||