AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4c412bce4c
skia2/tests/sksl/blend/golden
History
John Stiles 4c412bce4c Revert "Reland "Remove inliner from IR generation stage."" 
This reverts commit e497a08065.

Reason for revert: Pinpoint disagrees

Original change's description:
> Reland "Remove inliner from IR generation stage."
>
> This reverts commit 941fc7174f.
>
> Reason for revert: performance now seems to be roughly equal or better
> (~1%) over several trials.
> Nanobench: http://screen/A8e8sojaXBgbMgF
>
> Original change's description:
> > Revert "Remove inliner from IR generation stage."
> >
> > This reverts commit 21d7778cb5.
> >
> > Reason for revert: Pinpoint absolutely hates this change
> >
> > Original change's description:
> > > Remove inliner from IR generation stage.
> > >
> > > There is no need to inline code during IR generation, as the optimizer
> > > can now handle this.
> > >
> > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b
> > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971
> > > Commit-Queue: John Stiles <johnstiles@google.com>
> > > Commit-Queue: Brian Osman <brianosman@google.com>
> > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > Auto-Submit: John Stiles <johnstiles@google.com>
> >
> > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
> >
> > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976
> > Reviewed-by: John Stiles <johnstiles@google.com>
> > Commit-Queue: John Stiles <johnstiles@google.com>
>
> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
>
> Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891
> Reviewed-by: John Stiles <johnstiles@google.com>
> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: I79149467565f22f53b8c28868dd53b80f3421137
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2020-10-13 15:20:28 +00:00
..
BlendClear.glsl Undo call-count fix for intrinsic functions. 2020-10-12 15:58:27 +00:00
BlendClear.metal Undo call-count fix for intrinsic functions. 2020-10-12 15:58:27 +00:00
BlendClearStandaloneSettings.glsl Undo call-count fix for intrinsic functions. 2020-10-12 15:58:27 +00:00
BlendColor.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendColor.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendColorBurn.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendColorBurn.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendColorBurnStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendColorDodge.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendColorDodge.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendColorDodgeStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendColorStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDarken.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDarken.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDarkenStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDifference.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDifference.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDifferenceStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDst.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDst.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstAtop.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstAtop.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstAtopStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstIn.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstIn.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstInStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstOut.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstOut.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstOutStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstOver.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstOver.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstOverStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendDstStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendExclusion.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendExclusion.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendExclusionStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendHardLight.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendHardLight.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendHardLightStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendHue.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendHue.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendHueStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendLighten.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendLighten.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendLightenStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendLuminosity.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendLuminosity.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendLuminosityStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendModulate.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendModulate.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendModulateStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendMultiply.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendMultiply.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendMultiplyStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendOverlay.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendOverlay.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendOverlayStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendPlus.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendPlus.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendPlusStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSaturation.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSaturation.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSaturationStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendScreen.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendScreen.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendScreenStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSoftLight.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSoftLight.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSoftLightStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrc.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrc.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcAtop.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcAtop.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcAtopStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcIn.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcIn.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcInStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcOut.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcOut.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcOutStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcOver.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcOver.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcOverStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendSrcStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendXor.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendXor.metal Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
BlendXorStandaloneSettings.glsl Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00