7bf799956d
This is a reland of e58831cd95
Original change's description:
> Add format-specifier warnings to SkDebugf.
>
> This CL fixes up many existing format-specifier violations in Skia.
> Note that GCC has a warning for formatting nothing, so existing calls to
> `SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
> These were apparently meant to be used as a place to set a breakpoint.
>
> Some of our clients also use SkDebug with bad format specifiers, so this
> check is currently only enabled when SKIA_IMPLEMENTATION is true.
>
> Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
> Bug: skia:12143
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
> Auto-Submit: John Stiles <johnstiles@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
Bug: skia:12143
Change-Id: Id3c0c21436ebd13899908d5ed5d44c42a0e23921
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421918
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
21 lines
894 B
C++
21 lines
894 B
C++
// Copyright 2019 Google LLC.
|
|
// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
|
|
#include "tools/fiddle/examples.h"
|
|
// HASH=9c6edd836c573a0fd232d2b8aa11a678
|
|
REG_FIDDLE(Path_readFromMemory, 256, 256, true, 0) {
|
|
void draw(SkCanvas* canvas) {
|
|
SkPath path, copy;
|
|
path.lineTo(6.f / 7, 2.f / 3);
|
|
size_t size = path.writeToMemory(nullptr);
|
|
SkTDArray<char> storage;
|
|
storage.setCount(size);
|
|
path.writeToMemory(storage.begin());
|
|
size_t wrongSize = size - 4;
|
|
size_t bytesRead = copy.readFromMemory(storage.begin(), wrongSize);
|
|
SkDebugf("length = %zu; returned by readFromMemory = %zu\n", wrongSize, bytesRead);
|
|
size_t largerSize = size + 4;
|
|
bytesRead = copy.readFromMemory(storage.begin(), largerSize);
|
|
SkDebugf("length = %zu; returned by readFromMemory = %zu\n", largerSize, bytesRead);
|
|
}
|
|
} // END FIDDLE
|