b0cee9bf9a
SkCanvas keeps its non-exotic drawBitmap calls for now but they immediately wrap the bitmap in SkImage::MakeFromBitmap. This will add a copy for mutable bitmaps, but this can be worked around by using images directly (preferred), or marking the bitmap as immutable. In practice, mutable bitmaps do not seem to be widely used so this is deemed acceptable for now. Several GMs are updated to mark the bitmaps as immutable in order to avoid pixel churn in how CPU vs. GPU mipmaps are generated. As we move towards explicit mipmap generation, this distinction will become less critical, so I'm just avoiding it for now. See skbug.com/9337 for mipmap proposal. The image diffs encountered in this CL directly related to generating mipmaps for bitmaps already cached on the GPU vs. not on the GPU yet. It was decided to copy if mutable vs. never copying the bitmap because it preserves the image guarantees the devices and canvas' rely on, and imposing the need to inspect an image for mutability is undesired. Bug: skia:10037, skia:9337 Change-Id: If152e6cae1e155ccf6bd2cd755895f3c7a0135a5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276004 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
90 lines
2.8 KiB
C++
90 lines
2.8 KiB
C++
/*
|
|
* Copyright 2011 Google Inc.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
#include "gm/gm.h"
|
|
#include "include/core/SkBitmap.h"
|
|
#include "include/core/SkCanvas.h"
|
|
#include "include/core/SkFilterQuality.h"
|
|
#include "include/core/SkMatrix.h"
|
|
#include "include/core/SkPaint.h"
|
|
#include "include/core/SkRect.h"
|
|
#include "include/core/SkScalar.h"
|
|
#include "include/core/SkSize.h"
|
|
#include "include/core/SkString.h"
|
|
#include "include/core/SkTypes.h"
|
|
#include "tools/Resources.h"
|
|
#include "tools/ToolUtils.h"
|
|
|
|
namespace {
|
|
static SkSize computeSize(const SkBitmap& bm, const SkMatrix& mat) {
|
|
SkRect bounds = SkRect::MakeWH(SkIntToScalar(bm.width()),
|
|
SkIntToScalar(bm.height()));
|
|
mat.mapRect(&bounds);
|
|
return SkSize::Make(bounds.width(), bounds.height());
|
|
}
|
|
|
|
static void draw_cell(SkCanvas* canvas, const SkBitmap& bm, const SkMatrix& mat, SkScalar dx,
|
|
SkFilterQuality lvl) {
|
|
SkPaint paint;
|
|
paint.setFilterQuality(lvl);
|
|
|
|
SkAutoCanvasRestore acr(canvas, true);
|
|
|
|
canvas->translate(dx, 0);
|
|
canvas->concat(mat);
|
|
canvas->drawBitmap(bm, 0, 0, &paint);
|
|
}
|
|
|
|
static void draw_row(SkCanvas* canvas, const SkBitmap& bm, const SkMatrix& mat, SkScalar dx) {
|
|
draw_cell(canvas, bm, mat, 0 * dx, kNone_SkFilterQuality);
|
|
draw_cell(canvas, bm, mat, 1 * dx, kLow_SkFilterQuality);
|
|
draw_cell(canvas, bm, mat, 2 * dx, kMedium_SkFilterQuality);
|
|
draw_cell(canvas, bm, mat, 3 * dx, kHigh_SkFilterQuality);
|
|
}
|
|
|
|
class FilterIndiaBoxGM : public skiagm::GM {
|
|
SkBitmap fBM;
|
|
SkMatrix fMatrix[2];
|
|
|
|
void onOnceBeforeDraw() override {
|
|
constexpr char kResource[] = "images/box.gif";
|
|
if (!GetResourceAsBitmap(kResource, &fBM)) {
|
|
fBM.allocN32Pixels(1, 1);
|
|
fBM.eraseARGB(255, 255, 0 , 0); // red == bad
|
|
}
|
|
fBM.setImmutable();
|
|
|
|
SkScalar cx = SkScalarHalf(fBM.width());
|
|
SkScalar cy = SkScalarHalf(fBM.height());
|
|
|
|
float vertScale = 30.0f/55.0f;
|
|
float horizScale = 150.0f/200.0f;
|
|
|
|
fMatrix[0].setScale(horizScale, vertScale);
|
|
fMatrix[1].setRotate(30, cx, cy); fMatrix[1].postScale(horizScale, vertScale);
|
|
}
|
|
|
|
SkString onShortName() override { return SkString("filterindiabox"); }
|
|
|
|
SkISize onISize() override { return {680, 130}; }
|
|
|
|
void onDraw(SkCanvas* canvas) override {
|
|
canvas->translate(10, 10);
|
|
for (size_t i = 0; i < SK_ARRAY_COUNT(fMatrix); ++i) {
|
|
SkSize size = computeSize(fBM, fMatrix[i]);
|
|
size.fWidth += 20;
|
|
size.fHeight += 20;
|
|
|
|
draw_row(canvas, fBM, fMatrix[i], size.fWidth);
|
|
canvas->translate(0, size.fHeight);
|
|
}
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
DEF_GM( return new FilterIndiaBoxGM(); )
|