54bd442fad
The file generation logic that dawn [1] uses to make some
source files requires jinja2, which also requires MarkupSafe.
The GN build handles this by specifying those repos in
DEPS, checking them out at a certain git hash, and then
providing them via a command line arg [2].
We do not have to do it this way in Bazel to have reproducible
builds. This CL specifies an exact version (verified by sha256)
of those two deps and then uses a hermetic version of
Python 3.9 to run all py_binary commands.
Previously, we would rely on the system Python (and installed
libraries). That happened to work on my machine, but not on
other machines without jinja2 and MarkupSafe installed. After
this CL, it should work on machines that do not have python
even installed.
I chose the same jinja2 version used by Dawn [3], which was
2.11.3. Then I chose the newest version of MarkupSafe that
was compatible with jinja2 (2.0.1).
If we have other python scripts that need external deps, we
should be able to specify them in the py_binary that needs
them and in requirements.txt. Then, the pip_install() step
in WORKSPACE.bazel will download them and make them available.
[1] https://dawn.googlesource.com/dawn.git/+/refs/heads/main/docs/dawn/overview.md
[2] https://dawn.googlesource.com/dawn.git/+/e45ff6a4b3c2f06dade68ec0f01ddc3bfd70c282/generator/generator_lib.gni#77
[3]
|
||
|---|---|---|
| .. | ||
| angle2 | ||
| brotli | ||
| cpu-features | ||
| d3d12allocator | ||
| dng_sdk | ||
| etc1 | ||
| expat | ||
| freetype2 | ||
| harfbuzz | ||
| highway | ||
| icu | ||
| imgui | ||
| libjpeg-turbo | ||
| libjxl | ||
| libmicrohttpd | ||
| libpng | ||
| libwebp | ||
| lua | ||
| native_app_glue | ||
| oboe | ||
| piex | ||
| sfntly | ||
| skcms | ||
| spirv-cross | ||
| vulkanmemoryallocator | ||
| wuffs | ||
| zlib | ||
| BUILD.bazel | ||
| BUILD.gn | ||
| file_map_for_bazel.json | ||
| README | ||
| third_party.gni | ||
The third_party directory contains a set of dependencies from outside sources that are needed to build various components and tools within Skia. Some of these dependencies reside within the Skia repo, while others are pulled from other repositories and placed in the third_party/externals directory during build. These external dependencies are defined in a DEPS file. Products in third_party are subject to their own respective license terms. The license for each project should be included in the source itself via a license header or file. If the source itself does not include a license header or file, create a README that refers to reliable documentation of the project's license terms on the web.