skia2/tools/sk_app/android
Kevin Lubick 4511c7b7fb [bazel] Delete gazelle-based BUILD.bazel files
gazelle ended up being more liability than asset for our C++ rules.

It required devs to manually run the command frequently (and was
easy to forget until the CQ failed). The fact that we still had to
edit the source files (e.g. the "srcs" cc_libraries) meant that
the mixture between generated and hand-written caused some
tension (see include/third_party/vulkan for a good example).

The combination of gazelle and our IWYU enforcement added several
bits of churn without any real benefit. The generated rules
also didn't help identify cases where we were not keeping tight
boundaries (e.g. non-gpu code and gpu code).

Identifying third_party deps automatically ended up being trickier
than anticipated (see the deleted //third_party/file_map_for_bazel.json)

Using the "maximum set of dependencies" worked ok, but ended up
increasing build time unnecessarily. For example, compiling
CanvasKit for WebGL always needed to compile Dawn because
SkSLCompiler.cpp sometimes needs to include tint/tint.h.

Follow-up CLs will rebuild the BUILD.bazel rules without gazelle.

Note to Reviewers:
 - The only file worth manually reviewing here is bazel/Makefile.

Change-Id: I36d6fc3747487fabaf699690780c95f1f6765770
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/543976
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-05-31 14:14:54 +00:00
..
GLWindowContext_android.cpp Replace 'typedef xxxxx INHERITED' with 'using INHERITED = xxxx;'. 2020-09-03 03:41:26 +00:00
main_android.cpp Convert 0 and NULL to nullptr. 2022-02-09 14:20:57 +00:00
RasterWindowContext_android.cpp Replace 'typedef xxxxx INHERITED' with 'using INHERITED = xxxx;'. 2020-09-03 03:41:26 +00:00
surface_glue_android.cpp Prepare to reenable unreachable-code warnings. 2022-02-04 21:45:39 +00:00
surface_glue_android.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
VulkanWindowContext_android.cpp In vulkan tests, use vkGetInstanceProcAddr to get vkGetDeviceProcAddr. 2022-01-14 17:04:16 +00:00
Window_android.cpp Revert "Fix crash on windows viewer when starting in vulkan." 2020-12-16 14:52:07 +00:00
Window_android.h rewrite includes to not need so much -Ifoo 2019-04-24 16:27:11 +00:00
WindowContextFactory_android.h tools/sk_app: fWindowContext is unique_ptr<> 2019-08-02 16:16:34 +00:00