skia2/modules
Florin Malita 6a2a637746 [skottie] Fix Keyframe::Value equality operator
Per spec, reading anything other than the most recently written
union member is undefined behavior.

Keyframe containers always access the same member, consistently.  But
the type-agnostic equality operator does touch both members.

Refactor to avoid undefined behavior.

Also add a couple of unit tests to capture keyframe deduping behavior
(which in turn relies on the equality operator).

Change-Id: I7ba9c335ef28af7ddc71bd6f03d56b891fbdea1e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/451016
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
2021-09-21 19:23:26 +00:00
..
androidkit expose Font to JetSki 2021-09-07 21:51:30 +00:00
audioplayer implement SkAudioPLayer for Android 2020-12-15 00:12:48 +00:00
canvaskit [canvaskit] Roll 0.30.0 2021-09-15 13:21:25 +00:00
particles Remove blend and colorFilter sksl modules 2021-08-31 17:35:19 +00:00
pathkit [infra] Port serve.py from Python2 to 3 2021-08-31 15:28:19 +00:00
skottie [skottie] Fix Keyframe::Value equality operator 2021-09-21 19:23:26 +00:00
skparagraph Reland "Reland "Small changes for SkText that are not in experimental directory"" 2021-09-15 15:31:14 +00:00
skplaintexteditor Reland "Add format-specifier warnings to SkDebugf." 2021-06-25 17:57:43 +00:00
skresources ResourceProviderProxyBase should forward loadAudioAsset() 2021-02-09 01:24:04 +00:00
sksg Pass CTM to path effects (experimental) 2021-07-13 18:42:55 +00:00
skshaper Reland "Experimental ICU runtime linking" 2021-07-27 19:51:31 +00:00
skunicode Reland "Reland "Small changes for SkText that are not in experimental directory"" 2021-09-15 15:31:14 +00:00
svg Reland "Fix compilation w/ "skia_enable_svg = false" (take 2)" 2021-09-01 17:54:08 +00:00