Go to file
senorblanco@chromium.org 68250c8e7c Fix for empty saveLayer() with a filter which affects transparent black.
If an saveLayer()/restore() is recorded, tilegrid/rtree will cull them
out and not draw anything. This is correct for most cases, but if the
paint in the saveLayer() is one that affects transparent black (e.g.,
it contains a color filter or image filter which affects transparent
black), this is incorrect: the filter should be applied.

Fixed by adding a no-op between the saveLayer() and restore(), and
adding a bbox node pointing at that node with the saveLayer()'s bounds.

This exposed a bug in SkPictureRecord.cpp's match(), where it would
assert if the NOOP was the last op seen. Fixed with an early-out before
calling peek_op_and_size().

BUG=skia:2254

Review URL: https://codereview.chromium.org/262363007

git-svn-id: http://skia.googlecode.com/svn/trunk@14604 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-06 22:52:55 +00:00
animations first cut at a checkbox 2009-10-21 19:41:10 +00:00
bench Relaxes bench range upper bound by a bit. 2014-05-06 04:49:13 +00:00
debugger Sanitizing source files in Housekeeper-Nightly 2014-04-24 03:05:07 +00:00
dm DM: test SkRecord with and without optimization. 2014-05-06 19:48:02 +00:00
docs warn that docs/quickstart.md is out of sync with official docs 2014-04-21 19:18:46 +00:00
expectations Greenify bench bot Perf-Android-Nexus7-Tegra3-Arm7-Release at build 2774 2014-05-05 09:51:09 +00:00
experimental Square pixels on zoom. 2014-05-06 13:04:35 +00:00
forth Sanitizing source files in Skia_Periodic_House_Keeping 2013-01-26 07:06:02 +00:00
gm make compare_rendered_pictures process render_pictures's new JSON output format 2014-05-06 15:31:31 +00:00
gyp remove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE 2014-05-06 21:00:01 +00:00
include add local-matrix to shader::context 2014-05-06 17:16:03 +00:00
platform_tools Run Android make script from any directory 2014-05-06 18:31:09 +00:00
resources Reland "Properly set alpha type in webp decode." 2014-04-24 18:55:13 +00:00
samplecode remove code behind SK_SUPPORT_LEGACY_PROCXFERMODE 2014-05-01 15:56:52 +00:00
src Fix for empty saveLayer() with a filter which affects transparent black. 2014-05-06 22:52:55 +00:00
tests Fix for empty saveLayer() with a filter which affects transparent black. 2014-05-06 22:52:55 +00:00
third_party Drop executable flag from headers so that they can be packaged 2014-03-11 19:55:51 +00:00
tools Add dump_record to make inspecting before/after SkRecordOptimize easy. 2014-05-06 20:38:24 +00:00
trybots_to_run/chrome Deleting the hardcoded list of compile bots in trybots_to_run. 2013-04-09 11:59:42 +00:00
.gitignore clean up gitignore; sort, add chromeos/externals, remove trailing /. 2014-04-17 22:56:46 +00:00
AUTHORS Fixed Skia compilation error with strict clang. 2014-04-07 13:12:47 +00:00
codereview.settings Add BUG_PREFIX to codereview.settings 2014-01-14 21:19:21 +00:00
CONTRIBUTING Add CONTRIBUTING file 2014-01-13 15:06:26 +00:00
CQ_COMMITTERS Add fmalita@chromium.org to CQ_COMMITTERS. 2014-05-01 13:32:21 +00:00
DEPS Revert of Roll ANGLE. (https://codereview.chromium.org/237173002/) 2014-05-01 20:20:50 +00:00
Doxyfile update Doxygen config file to include gpu directory in api generation 2014-03-07 16:20:36 +00:00
gyp_skia allow gyp_skia to be run from any directory. 2014-04-17 16:11:58 +00:00
gyp_skia.py Roll gyp deps from 1765 to 1796. 2013-11-21 18:11:14 +00:00
LICENSE Manually update copyright notices in files that defied the automated process 2011-07-28 14:24:55 +00:00
make.bat Make make.bat and gyp_skia work with VS 2012. 2013-05-07 19:31:20 +00:00
make.py change default build (in "make" wrapper) to ninja on all platforms 2014-04-01 07:02:41 +00:00
Makefile simplify tools/xsan_build now that make runs ninja 2014-04-24 18:16:13 +00:00
Makefile.old Replace GR_*_BUILD by their SK_BUILD_FOR_* equivalents. 2013-09-25 20:57:51 +00:00
OWNERS add root files from chrome 2013-08-13 19:11:15 +00:00
PRESUBMIT.py Check if the issue owner is in the AUTHORS file in PRESUBMIT.py 2014-02-03 14:18:32 +00:00
README whitespace commit to trigger buildbot 2011-07-15 14:11:58 +00:00
README.chromium add root files from chrome 2013-08-13 19:11:15 +00:00
skia.gyp Remove the comments settings for vim tab width and expansion variables. 2013-12-02 22:23:03 +00:00
whitespace.txt Whitespace change to test skia CQ. 2014-05-06 15:20:53 +00:00

Skia is a complete 2D graphic library for drawing Text, Geometries, and Images.

See full details, and build instructions, at http://code.google.com/p/skia/wiki/DocRoot