6a10556775
ES2 disallows opaque types in expressions (other than passing them to their associated builtin functions). We now enforce a similar restriction on SkSL opaque types. While I was there, I added several other cases to the invalid-shader test to make sure that they were all caught. I needed to reorder some code to make sure that ternary expression error messages didn't change. Ternary expressions now check for opaque types before checking that the left-side type and right-side type are compatible. This is because we check for "compatible" ternary expressions by checking if `leftSide == rightSide` would be accepted. `shader1 == shader2` used to be considered a valid expression for the purposes of this test, but not anymore. Change-Id: I62a0a31feca9dadd428da7d1b48d7693c4b6434d Bug: skia:13026 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/516802 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> |
||
|---|---|---|
| .. | ||
| android_fonts | ||
| diff_canvas_traces | ||
| empty_images | ||
| fonts | ||
| icc_profiles | ||
| images | ||
| invalid_images | ||
| nima | ||
| particles | ||
| skottie | ||
| sksl | ||
| text | ||
| Cowboy.svg | ||
| crbug769134.fil | ||
| nov-talk-sequence.txt | ||
| pdf_command_stream.txt | ||
| README | ||
The resources directory includes some third party content used by Skia. Licenses for that code are included in this file. Openclipart Openclipart uses the Creative Commons Zero 1.0 Public Domain License every time an artist uploads a piece of clipart to Openclipart to make it clear the artist is releasing the creative work for anyone to use for any reason, even commercially. This act of "sharing" is the foundation Openclipart is based upon. More details on the license can be found at https://creativecommons.org/publicdomain/zero/1.0/. LGPL or compatible (as implied by inclusion in KDE SVN) http://websvn.kde.org/trunk/tests/ksvgtests/custom/cowboy.svg