e56774602c
Bug: b/65290323 If a webp file is truncated such that no rows can be decoded, WebPIDecGetRGB does not initialize its "last_y" parameter. We use rowsDecoded (passed as last_y) to determine which remaining rows to fill. Check the return value of WebPIDecGetRGB. If it fails (returns null), or rowsDecoded is <= 0 (matching Chromium's check), return kInvalidInput, since there is nothing to draw. Note that this is a change in behavior for Android. Previously we would decode an empty webp to just a transparent/black rectangle, whereas now we simply fail. I think this is a change for the better. Add a test which truncates a file to have 0 rows available and attempts to decode it. msan verifies that we no longer depend on the uninitialized value. Stop attempting to test decoding subsets from an incomplete webp (in CodecTest.cpp). Unless we have decoded the portion covered by the subset, this will fail. Remove test images inc0.webp (from both dm/ and colorspace/) and inc1.webp. These just decode to transparent rectangles. Replace them with inc2.webp and inc3.webp, which decode part of the image and then have to fill with transparent. Change-Id: I64d40be91c574b45963f9a43d8dd8f4929dd2939 Reviewed-on: https://skia-review.googlesource.com/50303 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: James Zern <jzern@google.com> |
||
|---|---|---|
| .. | ||
| assets | ||
| ct | ||
| recipe_modules | ||
| recipes | ||
| tools/luci-go | ||
| android_bin.isolate | ||
| assets.isolate | ||
| bootstrap_win_toolchain_json.py | ||
| bundle_recipes.isolate | ||
| cfg.json | ||
| compile_skia.isolate | ||
| coverage_skia.isolate | ||
| ct_skps_skia.isolate | ||
| gen_tasks.go | ||
| git_utils.py | ||
| housekeeper_skia.isolate | ||
| infra_skia.isolate | ||
| infra_tests.py | ||
| infrabots.isolate | ||
| ios_bin.isolate | ||
| isolate_skimage.isolate | ||
| isolate_skp.isolate | ||
| isolate_svg.isolate | ||
| jobs.json | ||
| Makefile | ||
| meta_config.isolate | ||
| OWNERS | ||
| perf_skia_bundled_unix.isolate | ||
| perf_skia_bundled_win.isolate | ||
| perf_skia_bundled.isolate | ||
| perf_skia.isolate | ||
| presubmit_skia.isolate | ||
| README.md | ||
| README.recipes.md | ||
| recipes.py | ||
| resources.isolate | ||
| skia_repo.isolate | ||
| skpbench_skia_bundled_unix.isolate | ||
| skpbench_skia_bundled_win.isolate | ||
| skpbench_skia_bundled.isolate | ||
| skpbench_skia.isolate | ||
| swarm_recipe_bundled_unix.isolate | ||
| swarm_recipe_bundled_win.isolate | ||
| swarm_recipe.isolate | ||
| tasks.json | ||
| test_skia_bundled_unix.isolate | ||
| test_skia_bundled_win.isolate | ||
| test_skia_bundled.isolate | ||
| test_skia.isolate | ||
| test_utils.py | ||
| update_meta_config.py | ||
| upload_dm_results.isolate | ||
| upload_nano_results.isolate | ||
| upload_skps.py | ||
| utils.py | ||
| win_toolchain_utils.py | ||
| zip_utils_test.py | ||
| zip_utils.py | ||
Skia Infrastructure
This directory contains infrastructure elements.
Tasks and Jobs
Files in this directory define a DAG of tasks which run at every Skia commit. A task is a small, self-contained unit which runs via Swarming on a machine in the pool. Tasks may be chained together, eg. one task to compile test binaries and another to actually run them.
Jobs are collections of related tasks which help define sub-sections of the DAG, for example, to be used as try jobs. Each job is defined as an entry point into the DAG.
The tasks.json file in this directory is the master list of tasks and jobs for the repo. Note that tasks.json is NEVER edited by hand but generated via gen_task.go and the input files enumerated below. The Task Scheduler reads the tasks.json file at each commit to determine which jobs to run. For convenience, gen_tasks.go is provided to generate tasks.json and also to test it for correct syntax and detecting cycles and orphaned tasks. Always edit gen_tasks.go or one of the following input JSON files, rather than tasks.json itself:
- android_map.json - Maps human-friendly names of Android devices to their device codename and desired OS version. Edit this file when adding a new type of Android device or updating the desired OS version.
- cfg.json - Basic configuration information for gen_tasks.go.
- gpu_map.json - Maps human-friendly names of GPUs to an appropriate Swarming dimension, typically the PCI ID of the GPU. Edit this file when adding a new GPU.
- jobs.json - The master list of all jobs to run. Edit this to add or remove bots.
Whenever gen_tasks.go, any of the above JSON files, or assets are changed, you need to run gen_tasks.go to regenerate tasks.json:
$ go run infra/bots/gen_tasks.go
Or:
$ cd infra/bots; make train
There is also a test mode which performs sanity-checks and verifies that tasks.json is unchanged:
$ go run infra/bots/gen_tasks.go --test
Or:
$ cd infra/bots; make test
Recipes
Recipes are the framework used by Skia's infrastructure to perform work inside of Swarming tasks. The main elements are:
- recipes.py - Used for running and testing recipes.
- recipes - These are the entry points for each type of task, eg. compiling or running tests.
- recipe_modules - Shared modules which are used by recipes.
- .recipe_deps - Recipes and modules may depend on modules from other repos. The recipes.py script automatically syncs those dependencies in this directory.
Isolate Files
These files determine which parts of the repository are transferred to the bot when a Swarming task is triggered. The Isolate tool hashes each file and will upload any new/changed files. Bots maintain a cache so that they can efficiently download only the files they don't have.
Assets
Artifacts used by the infrastructure are versioned here, along with scripts for recreating/uploading/downloading them. See the README in that directory for more information. Any time an asset used by the bots changes, you need to re-run gen_tasks.go.
Tools
Assorted other infrastructure-related tools, eg. isolate and CIPD binaries.
CT
Helpers for running Skia tasks in Cluster Telemetry.