skia2/modules/canvaskit
William Candillon bce36c5654 Add ImageFilters::MakeShader() to CanvasKit
Change-Id: I1c5cd1b7404b52ecb5a324b212d8913e3376c3c7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/558257
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2022-07-14 12:28:35 +00:00
..
external_test [canvaskit] Add tests/examples for using CanvasKit with Typescript. 2021-11-05 20:18:30 +00:00
fonts
future_apis
go/gold_test_env [bazel] Add rules for CanvasKit and dependent modules 2022-05-31 14:14:54 +00:00
htmlcanvas [canvaskit] Add rough measureText to Canvas2D emulation layer 2021-12-09 13:07:24 +00:00
npm_build Add ImageFilters::MakeShader() to CanvasKit 2022-07-14 12:28:35 +00:00
tests Add ImageFilters::MakeShader() to CanvasKit 2022-07-14 12:28:35 +00:00
wasm_tools [bazel] Compile gms for wasm and WebGL 2022-02-09 18:56:17 +00:00
.gitignore [infra] Add initial Bazel rules and files 2021-11-09 12:32:25 +00:00
BUILD.bazel [bazel] Use exec_tools instead of tools for better RBE compatibility 2022-06-30 18:02:35 +00:00
BUILD.gn [canvaskit] Implement WebGPU API methods for surface creation 2022-06-28 22:53:12 +00:00
canvaskit_bindings.cpp Add ImageFilters::MakeShader() to CanvasKit 2022-07-14 12:28:35 +00:00
canvaskit.gni [canvaskit] Enable WebGPU in GN build 2022-06-16 23:14:17 +00:00
catchExceptionNop.js
CHANGELOG.md Add ImageFilters::MakeShader() to CanvasKit 2022-07-14 12:28:35 +00:00
color.js [canvaskit] Remove *Builders in favor of Malloc. 2021-06-03 17:43:58 +00:00
compile_gm.sh [canvaskit] Enable WebGPU in GN build 2022-06-16 23:14:17 +00:00
compile.sh [canvaskit] Enable WebGPU in GN build 2022-06-16 23:14:17 +00:00
cpu.js [canvaskit] Enable WebGPU in GN build 2022-06-16 23:14:17 +00:00
debug.js
debugger_bindings.cpp [canvaskit] Enable WebGPU in GN build 2022-06-16 23:14:17 +00:00
debugger.js Add debugger as an optional module in canvaskit 2022-03-03 21:06:17 +00:00
externs.js [canvaskit] Expose more ImageFilters 2022-07-12 17:36:52 +00:00
font.js [canvaskit] Add test to prove we have COLRv1 font support 2022-03-31 16:14:31 +00:00
gm_bindings.cpp Add CurrestTestHarness helper method to WasmGMTests. 2022-03-10 21:14:03 +00:00
gm.js
interface.js [canvaskit] Expose more ImageFilters 2022-07-12 17:36:52 +00:00
karma.bazel.js [canvaskit] Run JS tests in Bazel 2022-02-28 21:30:21 +00:00
karma.conf.js [canvaskit] Fix test search path 2021-12-07 19:43:27 +00:00
karma.google3.conf.js
Makefile [canvaskit] Enable WebGPU in GN build 2022-06-16 23:14:17 +00:00
matrix.js [canvaskit] Move matrix helpers to their own file and make optional. 2021-02-01 20:01:07 +00:00
memory.js Preserve Z when converting 3x3 to 4x4 matrix 2022-06-10 16:33:53 +00:00
package-lock.json [canvaskit] Expose more ImageFilters 2022-07-12 17:36:52 +00:00
package.json Bump karma from 6.3.2 to 6.3.16 in /modules/canvaskit 2022-03-02 14:36:51 +00:00
paragraph_bindings_gen.cpp [canvaskit] Add TextHeightBehavior 2021-04-22 18:21:44 +00:00
paragraph_bindings.cpp [ck] Expose ParagraphBuilderImpl::Reset to CanvasKit 2022-02-02 15:54:21 +00:00
paragraph.js [canvaskit] Remove deprecated MakeTypefaceFromData and RefDefault 2021-10-21 16:45:42 +00:00
particles_bindings.cpp [canvaskit] Introduce self-documenting pointer types 2021-05-27 12:30:54 +00:00
particles.js [canvaskit] Fix particles.setPosition and add test. 2021-02-03 15:52:23 +00:00
pathops.js
postamble.js
preamble.js
README.md Reland "Build CanvasKit using GN/Ninja" 2022-02-15 16:31:10 +00:00
release.js
rt_shader.js [canvaskit] Fix uniform handling for makeShader and MallocObj 2022-05-24 16:33:17 +00:00
skottie_bindings.cpp [canvaskit] Rename some CK-specific defines 2022-02-15 22:42:17 +00:00
skottie.js [skottie/wasm] Plumb text properties in WASM bindings 2021-03-10 18:34:04 +00:00
skp.js [canvaskit] Remove isNode and saveAsPicture 2021-04-16 20:55:54 +00:00
util.js [canvaskit] Remove isNode and saveAsPicture 2021-04-16 20:55:54 +00:00
viewer_bindings.cpp
WasmCommon.h [canvaskit] Expose Canvas.getDeviceClipBounds() 2022-05-24 13:28:25 +00:00
webgl.js [canvaskit] Handle Premul textures better 2022-06-29 15:25:03 +00:00
webgpu.js [canvaskit] Implement WebGPU API methods for surface creation 2022-06-28 22:53:12 +00:00

Prerequisites

Node v14 or later is required to run tests. We use npm (the Node Package Manager) to install test dependencies. Recent installations of Node have npm as well. CanvasKit has no other external source dependencies.

Compiling with GN

To build with GN, you need to have followed the instructions to download Skia and its deps https://skia.org/user/download.

To compile CanvasKit, you will first need to download and activate emscripten using the script in //bin/activate-emsdk (or //bin/git-sync-deps which also calls activate-emsdk). This places the associated files in //third_party/externals/emsdk and the GN2 build scripts will use those by default. The compile.sh script automates the default GN settings; users are free to set their own. If users want to use their own version of emscripten, they should set the skia_emsdk_dir argument (see //skia/gn/toolchain/wasm.gni). For other available arguments, see //modules/canvaskit/BUILD.gn.

MacOS specific notes

Make sure you have Python3 installed, otherwise the downloading emscripten toolchain can fail with errors about SSL certificates. https://github.com/emscripten-core/emsdk/pull/273

See also https://github.com/emscripten-core/emscripten/issues/9036#issuecomment-532092743 for a solution to Python3 using the wrong certificates.

Compile and Run Local Example

# The following installs all npm dependencies and only needs to be when setting up
# or if our npm dependencies have changed (rarely).
npm ci

make release  # make debug is much faster and has better error messages
make local-example

This will print a local endpoint for viewing the example. You can experiment with the CanvasKit API by modifying ./npm_build/example.html and refreshing the page. For some more experimental APIs, there's also ./npm_build/extra.html.

For other available build targets, see Makefile and compile.sh. For example, building a stripped-down version of CanvasKit with no text support or any of the "extras", one might run:

./compile.sh no_skottie no_particles no_font

Such a stripped-down version is about half the size of the default release build.

Unit tests, performance tests, and coverage.

To run unit tests and compute test coverage on a debug gpu build

make debug
make test-continuous

This reads karma.conf.js, and opens a Chrome browser and begins running all the test in test/ it will detect changes to the tests in that directory and automatically run again, however it will automatically rebuild and reload CanvasKit. Closing the chrome window will just cause it to re-opened. Kill the karma process to stop continuous monitoring for changes.

The tests are run with whichever build of CanvasKit you last made. be sure to also test with release, debug_cpu, and release_cpu. testing with release builds will expose problems in closure compilation and usually forgotten externs.

Coverage

Coverage will be automatically computed when running test-continuous locally. Note that the results will only be useful when testing a debug build. Open coverage/<browser version>/index.html For a summary and detailed line-by-line result.

Measuring Performance

We use puppeteer to run a Chrome browser to gather performance data in a consistent way. See //tools/perf-canvaskit-puppeteer for more.

Adding tests

The tests in tests/ are grouped into files by topic. Within each file there are describe blocks further organizing the tests, and within those it() functions which test particular behaviors. describe and it are jasmine methods which can both be temporarily renamed fdescribe and fit. Which causes jasmine to only those.

We have also defined gm which is a method for defining a test which draws something to a canvas that is shapshotted and reported to gold.skia.org, where you can compare it with the snapshot at head.

Testing from Gerrit

When submitting a CL in gerrit, click "choose tryjobs" and type CanvasKit to filter them. select all of them, which at the time of this writing is four jobs, for each combination of perf/test gpu/cpu.

The performance results are reported to [perf.skia.org] and correctness results are reported to [gold.skia.org].

Coverage is not measured while running tests this way.

Inspecting output WASM

The wasm2wat tool from the WebAssembly Binary Toolkit can be used to produce a human-readable text version of a .wasm file.

The output of wasm2wat --version should be 1.0.13 (1.0.17). This version has been checked to work with the tools in wasm_tools/SIMD/. These tools programmatically inspect the .wasm output of a CanvasKit build to detect the presence of wasm SIMD operations.

Infrastructure Playbook

When dealing with CanvasKit (or PathKit) on our bots, we use Docker. Check out $SKIA_ROOT/infra/wasm-common/docker/README.md for more on building/editing the images used for building and testing.

Updating the version of Emscripten we build/test with

This presumes you have updated emscripten locally to a newer version of the sdk and verified/fixed any build issues that have arisen.

  1. Edit //bin/activate-emsdk to install and activate the desired version of Emscripten.
  2. Upload a CL with all the changes. Run all Test.+CanvasKit, Perf.+Puppeteer, Test.+PathKit, Perf.+PathKit jobs to make sure the new builds pass all tests and don't crash the perf harnesses.
  3. Send out CL for review. Feel free to point the reviewer at these steps.

Running Skia's GMs and Unit Tests against wasm+WebGL

TODO(kjlubick)

General Tips:

  • Make use of the skip lists and start indexes in the run-wasm-gm-tests.html to focus in on problematic tests.
  • Uncaught (in promise) RuntimeError: function signature mismatch tends to mean null was dereferenced somewhere. Add SkASSERT to verify.