4b09de3c90
Instead of standing goroutines pulling from a work queue, just kick off individual goroutines. No need to write a scheduler on top of another scheduler. Local runs put this at the same wall time as before while saving a little user/sys CPU time. Bot runs typically took 25-50s before this change, and now 40s, 28s, and 29s, so the same there too. We can choose whether to handle re-runs on the same goroutine or kick off new ones. I've chosen here to run them on the same goroutine (see the commented /*go*/), mostly because the bots quickly exhaust their user process limits when the reruns are all spawning FM processes in parallel. I think that means we don't need the extra parallelism. As far as I have seen, whether we kick off a goroutine or not has had no impact on wall/user/sys at all, so might as well not for now. Change-Id: If2990e07a402dee8c5706f537f503421013a5586 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/363376 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> |
||
|---|---|---|
| .. | ||
| assets | ||
| buildstats | ||
| gen_tasks_logic | ||
| recipe_modules | ||
| recipes | ||
| task_drivers | ||
| tools/luci-go | ||
| assets.isolate | ||
| build_task_drivers.sh | ||
| bundle_recipes.sh | ||
| canvaskit.isolate | ||
| cfg.json | ||
| check_deps.py | ||
| compile_android_framework.isolate | ||
| compile.isolate | ||
| empty.isolate | ||
| gen_compile_isolate.py | ||
| gen_tasks.go | ||
| git_utils.py | ||
| infra_tests.isolate | ||
| infra_tests.py | ||
| infrabots.isolate | ||
| ios_bin.isolate | ||
| jobs.json | ||
| lottie_ci.isolate | ||
| lottie_web.isolate | ||
| Makefile | ||
| OWNERS | ||
| pathkit.isolate | ||
| perf_puppeteer.isolate | ||
| perf_skia_bundled.isolate | ||
| README.md | ||
| README.recipes.md | ||
| recipes.isolate | ||
| recipes.py | ||
| resources.isolate | ||
| run_recipe.isolate | ||
| run_recipe.py | ||
| skottie_wasm.isolate | ||
| skpbench_skia_bundled.isolate | ||
| skqp.isolate | ||
| swarm_recipe.isolate | ||
| task_drivers.isolate | ||
| tasks.json | ||
| test_skia_bundled.isolate | ||
| test_utils.py | ||
| upload_skps.py | ||
| utils.py | ||
| wasm_gm_tests.isolate | ||
| whole_repo.isolate | ||
| zip_utils_test.py | ||
| zip_utils.py | ||
Skia Infrastructure
This directory contains infrastructure elements.
Tasks and Jobs
Files in this directory define a DAG of tasks which run at every Skia commit. A task is a small, self-contained unit which runs via Swarming on a machine in the pool. Tasks may be chained together, eg. one task to compile test binaries and another to actually run them.
Jobs are collections of related tasks which help define sub-sections of the DAG, for example, to be used as try jobs. Each job is defined as an entry point into the DAG.
The tasks.json file in this directory is the list of tasks and jobs for the repo. Note that tasks.json is NEVER edited by hand but generated via gen_task.go and the input files enumerated below. The Task Scheduler reads the tasks.json file at each commit to determine which jobs to run. For convenience, gen_tasks.go is provided to generate tasks.json and also to test it for correct syntax and detecting cycles and orphaned tasks. Always edit gen_tasks.go or one of the following input JSON files, rather than tasks.json itself:
- cfg.json - Basic configuration information for gen_tasks.go.
- jobs.json - The list of all jobs to run. Edit this to add or remove bots.
Whenever gen_tasks.go, any of the above JSON files, or assets are changed, you need to run gen_tasks.go to regenerate tasks.json:
$ go run infra/bots/gen_tasks.go
Or:
$ cd infra/bots; make train
There is also a test mode which performs consistency checks and verifies that tasks.json is unchanged:
$ go run infra/bots/gen_tasks.go --test
Or:
$ cd infra/bots; make test
Recipes
Recipes are the framework used by Skia's infrastructure to perform work inside of Swarming tasks. The main elements are:
- recipes.py - Used for running and testing recipes.
- recipes - These are the entry points for each type of task, eg. compiling or running tests.
- recipe_modules - Shared modules which are used by recipes.
- .recipe_deps - Recipes and modules may depend on modules from other repos. The recipes.py script automatically syncs those dependencies in this directory.
Isolate Files
These files determine which parts of the repository are transferred to the bot when a Swarming task is triggered. The Isolate tool hashes each file and will upload any new/changed files. Bots maintain a cache so that they can efficiently download only the files they don't have.
Assets
Artifacts used by the infrastructure are versioned here, along with scripts for recreating/uploading/downloading them. See the README in that directory for more information. Any time an asset used by the bots changes, you need to re-run gen_tasks.go.
Tools
Assorted other infrastructure-related tools, eg. isolate and CIPD binaries.
CT
Helpers for running Skia tasks in Cluster Telemetry.