AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
7c3515bce9
skia2/tests/sksl/inliner
History
John Stiles 4c412bce4c Revert "Reland "Remove inliner from IR generation stage."" 
This reverts commit e497a08065.

Reason for revert: Pinpoint disagrees

Original change's description:
> Reland "Remove inliner from IR generation stage."
>
> This reverts commit 941fc7174f.
>
> Reason for revert: performance now seems to be roughly equal or better
> (~1%) over several trials.
> Nanobench: http://screen/A8e8sojaXBgbMgF
>
> Original change's description:
> > Revert "Remove inliner from IR generation stage."
> >
> > This reverts commit 21d7778cb5.
> >
> > Reason for revert: Pinpoint absolutely hates this change
> >
> > Original change's description:
> > > Remove inliner from IR generation stage.
> > >
> > > There is no need to inline code during IR generation, as the optimizer
> > > can now handle this.
> > >
> > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b
> > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971
> > > Commit-Queue: John Stiles <johnstiles@google.com>
> > > Commit-Queue: Brian Osman <brianosman@google.com>
> > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > Auto-Submit: John Stiles <johnstiles@google.com>
> >
> > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
> >
> > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976
> > Reviewed-by: John Stiles <johnstiles@google.com>
> > Commit-Queue: John Stiles <johnstiles@google.com>
>
> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
>
> Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891
> Reviewed-by: John Stiles <johnstiles@google.com>
> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Auto-Submit: John Stiles <johnstiles@google.com>

TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com

Change-Id: I79149467565f22f53b8c28868dd53b80f3421137
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
2020-10-13 15:20:28 +00:00
..
golden Revert "Reland "Remove inliner from IR generation stage."" 2020-10-13 15:20:28 +00:00
DoWhileBodyMustBeInlinedIntoAScope.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
DoWhileTestCannotBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
ForBodyMustBeInlinedIntoAScope.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
ForInitializerExpressionsCanBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
ForWithoutReturnInsideCanBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
ForWithReturnInsideCannotBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
IfBodyMustBeInlinedIntoAScope.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
IfElseBodyMustBeInlinedIntoAScope.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
IfElseChainWithReturnsCanBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
IfTestCanBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
IfWithReturnsCanBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlineKeywordOverridesThreshold.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlinerAvoidsVariableNameOverlap.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlinerCanBeDisabled.sksl Add test for disabling the inliner. 2020-10-12 17:14:07 +00:00
InlinerManglesNames.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlinerWrapsEarlyReturnsWithDoWhileBlock.sksl Fix unit test for InlinerWrapsEarlyReturnsWithDoWhileBlock. 2020-09-18 21:08:52 +00:00
InlineThreshold.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlineWithInoutArgument.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlineWithModifiedArgument.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlineWithNestedBigCalls.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlineWithNestedCalls.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlineWithUnmodifiedArgument.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
InlineWithUnnecessaryBlocks.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
ShortCircuitEvaluationsCannotInlineRightHandSide.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
SwitchWithCastCanBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
SwitchWithoutReturnInsideCanBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
SwitchWithReturnInsideCannotBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
SwizzleCanBeInlinedDirectly.sksl Add new unit tests for SkSL. 2020-09-23 20:30:47 +00:00
TernaryResultsCannotBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
TernaryTestCanBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
TrivialArgumentsInlineDirectly.sksl Inline trivial single-argument constructors directly. 2020-09-30 17:06:14 +00:00
WhileBodyMustBeInlinedIntoAScope.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00
WhileTestCannotBeInlined.sksl Migrate SkSL inliner tests to golden files. 2020-09-15 15:22:12 +00:00